From: Lucas Stach <l.stach@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>, Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
patchwork-lst@pengutronix.de
Subject: Re: [PATCH] soc: imx: gpc: set DMA mask for PD platform devices
Date: Thu, 24 Jan 2019 15:34:31 +0100 [thread overview]
Message-ID: <1548340471.28802.23.camel@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5CeOxzyEG0tTKHfrNjY8WRKs=s5nBvxqZuFuJjR62eXOA@mail.gmail.com>
Hi Fabio,
Am Donnerstag, den 24.01.2019, 09:46 -0200 schrieb Fabio Estevam:
> Hi Shawn,
>
> On Tue, Sep 25, 2018 at 11:41 PM Shawn Guo <shawnguo@kernel.org>
> wrote:
> >
> > On Wed, Sep 12, 2018 at 05:27:02PM +0200, Lucas Stach wrote:
> > > The PD platform devices aren't DMA capable (as is correctly
> > > reflected
> > > in with a zero mask coherent_dma_mask). As they have a of_node
> > > attached
> > > they will go through of_dma_configure, which will warn if it
> > > finds an
> > > uninitialized DMA mask. Let the driver core know that this isn't
> > > a
> > > missing configuration, but a non DMA capable device by pointing
> > > the
> > > dma_mask to the coherent_dma_mask.
> > >
> > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > ---
> > > Since the warning that is triggered with the incomplete
> > > configuration
> > > has been introduced in the v4.19 cycle, it would nice to get this
> > > in
> > > as a fix.
> >
> > Applied as a fix, thanks.
>
> Did you forget to push this change? I still don't see it applied.
It was dropped due to discussion in the pull request:
https://patchwork.kernel.org/patch/10621589/
It seems we are stuck there and I don't have the bandwidth to follow up
with this currently.
Regards,
Lucas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-24 14:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 15:27 [PATCH] soc: imx: gpc: set DMA mask for PD platform devices Lucas Stach
2018-09-13 3:51 ` Fabio Estevam
2018-09-26 2:39 ` Shawn Guo
2019-01-24 11:46 ` Fabio Estevam
2019-01-24 14:34 ` Lucas Stach [this message]
2019-01-24 17:41 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548340471.28802.23.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=patchwork-lst@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).