From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB80BC169C4 for ; Tue, 29 Jan 2019 11:13:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACC062087E for ; Tue, 29 Jan 2019 11:13:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GQaUaFqx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACC062087E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WmmzW2er6MbFRYsoq80S/VxKGC7wD69geq0+22JuvGw=; b=GQaUaFqxkR+EWN dQILJ57AYqqp25ATQIgGCJHGRtoLDkmG5MPiWiZRSasnnnAhNtRMBLWkZ0HxabPvOpdsl7H22SQ1f j65gqh+76ggaHgJCpJ0ekHHaxlzBl1ONrSylACC4j8hoX5QCzpFZBwSEBxq4LM0gXZiTxqAvOHxc4 Eiil7k9Pjl4d6OrqeKObTwz2U8mQxOLpLIvn+qN4mtbMDsSgbaJAsqrxHbEbG5wSfdNN0Puy6uI1m BNLxU3Tg6CqX+ZmE9qKL5vIGR/YVVa53FWvhpLrYuEFmLdBjuRwUcAv5NkNlEDACS7mbII7JjCVc3 xDAiCx0ZSerzs/XIuDjA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1goRKj-0007hb-2M; Tue, 29 Jan 2019 11:13:37 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1goRKf-0007h1-Uu; Tue, 29 Jan 2019 11:13:35 +0000 X-UUID: 72837e692ceb4d0d94bbce0365a643f1-20190129 X-UUID: 72837e692ceb4d0d94bbce0365a643f1-20190129 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1602501201; Tue, 29 Jan 2019 03:13:31 -0800 Received: from mtkmbs08n2.mediatek.inc (172.21.101.56) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 29 Jan 2019 03:13:29 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 29 Jan 2019 19:13:21 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 29 Jan 2019 19:13:21 +0800 Message-ID: <1548760401.11055.14.camel@mtksdaap41> Subject: Re: [PATCH 09/10] soc: mediatek: change the argument of write and write_mask API From: CK Hu To: Bibby Hsieh Date: Tue, 29 Jan 2019 19:13:21 +0800 In-Reply-To: <1548747128-60136-10-git-send-email-bibby.hsieh@mediatek.com> References: <1548747128-60136-1-git-send-email-bibby.hsieh@mediatek.com> <1548747128-60136-10-git-send-email-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 433790CE84CD2A062C8E9A921330B0CEFFF4AA745752DFB3361EC0CCBE68712F2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190129_031333_999446_25C31654 X-CRM114-Status: GOOD ( 16.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , Philipp Zabel , srv_heupstream@mediatek.com, kendrick.hsu@mediatek.com, Daoyuan Huang , Sascha Hauer , Jassi Brar , linux-kernel@vger.kernel.org, Daniel Kurtz , Dennis-YC Hsieh , YT Shen , Rob Herring , linux-mediatek@lists.infradead.org, Houlong Wei , Sascha Hauer , Matthias Brugger , Jiaguang Zhang , Frederic Chen , linux-arm-kernel@lists.infradead.org, ginny.chen@mediatek.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Tue, 2019-01-29 at 15:32 +0800, Bibby Hsieh wrote: > In order to enhance the convienience of client usage, > we change the input argument from subsys and offset to > struct cmdq_base and dma_addr_t. > > Signed-off-by: Bibby Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 24 +++++++++++++++++------- > include/linux/soc/mediatek/mtk-cmdq.h | 16 ++++++++-------- > 2 files changed, 25 insertions(+), 15 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 923a815..34ae712 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -238,8 +238,13 @@ static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, s16 arg_c, s16 arg_b, > return 0; > } > > -int cmdq_pkt_write(struct cmdq_pkt *pkt, u8 subsys, u16 offset, u32 value) > +int cmdq_pkt_write(struct cmdq_pkt *pkt, struct cmdq_base *clt_base, > + dma_addr_t addr, u32 value) > { > + const u32 base = (addr >> 32) ? 0 : addr & 0xFFFF0000; > + u8 subsys = cmdq_subsys_base_to_id(clt_base, base); I don't understand why this would let client more convenient? Every time client call cmdq_pkt_write(), cmdq_subsys_base_to_id() would search again. Why do we need such frequently search? Regards, CK > + s16 offset = addr & 0x0000FFFF; > + > return cmdq_pkt_append_command(pkt, CMDQ_GET_ARG_C(value), > CMDQ_GET_ARG_B(value), offset, subsys, > CMDQ_IMMEDIATE_VALUE, > @@ -248,21 +253,26 @@ int cmdq_pkt_write(struct cmdq_pkt *pkt, u8 subsys, u16 offset, u32 value) > } > EXPORT_SYMBOL(cmdq_pkt_write); > > -int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys, u16 offset, > - u32 value, u32 mask) > +int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, struct cmdq_base *clt_base, > + dma_addr_t addr, u32 value, u32 mask) > { > - u32 offset_mask = offset; > + const u32 base = (addr >> 32) ? 0 : addr & 0xFFFF0000; > + u8 subsys = cmdq_subsys_base_to_id(clt_base, base); > + s16 offset = addr & 0x0000FFFF; > int err = 0; > > if (mask != 0xffffffff) { > err = cmdq_pkt_append_command(pkt, CMDQ_GET_ARG_C(~mask), > CMDQ_GET_ARG_B(~mask), 0, 0, 0, 0, > 0, CMDQ_CODE_MASK); > - offset_mask |= CMDQ_WRITE_ENABLE_MASK; > + offset |= CMDQ_WRITE_ENABLE_MASK; > } > - err |= cmdq_pkt_write(pkt, subsys, offset_mask, value); > > - return err; > + return cmdq_pkt_append_command(pkt, CMDQ_GET_ARG_C(value), > + CMDQ_GET_ARG_B(value), offset, subsys, > + CMDQ_IMMEDIATE_VALUE, > + CMDQ_IMMEDIATE_VALUE, > + CMDQ_IMMEDIATE_VALUE, CMDQ_CODE_WRITE); > } > EXPORT_SYMBOL(cmdq_pkt_write_mask); > > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > index e4d1876..230bc2b 100644 > --- a/include/linux/soc/mediatek/mtk-cmdq.h > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > @@ -70,26 +70,26 @@ struct cmdq_client *cmdq_mbox_create(struct device *dev, int index, > /** > * cmdq_pkt_write() - append write command to the CMDQ packet > * @pkt: the CMDQ packet > - * @subsys: the CMDQ sub system code > - * @offset: register offset from CMDQ sub system > + * @cmdq_base: the CMDQ sub system code and base address > + * @addr: register address > * @value: the specified target register value > * > * Return: 0 for success; else the error code is returned > */ > -int cmdq_pkt_write(struct cmdq_pkt *pkt, u8 subsys, u16 offset, u32 value); > - > +int cmdq_pkt_write(struct cmdq_pkt *pkt, struct cmdq_base *clt_base, > + dma_addr_t addr, u32 value); > /** > * cmdq_pkt_write_mask() - append write command with mask to the CMDQ packet > * @pkt: the CMDQ packet > - * @subsys: the CMDQ sub system code > - * @offset: register offset from CMDQ sub system > + * @cmdq_base: the CMDQ sub system code and base address > + * @addr: register address > * @value: the specified target register value > * @mask: the specified target register mask > * > * Return: 0 for success; else the error code is returned > */ > -int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys, u16 offset, > - u32 value, u32 mask); > +int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, struct cmdq_base *clt_base, > + dma_addr_t addr, u32 value, u32 mask); > > /** > * cmdq_pkt_wfe() - append wait for event command to the CMDQ packet _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel