Re: [PATCH v6 1/6] irqchip/mtk-sysirq: support 4 interrupt parameters for sysirq

Marc Zyngier
2019-02-07T15:47:30Z

On 07/02/2019 15:20, Matthias Brugger wrote:
>
>
> On 24/01/2019 09:07, Erin Lo wrote:
>> From: Seiya Wang <seiya.wang@mediatek.com>
>>
>> To support partitioned PPIs, 4 interrupt parameters should be valid
>> for sysirq.
>>
>> Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
>> Signed-off-by: Erin Lo <erin.lo@mediatek.com>
>> ---
>> drivers/irqchip/irq-mtk-sysirq.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c
>> index 90aaf19..282736a 100644
>> --- a/drivers/irqchip/irq-mtk-sysirq.c
>> +++ b/drivers/irqchip/irq-mtk-sysirq.c
>> @@ -81,7 +81,7 @@ static int mtk_sysirq_domain_translate(struct irq_domain *d,
>> unsigned int *type)
>> {
>> if (is_of_node(fwspec->fwnode)) {
>> - if (fwspec->param_count != 3)
>> + if (fwspec->param_count != 3 && fwspec->param_count != 4)
>
> Where is this 4th parameter used?

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt#n14

Thanks,

M.
--
Jazz is not dead. It just smells funny...