From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7FFCC169C4 for ; Fri, 1 Feb 2019 01:31:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A04D20869 for ; Fri, 1 Feb 2019 01:31:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h4I4xFC4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A04D20869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YtZaE0fc7aecBHPrTyDa3Z8dBsgdnNEBBNVN2Dh9dEI=; b=h4I4xFC4gKtUSa xiWRaCRhQB/UUSXPM1+1BkfMiXChDNaZ3JQ1oIxjdDl8F+xecsxuC56x0eJnW1yBUVc6KGO/wxUgY prZ1M5S/YzGFcTQ/EkF1XrgIFiTm2eRGkIKSgvGc9QvHoQjxy8ndsTJ2Lpzzq9jDVXGdSoOkpMtgI dPg/3oMIrgNuAlgJCkCITHghfO8V2vAo/uwzVcyUoopETM+BbcuROhX1jGdErDIoLUIf6ennmJsm4 Wb4ahkr9SXhi8X0D4KuH7qj2NI4zCpt+GPDrzmiNOzW9IfpX3QhGAKC4M7Ty06ap0Pni7EE7zQIUb S25uzhSdokCqBPf5Evpw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gpNg0-0002FY-5s; Fri, 01 Feb 2019 01:31:28 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gpNfw-0002F9-0R; Fri, 01 Feb 2019 01:31:26 +0000 X-UUID: b116a89d2e034477b6f98e213e05a81d-20190131 X-UUID: b116a89d2e034477b6f98e213e05a81d-20190131 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1222959962; Thu, 31 Jan 2019 17:31:15 -0800 Received: from mtkmbs08n2.mediatek.inc (172.21.101.56) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 31 Jan 2019 17:31:13 -0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 1 Feb 2019 09:31:10 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 1 Feb 2019 09:31:10 +0800 Message-ID: <1548984670.7501.2.camel@mtksdaap41> Subject: Re: [PATCH 06/10] soc: mediatek: add register device function From: CK Hu To: Bibby Hsieh Date: Fri, 1 Feb 2019 09:31:10 +0800 In-Reply-To: <1548747128-60136-7-git-send-email-bibby.hsieh@mediatek.com> References: <1548747128-60136-1-git-send-email-bibby.hsieh@mediatek.com> <1548747128-60136-7-git-send-email-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 5F9CD66F38D58B2368783410EA4ADCE24611ACB8CD381CCC5FEA9C52371936CB2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190131_173124_079550_14C8DDBD X-CRM114-Status: GOOD ( 14.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , Philipp Zabel , srv_heupstream@mediatek.com, kendrick.hsu@mediatek.com, Daoyuan Huang , Sascha Hauer , Jassi Brar , linux-kernel@vger.kernel.org, Daniel Kurtz , Dennis-YC Hsieh , YT Shen , Rob Herring , linux-mediatek@lists.infradead.org, Houlong Wei , Sascha Hauer , Matthias Brugger , Jiaguang Zhang , Frederic Chen , linux-arm-kernel@lists.infradead.org, ginny.chen@mediatek.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Tue, 2019-01-29 at 15:32 +0800, Bibby Hsieh wrote: > GCE cannot know the register base address, we store the subsys-base address > relationship in the device node, and store the relationship by > cmdq_register_device function. > > Signed-off-by: Bibby Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 24 ++++++++++++++++++++++++ > include/linux/soc/mediatek/mtk-cmdq.h | 1 + > 2 files changed, 25 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 6e4b85e..6ad997f 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -32,6 +32,30 @@ u8 cmdq_subsys_base_to_id(struct cmdq_base *clt_base, u32 base) > } > EXPORT_SYMBOL(cmdq_subsys_base_to_id); > > +struct cmdq_base *cmdq_register_device(struct device *dev) > +{ > + struct cmdq_base *clt_base; > + struct of_phandle_args spec; > + u32 idx; > + > + clt_base = devm_kzalloc(dev, sizeof(*clt_base), GFP_KERNEL); > + if (!clt_base) > + return NULL; > + > + /* parse subsys */ > + for (idx = 0; idx < ARRAY_SIZE(clt_base->subsys); idx++) { > + if (of_parse_phandle_with_args(dev->of_node, "gce-subsys", > + "#gce-subsys-cells", idx, &spec)) > + break; > + clt_base->subsys[idx].base = spec.args[0]; > + clt_base->subsys[idx].id = spec.args[1]; This does not match the binding [1]. [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/mailbox/mtk-gce.txt Regards, CK > + } > + clt_base->count = idx; > + > + return clt_base; > +} > +EXPORT_SYMBOL(cmdq_register_device); > + > static void cmdq_client_timeout(struct timer_list *t) > { > struct cmdq_client *client = from_timer(client, t, timer); > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > index 0c7a6ee..a1f5eb6 100644 > --- a/include/linux/soc/mediatek/mtk-cmdq.h > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > @@ -138,5 +138,6 @@ int cmdq_pkt_flush_async(struct cmdq_pkt *pkt, cmdq_async_flush_cb cb, > int cmdq_pkt_flush(struct cmdq_pkt *pkt); > > u8 cmdq_subsys_base_to_id(struct cmdq_base *clt_base, u32 base); > +struct cmdq_base *cmdq_register_device(struct device *dev); > > #endif /* __MTK_CMDQ_H__ */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel