From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D80D2C169C4 for ; Fri, 1 Feb 2019 02:13:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A472B2080D for ; Fri, 1 Feb 2019 02:13:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YBI14QDr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A472B2080D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3jf9aTCnmgbj8UEP2+GCqXt/WmbsSoEmJPirG4sK4Tc=; b=YBI14QDrHk9o1t sG7Tfic/u29/R0w2mz3A9wCUbkSEfEAVVsTnDTD5zRTA7Noget+EUszYx8kRZKTqzkFMBe1c1Kyuu QUP04CMIhhcn7YLNYEg0jtzfe3+xHNdk8bV7as/elin3CVQQSAQ6y3+bh1g3EWhJSvASyz0wKtg7I SdFvncNbzhADfg3Ac1NdU2IsL1i/RltJ3wgYsbjzj2o68eOuf2jSAhMg1QYtwJJYrRZMr1IvJgNSR JEv2+DFqsa0CrswhlQLboDVkZle/z0Loc7eJ1jRdwFrbYnobL1/ztRiocOKd/2TSjGk/pwzd2gsVj 1l1MCAsvgMoL4HSGpZ1Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gpOKz-0006MM-Rg; Fri, 01 Feb 2019 02:13:49 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gpOKw-0006Lh-2C; Fri, 01 Feb 2019 02:13:47 +0000 X-UUID: 284d5739b42a4c32a0f07b31e06ee468-20190131 X-UUID: 284d5739b42a4c32a0f07b31e06ee468-20190131 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 968332245; Thu, 31 Jan 2019 18:13:40 -0800 Received: from mtkmbs03n1.mediatek.inc (172.21.101.181) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 31 Jan 2019 18:13:39 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs03n1.mediatek.inc (172.21.101.181) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 1 Feb 2019 10:13:37 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 1 Feb 2019 10:13:37 +0800 Message-ID: <1548987217.28835.2.camel@mtksdaap41> Subject: Re: [PATCH 5/6] regulator: mt6358: Add support for MT6358 regulator From: Hsin-hsiung Wang To: Mark Brown Date: Fri, 1 Feb 2019 10:13:37 +0800 In-Reply-To: <20190130151825.GA10665@sirena.org.uk> References: <1548839891-20932-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1548839891-20932-6-git-send-email-hsin-hsiung.wang@mediatek.com> <20190130151825.GA10665@sirena.org.uk> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190131_181346_118733_7E596A9D X-CRM114-Status: GOOD ( 12.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, srv_heupstream@mediatek.com, Liam Girdwood , linux-kernel@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Lee Jones , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mark, On Wed, 2019-01-30 at 15:18 +0000, Mark Brown wrote: > On Wed, Jan 30, 2019 at 05:18:10PM +0800, Hsin-Hsiung Wang wrote: > > > +static const struct of_device_id mt6358_of_match[] = { > > + { .compatible = "mediatek,mt6358-regulator", }, > > + { /* sentinel */ }, > > +}; > > +MODULE_DEVICE_TABLE(of, mt6358_of_match); > > There should be no need for a separate compatbile string here - we > aren't describing the hardware any more than we already did with the > parent node for the MFD, we're describing how Linux currently splits the > software that controls the hardware up. Just have the MFD instantiate > the regulator driver when it probes. > > Otherwise this driver looks very good and clean. Thanks for your suggestion. It sounds pretty good and I will modify it in next patch series. > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel