From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB11FC282D8 for ; Fri, 1 Feb 2019 08:27:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A48520869 for ; Fri, 1 Feb 2019 08:27:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oDo4RNhR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A48520869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vX+SUOKFzrXYjx6awg637doDXVn7M8S++OyTrm67zCk=; b=oDo4RNhRQm3uJt raQcG7hNJr4ue8CEDJOS29rSYRFEftmrNyV2UYGm/UajnlaqFus6K9kxorinDGbHFE+xK22/vdbzB 0u86ZwyGj35tah7vS0d7OPeJYJMZ+a+xbjeX1wKLEPi7sqQxnxV/uVKaQq0qQEZoO64pZ6vCVeCQ8 1s37HkgFdAHQPu5Ej6oBYIG/Lqg8Xra+EyiR+SbRI3rDT26UOHHvsZ1/5zGVlN8QWTu0WsPAN9A4R wHssOswWHrdSK93si62xtxR7F0LJ1HlzopNKef8HU3sInXlO1gHSrDjsGmfyf5H2HHXsmckGNBBsf BndqlDa/vAZA5RMgD6pQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gpUAO-0003zS-4t; Fri, 01 Feb 2019 08:27:16 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gpU9r-0003Sf-Ou; Fri, 01 Feb 2019 08:26:45 +0000 X-UUID: 005182c912b5433d89f78f86580d4859-20190201 X-UUID: 005182c912b5433d89f78f86580d4859-20190201 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1629377934; Fri, 01 Feb 2019 00:22:26 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 1 Feb 2019 00:22:25 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 1 Feb 2019 16:22:23 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 1 Feb 2019 16:22:23 +0800 Message-ID: <1549009343.22634.4.camel@mtksdaap41> Subject: Re: [PATCH v3 08/12] clk: mediatek: Add MT8183 clock support From: Weiyi Lu To: Stephen Boyd Date: Fri, 1 Feb 2019 16:22:23 +0800 In-Reply-To: <154482479243.19322.7465842539016312943@swboyd.mtv.corp.google.com> References: <20181210073240.32278-1-weiyi.lu@mediatek.com> <20181210073240.32278-10-weiyi.lu@mediatek.com> <154482479243.19322.7465842539016312943@swboyd.mtv.corp.google.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190201_002643_810414_0824B2C4 X-CRM114-Status: UNSURE ( 9.05 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Nicolas Boichat , srv_heupstream@mediatek.com, James Liao , Stephen Boyd , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Fan Chen , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2018-12-14 at 13:59 -0800, Stephen Boyd wrote: > Quoting Weiyi Lu (2018-12-09 23:32:36) > > + "apll2_ck" > > +}; > > + > > +static const struct mtk_mux top_muxes[] = { > > + /* CLK_CFG_0 */ > > + MUX_GATE_CLR_SET_UPD_FLAGS(CLK_TOP_MUX_AXI, "axi_sel", > > + axi_parents, 0x40, > > + 0x44, 0x48, 0, 2, 7, 0x004, 0, CLK_IS_CRITICAL), > > Please document why CLK_IS_CRITICAL is being used everywhere it's used. > OK, I'll add some more comment at where critical clock data is declared. > > + MUX_GATE_CLR_SET_UPD(CLK_TOP_MUX_MM, "mm_sel", > > + mm_parents, 0x40, > > + 0x44, 0x48, 8, 3, 15, 0x004, 1), > > + MUX_GATE_CLR_SET_UPD(CLK_TOP_MUX_IMG, "img_sel", > > + img_parents, 0x40, > > + 0x44, 0x48, 16, 3, 23, 0x004, 2), > > + MUX_GATE_CLR_SET_UPD(CLK_TOP_MUX_CAM, "cam_sel", > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel