From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD9CCC282D8 for ; Fri, 1 Feb 2019 09:42:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A92C9218A6 for ; Fri, 1 Feb 2019 09:42:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cUocglqq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A92C9218A6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7gVlGMQtp63BRxumU138wNQfBeQUZB1f2lIH77hnY/M=; b=cUocglqqnyoGty IxIXBjomfIsIuJF0NigjHT3BcaCx5NhXvUDSqptb8cj/GGdZB9Wrzf4oTOn3B/aZNt6aDVvZN9Sf+ nzL/mYMSMDihUwy5Awx5DbTMZ6A8HgBaxBNZiPZNC7d5aboel+DLI09lXkag6+E0DIHIZBFploK50 rlxK8mafI2IzFBl0cO9GZEPG5/T354nBOivhL+9SV6ksILaA4VNPa+tjkPWdczyUE3mRGWAa7UTFw j7SP0m8mcQ4g+xtKNF9gifK+hF749DFs0dc2mS+SfPZsfwLgWjw5GpJIlnjidizkVAguF0b6i5Clw 6MIokUVqSZtSe4eNnjww==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gpVLF-00084N-6S; Fri, 01 Feb 2019 09:42:33 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gpVLB-00083X-DV; Fri, 01 Feb 2019 09:42:31 +0000 X-UUID: 5248ed482885468180defba707ff5a1f-20190201 X-UUID: 5248ed482885468180defba707ff5a1f-20190201 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1745753463; Fri, 01 Feb 2019 01:42:24 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 1 Feb 2019 01:42:23 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 1 Feb 2019 17:42:20 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 1 Feb 2019 17:42:19 +0800 Message-ID: <1549014139.12663.26.camel@mhfsdcap03> Subject: Re: [PATCH v5 17/20] memory: mtk-smi: Get rid of need_larbid From: Yong Wu To: Evan Green Date: Fri, 1 Feb 2019 17:42:19 +0800 In-Reply-To: References: <1546314952-15990-1-git-send-email-yong.wu@mediatek.com> <1546314952-15990-18-git-send-email-yong.wu@mediatek.com> <1548904937.19710.39.camel@mhfsdcap03> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190201_014229_456827_7AE011EF X-CRM114-Status: GOOD ( 28.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Nicolas Boichat , Arnd Bergmann , srv_heupstream@mediatek.com, Joerg Roedel , Will Deacon , LKML , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , yingjoe.chen@mediatek.com, Robin Murphy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2019-01-31 at 09:45 -0800, Evan Green wrote: > On Wed, Jan 30, 2019 at 7:22 PM Yong Wu wrote: > > > > On Wed, 2019-01-30 at 11:11 -0800, Evan Green wrote: > > > On Mon, Dec 31, 2018 at 7:59 PM Yong Wu wrote: > > > > > > > > The "mediatek,larb-id" has already been parsed in MTK IOMMU driver. > > > > It's no need to parse it again in SMI driver. Only clean some codes. > > > > This patch is fit for all the current mt2701, mt2712, mt7623, mt8173 > > > > and mt8183. > > > > > > > > After this patch, the "mediatek,larb-id" only be needed for mt2712 > > > > which have 2 M4Us. In the other SoCs, we can get the larb-id from M4U > > > > in which the larbs in the "mediatek,larbs" always are ordered. > > > > > > > > CC: Matthias Brugger > > > > Signed-off-by: Yong Wu > > > > --- > > > > drivers/memory/mtk-smi.c | 26 ++------------------------ > > > > 1 file changed, 2 insertions(+), 24 deletions(-) > > > > > > > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > > > > index 08cf40d..10e6493 100644 > > > > --- a/drivers/memory/mtk-smi.c > > > > +++ b/drivers/memory/mtk-smi.c > > > > @@ -67,7 +67,6 @@ struct mtk_smi_common_plat { > > > > }; > > > > > > > > struct mtk_smi_larb_gen { > > > > - bool need_larbid; > > > > int port_in_larb[MTK_LARB_NR_MAX + 1]; > > > > void (*config_port)(struct device *); > > > > unsigned int larb_direct_to_common_mask; > > > > @@ -153,18 +152,9 @@ void mtk_smi_larb_put(struct device *larbdev) > > > > struct mtk_smi_iommu *smi_iommu = data; > > > > unsigned int i; > > > > > > > > - if (larb->larb_gen->need_larbid) { > > > > - larb->mmu = &smi_iommu->larb_imu[larb->larbid].mmu; > > > > - return 0; > > > > - } > > > > - > > > > - /* > > > > - * If there is no larbid property, Loop to find the corresponding > > > > - * iommu information. > > > > - */ > > > > - for (i = 0; i < smi_iommu->larb_nr; i++) { > > > > + for (i = 0; i < MTK_LARB_NR_MAX; i++) { > > > > > > Looks like this was the only use of mtk_smi_iommu.larb_nr. Should we > > > remove that now? > > > > This is necessary since the mt2712 which has two M4U HW. > > > > From its dtsi[1], take iommu1 as a example, its larb_nr only is 3, but > > we need scan all the larb. > > > > [1] > > http://lists.infradead.org/pipermail/linux-mediatek/2018-December/016119.html > > I'm not sure I follow. My point was that this structure member is only > ever set but never read: > $ git grep '[.>]larb_nr' > drivers/iommu/mtk_iommu.c: data->smi_imu.larb_nr = larb_nr; > drivers/iommu/mtk_iommu_v1.c: data->smi_imu.larb_nr = larb_nr; > > Maybe I've applied the patches to the wrong tree, and there is a use > of this member I'm not seeing? Thanks. I misunderstood. It looks right, this variable can be deleted I didn't realize this. Maybe I need use a new patch for this. > -Evan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel