From: Lucas Stach <l.stach@pengutronix.de>
To: Trent Piepho <tpiepho@impinj.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Cc: Richard Zhu <hongxing.zhu@nxp.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/3] ARM: dts: imx7d: Add node for PCIe PHY
Date: Tue, 05 Feb 2019 10:47:03 +0100 [thread overview]
Message-ID: <1549360023.2544.35.camel@pengutronix.de> (raw)
In-Reply-To: <20190205001721.18639-3-tpiepho@impinj.com>
Am Dienstag, den 05.02.2019, 00:17 +0000 schrieb Trent Piepho:
> This adds the PHY as a new node. The PCI-e controller node gains a
> phandle property that points to it.
>
> There isn't yet any code in the kernel that uses this device's
> registers, but it will be added for a PCIe PLL erratum workaround.
>
> Signed-off-by: Trent Piepho <tpiepho@impinj.com>
Looks good, but needs an Ack on the binding change. Also this should go
through Shawns tree, so needs to be split out from the series.
Regards,
Lucas
> ---
> arch/arm/boot/dts/imx7d.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 6b298e388f4b..6eb98e7c568d 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -96,6 +96,14 @@
> > };
> };
>
> +&aips2 {
> + pcie_phy: pcie-phy@306d0000 {
> + compatible = "fsl,imx7d-pcie-phy";
> + reg = <0x306d0000 0x10000>;
> + status = "disabled";
> + };
> +};
> +
> &aips3 {
> usbotg2: usb@30b20000 {
> compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
> @@ -173,6 +181,7 @@
> <&src IMX7_RESET_PCIE_CTRL_APPS_EN>,
> <&src IMX7_RESET_PCIE_CTRL_APPS_TURNOFF>;
> reset-names = "pciephy", "apps", "turnoff";
> + fsl,imx7d-pcie-phy = <&pcie_phy>;
> status = "disabled";
> };
> };
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-05 9:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 0:17 [PATCH v2 0/3] Workaround for IMX7d PCI-e PLL lock failure Trent Piepho
2019-02-05 0:17 ` [PATCH v2 1/3] dt-bindings: imx6q-pcie: Add description of imx7d pcie phy Trent Piepho
2019-02-05 9:43 ` Lucas Stach
2019-02-05 0:17 ` [PATCH v2 2/3] ARM: dts: imx7d: Add node for PCIe PHY Trent Piepho
2019-02-05 9:47 ` Lucas Stach [this message]
2019-02-05 0:17 ` [PATCH v2 3/3] PCI: imx: Add workaround for e10728, IMX7d PCIe PLL failure Trent Piepho
2019-02-05 9:48 ` Lucas Stach
2019-02-07 12:31 ` Lorenzo Pieralisi
2019-02-07 18:15 ` Trent Piepho
2019-02-08 10:18 ` Lorenzo Pieralisi
2019-02-08 18:19 ` Trent Piepho
2019-02-11 12:18 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549360023.2544.35.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=hongxing.zhu@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=shawnguo@kernel.org \
--cc=tpiepho@impinj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).