From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD7EFC282C2 for ; Thu, 7 Feb 2019 10:41:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D37B218FE for ; Thu, 7 Feb 2019 10:41:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ffrpP5An" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D37B218FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CzjZ0edqhDw4zNv2x7Er+rSon+NZC5lbPjfRnlmfyxA=; b=ffrpP5AngkFOVQ gkHbrp9S5JNijeWgEAyXyMOt8HI5taHKR0pZR+6vrBipnnQEigZsrF7+TFD0jHNSgk9//L7I25QBV 0JbvBEGq9iojh3YagGZTq4XFNMTHhu6hEypLITsEOb7ZYOBzdbLfyP1sSwQDkGUJxY9rzwMhNiQLN n7eNlCKc64wDJvCAOlxL9gwHZj4wLFL9/o2bn5K/tZz687u7KbjKjUvOIYsQn52jJscJxM0cApi9i JoE4o2k/7Lvtf/ouBTz+Qd8fDioPDP31+WSsLLhDFDZj8W2PmYwQd+sJTii4gZasMBksS4m9skqCN XEcnvau90ijsmJCDC+3Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1grh7n-0000T0-0u; Thu, 07 Feb 2019 10:41:43 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1grh7k-0000Sd-IL for linux-arm-kernel@lists.infradead.org; Thu, 07 Feb 2019 10:41:41 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1grh7g-00089V-6p; Thu, 07 Feb 2019 11:41:36 +0100 Message-ID: <1549536094.4557.8.camel@pengutronix.de> Subject: Re: [PATCH 1/3] dt-bindings: reset: Add HI3670 reset controller binding From: Philipp Zabel To: Manivannan Sadhasivam , xuwei5@hisilicon.com, robh+dt@kernel.org Date: Thu, 07 Feb 2019 11:41:34 +0100 In-Reply-To: <20190201153841.21903-2-manivannan.sadhasivam@linaro.org> References: <20190201153841.21903-1-manivannan.sadhasivam@linaro.org> <20190201153841.21903-2-manivannan.sadhasivam@linaro.org> X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190207_024140_764626_1CD6DB1E X-CRM114-Status: GOOD ( 16.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, guodong.xu@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Manivannan, On Fri, 2019-02-01 at 21:08 +0530, Manivannan Sadhasivam wrote: > HI3670 SoC is architecturally same as the HI3660 SoC. Hence, the same > driver is reused for HI3670 SoC and the binding is documented here. > > Signed-off-by: Manivannan Sadhasivam > --- > .../devicetree/bindings/reset/hisilicon,hi3660-reset.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt > index 2bf3344b2a02..5d60ec541331 100644 > --- a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt > +++ b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt > @@ -5,11 +5,12 @@ Please also refer to reset.txt in this directory for common reset > controller binding usage. > > The reset controller registers are part of the system-ctl block on > -hi3660 SoC. > +hi3660 and hi3670 SoCs. > > Required properties: > -- compatible: should be > +- compatible: should be one of the following: > "hisilicon,hi3660-reset" > + "hisilicon,hi3670-reset" If the HI3670 reset controller is compatible to the HI3660 reset controller, this could be: - compatible: should be one of the following: "hisilicon,hi3660-reset" for HI3660 "hisilicon,hi3670-reset", "hisilicon,hi3660-reset" for HI3670 That way there would be no need to change the driver and it would be documented that the two reset controllers are compatible. regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel