Re: [PATCH 2/3] dt-bindings: devfreq: add compatible for mt8183 cci devfreq - andrew-sh.cheng

From: andrew-sh.cheng <andrew-sh.cheng@mediatek.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
	linux-pm@vger.kernel.org, Viresh Kumar <viresh.kumar@linaro.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	fan.chen@mediatek.com, Kyungmin Park <kyungmin.park@samsung.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] dt-bindings: devfreq: add compatible for mt8183 cci devfreq
Date: Sat, 16 Feb 2019 08:09:50 +0800	[thread overview]
Message-ID: <1550275790.23797.2.camel@mtksdaap41> (raw)
In-Reply-To: <803eacf2-a3c7-a4d0-682a-837b7367bf2f@samsung.com>

On Tue, 2019-02-12 at 10:00 +0900, Chanwoo Choi wrote:
> Hi Andrew-sh.Cheng,
> 
> On 19. 1. 29. 오후 3:35, Andrew-sh Cheng wrote:
> > From: "Andrew-sh.Cheng" <andrew-sh.cheng@mediatek.com>
> > 
> > This adds dt-binding documentation of cci devfreq
> > for Mediatek MT8183 SoC platform.
> > 
> > Signed-off-by: Andrew-sh.Cheng <andrew-sh.cheng@mediatek.com>
> > ---
> >  .../bindings/devfreq/mt8183-cci-devfreq.txt           | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt b/Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt
> > new file mode 100644
> > index 0000000..e2b61cf
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt
> > @@ -0,0 +1,19 @@
> > +* Mediatek CCI frequency device
> 
> You have to add more detailed what to do on this driver.
> Also, please add the full alphabet for CCI.
I will modify in next patch.
> 
> > +
> > +Required properties:
> > +- compatible: should contain "mediatek,mt8183-cci" for cci devfreq
> 
> Usually, dt-binding document only specifies h/w information
> and how to bind device. 'devfreq' is the word of linux-side.
> It means that 'devfreq' cannot indicate the any h/w device.
> 
> You should use the h/w device information and word of CCI for writing
> the dt-binding document without linux-side word like devfreq.
> 
> For example, 
> - cci devfreq -> frequency scaling of CCI
Thank you for advice.
I will modify in next patch.
> 
> > +
> 
> Remove unneeded blank line.
I will modify in next patch.
> 
> > +- clocks: for cci devfreq
> 
> ditto of 'devfreq' word.
I will modify in next patch.
> 
> > +
> 
> ditto of blank line
I will modify in next patch.
> 
> > +- clock-names: for cci devfreq driver to reference
> 
> ditto of 'devfreq' word.
I will modify in next patch.
> 
> > +
> 
> ditto of blank line
I will modify in next patch.
> 
> > +- operating-points-v2: for cci devfreq opp table
> 
> ditto of 'devfreq' word.
I will modify in next patch.
> 
> > +
> > +Example:
> > +	cci: cci {
> > +		compatible = "mediatek,cci";
> > +		clocks = <&apmixedsys CLK_APMIXED_CCIPLL>;
> > +		clock-names = "cci_clock";
> > +		operating-points-v2 = <&cci_opp>;
> > +	};
> > +
> > 
> 
> This document is missing the 'regulator' property. Please add it
I will add it in next patch
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel