From: Stephen Boyd <sboyd@kernel.org>
To: Katsuhiro Suzuki <katsuhiro@katsuster.net>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org
Cc: Katsuhiro Suzuki <katsuhiro@katsuster.net>,
Heiko Stuebner <heiko@sntech.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] clk: fractional-divider: check parent rate only if flag is set
Date: Fri, 22 Feb 2019 00:13:18 -0800 [thread overview]
Message-ID: <155082319829.77512.7935951458664373330@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20190210153806.24201-1-katsuhiro@katsuster.net>
Quoting Katsuhiro Suzuki (2019-02-10 07:38:06)
> Custom approximation of fractional-divider may not need parent clock
> rate checking. For example Rockchip SoCs work fine using grand parent
> clock rate even if target rate is greater than parent.
>
> This patch checks parent clock rate only if CLK_SET_RATE_PARENT flag
> is set.
>
> For detailed example, clock tree of Rockchip I2S audio hardware.
> - Clock rate of CPLL is 1.2GHz, GPLL is 491.52MHz.
> - i2s1_div is integer divider can divide N (N is 1~128).
> Input clock is CPLL or GPLL. Initial divider value is N = 1.
> Ex) PLL = CPLL, N = 10, i2s1_div output rate is
> CPLL / 10 = 1.2GHz / 10 = 120MHz
> - i2s1_frac is fractional divider can divide input to x/y, x and
> y are 16bit integer.
>
> CPLL --> | selector | ---> i2s1_div -+--> | selector | --> I2S1 MCLK
Applied to clk-next but I made the function into a macro because I don't
see the benefit to exporting such a simple thing.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-02-22 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 15:38 [PATCH v2] clk: fractional-divider: check parent rate only if flag is set Katsuhiro Suzuki
2019-02-10 15:50 ` Heiko Stuebner
2019-02-21 2:55 ` Katsuhiro Suzuki
2019-02-22 8:13 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155082319829.77512.7935951458664373330@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=heiko@sntech.de \
--cc=katsuhiro@katsuster.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox