From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 120C7C43381 for ; Sat, 23 Feb 2019 10:42:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF9C120854 for ; Sat, 23 Feb 2019 10:42:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JgQx5ask"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="RMDcgZSb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF9C120854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:From:To: Subject:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=IgpLzk4hjlczstfpbxQNZcrvGedSBm2JvqC0sSnzKV8=; b=JgQx5askjfXLbH TyRwy3fwdz3upaZBgRJKKxC5iJWTfPF6dncBM/VtEiUJfuSm0EDx0kLzEN71K3a+z9oQ+CZufmilL fkP0JtamwG5Z16YJuKr7H6Y6iQtakZXelsT20RO5jkfZUoi99m1Iz3hTpqZUmhvnthW9S9Xusw/A7 jPFMTnqFEM9WWW7sW8wYTzEog0wX7yRCe8d9DJwGIOLBbkBpytBq2mCnKD379vm4YWquxr/IiCVRL hYOXV0nQ+OnSjYEn9sUCT8Sf6UXtSoQIZkoT7hWTg58UXSgSlZ4sG6H9eoiQYz1UgXfNIHYsWy3WD s2NZh+nrIaTaQUq0QvtA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gxUl3-0003Wa-CZ; Sat, 23 Feb 2019 10:42:13 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gxUky-0003UL-Rj for linux-arm-kernel@lists.infradead.org; Sat, 23 Feb 2019 10:42:11 +0000 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 163D2206B6; Sat, 23 Feb 2019 10:42:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550918528; bh=DX5QPasWaG47AftUlVeJnEIdq5wwFlD/sXtIQJXkErY=; h=Subject:To:Cc:From:Date:From; b=RMDcgZSbkXcGVf6zGig4oy4Cn8VVjN013dMsjCM2/UjrhFxsqux3LvV1yzASeao6x XsQ65DmCD5dGdaA4KqkDQxGiqmFY0zEcXPEkWXXpehKajtu0bPlLz8xWm/1ivFK5ZB +IfahLTRS1m+Bs3g9PltU5yC77BF14/0zXYcD6/8= Subject: Patch "ARM: 8834/1: Fix: kprobes: optimized kprobes illegal instruction" has been added to the 4.20-stable tree To: 342740659.2887.1549307721609.JavaMail.zimbra@efficios.com, Robert.Berger@ReliableEmbeddedSystems.com, gregkh@linuxfoundation.org, keescook@chromium.org, labbott@redhat.com, linux-arm-kernel@lists.infradead.org, mathieu.desnoyers@efficios.com, mhiramat@kernel.org, patches@armlinux.org.uk, rmk+kernel@armlinux.org.uk, wcohen@redhat.com From: Date: Sat, 23 Feb 2019 11:42:05 +0100 Message-ID: <1550918525127206@kroah.com> MIME-Version: 1.0 X-stable: commit X-Patchwork-Hint: ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190223_024208_938331_1E632E12 X-CRM114-Status: GOOD ( 11.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable-commits@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is a note to let you know that I've just added the patch titled ARM: 8834/1: Fix: kprobes: optimized kprobes illegal instruction to the 4.20-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: arm-8834-1-fix-kprobes-optimized-kprobes-illegal-instruction.patch and it can be found in the queue-4.20 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From 0ac569bf6a7983c0c5747d6df8db9dc05bc92b6c Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Tue, 5 Feb 2019 16:37:40 +0100 Subject: ARM: 8834/1: Fix: kprobes: optimized kprobes illegal instruction From: Mathieu Desnoyers commit 0ac569bf6a7983c0c5747d6df8db9dc05bc92b6c upstream. commit e46daee53bb5 ("ARM: 8806/1: kprobes: Fix false positive with FORTIFY_SOURCE") introduced a regression in optimized kprobes. It triggers "invalid instruction" oopses when using kprobes instrumentation through lttng and perf. This commit was introduced in kernel v4.20, and has been backported to stable kernels 4.19 and 4.14. This crash was also reported by Hongzhi Song on the redhat bugzilla where the patch was originally introduced. Link: https://bugzilla.redhat.com/show_bug.cgi?id=1639397 Link: https://bugs.lttng.org/issues/1174 Link: https://lore.kernel.org/lkml/342740659.2887.1549307721609.JavaMail.zimbra@efficios.com Fixes: e46daee53bb5 ("ARM: 8806/1: kprobes: Fix false positive with FORTIFY_SOURCE") Signed-off-by: Mathieu Desnoyers Reported-by: Robert Berger Tested-by: Robert Berger Acked-by: Kees Cook Cc: Robert Berger Cc: Masami Hiramatsu Cc: William Cohen Cc: Laura Abbott Cc: Kees Cook Cc: # v4.14+ Cc: linux-arm-kernel@lists.infradead.org Cc: patches@armlinux.org.uk Signed-off-by: Russell King Signed-off-by: Greg Kroah-Hartman --- arch/arm/probes/kprobes/opt-arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/arm/probes/kprobes/opt-arm.c +++ b/arch/arm/probes/kprobes/opt-arm.c @@ -247,7 +247,7 @@ int arch_prepare_optimized_kprobe(struct } /* Copy arch-dep-instance from template. */ - memcpy(code, (unsigned char *)optprobe_template_entry, + memcpy(code, (unsigned long *)&optprobe_template_entry, TMPL_END_IDX * sizeof(kprobe_opcode_t)); /* Adjust buffer according to instruction. */ Patches currently in stable-queue which might be from mathieu.desnoyers@efficios.com are queue-4.20/arm-8834-1-fix-kprobes-optimized-kprobes-illegal-instruction.patch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel