From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D42BCC43381 for ; Tue, 5 Mar 2019 01:19:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3CE0206DD for ; Tue, 5 Mar 2019 01:19:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BxFN5oB0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3CE0206DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jS0Vvk04qbBfLZgeTTTxgxP/pPvn3mo2dR7Z0JD5vVk=; b=BxFN5oB080umCO pIUQhJ0HMiarXm8peeXqbJlJONMqvqsDnWauk+ualJJNmKJFeJXg3otdjASkgqvY04BaXqZxW8G74 pmzETsr+vNefdR3puDNBfdClqCDmGK7X40jlYEscwVDQg8FVe4hGolrPVcJcG8Z2U+Zp8nWUuDCb5 JyqRNKQQ6PTXjHGSvGCV5gw3vAYF+PJY/CPdkTpx/hlOo0ZWfJJz/ure/oWeoZIpwACvtakEbegwa IAkEMB/aHut0UNaWwREsBPTCsaqceODLQlDoLeYcBF6d5tLrB1kvm2VsL8vsA5EkTparAL7j1II6q GPePzVY5/9MS3p+Ss1uw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0ykM-0007A4-R4; Tue, 05 Mar 2019 01:19:54 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0ykJ-00078Y-20; Tue, 05 Mar 2019 01:19:52 +0000 X-UUID: 887949f87c874b45851e89d8584305fb-20190304 X-UUID: 887949f87c874b45851e89d8584305fb-20190304 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 763449607; Mon, 04 Mar 2019 17:19:36 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 4 Mar 2019 17:19:34 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 5 Mar 2019 09:19:31 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 5 Mar 2019 09:19:31 +0800 Message-ID: <1551748771.12020.36.camel@mhfsdcap03> Subject: Re: [PATCH v5 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller From: Min Guo To: Rob Herring Date: Tue, 5 Mar 2019 09:19:31 +0800 In-Reply-To: References: <1550561795-31132-1-git-send-email-min.guo@mediatek.com> <1550561795-31132-2-git-send-email-min.guo@mediatek.com> <20190222164923.GA26413@bogus> <1551058604.12020.34.camel@mhfsdcap03> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_171951_105164_1AD8103B X-CRM114-Status: GOOD ( 22.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Hans de Goede , Tony Lindgren , Greg Kroah-Hartman , Linux USB List , "linux-kernel@vger.kernel.org" , Matthias Brugger , Alan Stern , Chunfeng Yun , "moderated list:ARM/Mediatek SoC support" , Bin Liu , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On Mon, 2019-03-04 at 11:42 -0600, Rob Herring wrote: > On Sun, Feb 24, 2019 at 7:36 PM Min Guo wrote: > > > > Hi Rob, > > On Fri, 2019-02-22 at 10:49 -0600, Rob Herring wrote: > > > On Tue, Feb 19, 2019 at 03:36:30PM +0800, min.guo@mediatek.com wrote: > > > > From: Min Guo > > > > > > > > This adds support for MediaTek musb controller in > > > > host, peripheral and otg mode. > > > > > > > > Signed-off-by: Min Guo > > > > --- > > > > changes in v5: > > > > suggested by Rob: > > > > 1. Modify compatible as > > > > - compatible : should be one of: > > > > "mediatek,mt-2701" > > > > ... > > > > followed by "mediatek,mtk-musb" > > > > 2. Add usb connector child node > > > > > > > > changes in v4: > > > > suggested by Sergei: > > > > 1. String alignment > > > > > > > > changes in v3: > > > > 1. no changes > > > > > > > > changes in v2: > > > > suggested by Bin: > > > > 1. Modify DRC to DRD > > > > suggested by Rob: > > > > 2. Drop the "-musb" in compatible > > > > 3. Remove phy-names > > > > 4. Add space after comma in clock-names > > > > --- > > > > .../devicetree/bindings/usb/mediatek,musb.txt | 54 ++++++++++++++++++++++ > > > > 1 file changed, 54 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > new file mode 100644 > > > > index 0000000..0632e6e > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt > > > > @@ -0,0 +1,54 @@ > > > > +MediaTek musb DRD/OTG controller > > > > +------------------------------------------- > > > > + > > > > +Required properties: > > > > + - compatible : should be one of: > > > > + "mediatek,mt-2701" > > > > > > That looks like a top-level SoC compatible and doesn't match the > > > example. > > "mediatek,mt-2701" is an example, just to describe a specific SOC. > > May I modify compatibel like: > > compatible : should be "mediatek,mtk-musb" > > No, you should fix the example adding "mediatek,mtk-musb". OK. > Rob Regards, Min. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel