From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17182C10F0C for ; Wed, 6 Mar 2019 01:52:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDF502075B for ; Wed, 6 Mar 2019 01:52:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oXZHWsn7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDF502075B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4JDS1lp+rIbvkbCDJojVxa4KfvXC/svlLKvFvCw5gdY=; b=oXZHWsn7wf7wZs AXoeNG0VatFfenlLjK6ETESMj7eV7728aeNc1eipaIS+z1OtSqGwKw/FK1eDKs1v6Sw1KrwDP5iGI XCEGltTWT6tEeWf2I/wWxn8r86rgJA+YgOxKgGiEmd0OzEJi0Ng5Kbsnmzhd3VZ10OT6je6/rH5GF jMuuyf3igPgaJYb7gEmrnbgLVzl91F9/INAYQ2/7bN4VcAmRrECZDZfB2qyyPDe77nZsgmiy2QVhE 3ldVsg1g37n1ECX8dOZMVuq2HJMtJAlnNvS4lO2PvEecHAOej0fvTnudcxYccuu/HqvMIAuqTaZoC cDL8aOYNVCynTAk/nqrw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1LjX-0001xV-9e; Wed, 06 Mar 2019 01:52:35 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1LjS-0001we-J4; Wed, 06 Mar 2019 01:52:32 +0000 X-UUID: ea68005f9d434fb3a91f1a53a586ebc1-20190305 X-UUID: ea68005f9d434fb3a91f1a53a586ebc1-20190305 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 519662216; Tue, 05 Mar 2019 17:52:24 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 5 Mar 2019 17:52:22 -0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 6 Mar 2019 09:52:21 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 6 Mar 2019 09:52:21 +0800 Message-ID: <1551837141.23995.13.camel@mtksdaap41> Subject: Re: [PATCH V6 0/8] make mt7623 clock of hdmi stable From: CK Hu To: wangyan wang Date: Wed, 6 Mar 2019 09:52:21 +0800 In-Reply-To: <20190225020912.29120-1-wangyan.wang@mediatek.com> References: <20190225020912.29120-1-wangyan.wang@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_175230_638116_5AA578E2 X-CRM114-Status: GOOD ( 13.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ryder Lee , Philipp Zabel , srv_heupstream@mediatek.com, chunhui dai , Stephen Boyd , Michael Turquette , Sean Wang , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , Colin Ian King , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2019-02-25 at 10:09 +0800, wangyan wang wrote: > From: Wangyan Wang > > V6 adopt maintainer's suggestion. > Here is the change list between V5 & V6 > 1. change "unsigned char mux_flags;" to "u8 mux_flags;" to > match with the struct in " clk: mediatek: add MUX_GATE_FLAGS_2". > Hi, Wangyan: I'm not familiar with this clock system, so I still have some question about it, if you could describe more clear, it would help us to speed up this review process. In [1], I find the clock that dpi and hdmi_phy controls, dpi0: dpi@14014000 { clocks = <&mmsys CLK_MM_DPI1_DIGL>, <&mmsys CLK_MM_DPI1_ENGINE>, <&topckgen CLK_TOP_TVDPLL>; clock-names = "pixel", "engine", "pll"; }; hdmi_phy: phy@10209100 { clocks = <&apmixedsys CLK_APMIXED_HDMI_REF>; clock-names = "pll_ref"; }; In [2], You say that to prevent changing tvdpll would let hdmi stable, and this clock is controlled by dpi, why do you modify the control flow in hdmi_phy? If these two have relationship, please describe more clear because I'm not familiar with this clock system. And I think that patch 'drm/mediatek: using new factor for tvdpll in MT2701' is the major patch to prevent modifying tvdpll because it reduce the factor case. Does MT8173 has the same problem? Just ask, I does not require you to modify MT8173 part. [1] https://github.com/frank-w/BPI-R2-4.14/blob/663f7def421952eb49b2d698eadaff12d02622d2/arch/arm/boot/dts/mt7623.dtsi [2] http://lists.infradead.org/pipermail/linux-mediatek/2019-February/017693.html Regards, CK > > chunhui dai (8): > drm/mediatek: recalculate hdmi phy clock of MT2701 by querying > hardware > drm/mediatek: move the setting of fixed divider > drm/mediatek: using different flags of clk for HDMI phy > drm/mediatek: fix the rate and divder of hdmi phy for MT2701 > clk: mediatek: add MUX_GATE_FLAGS_2 > clk: mediatek: using CLK_MUX_ROUND_CLOSEST for the clock of dpi1_sel > drm/mediatek: using new factor for tvdpll in MT2701 > drm/mediatek: fix the rate of parent for hdmi phy in MT2701 > > drivers/clk/mediatek/clk-mt2701.c | 4 +- > drivers/clk/mediatek/clk-mtk.c | 2 +- > drivers/clk/mediatek/clk-mtk.h | 20 ++++++--- > drivers/gpu/drm/mediatek/mtk_dpi.c | 8 ++-- > drivers/gpu/drm/mediatek/mtk_hdmi_phy.c | 34 ++++------------ > drivers/gpu/drm/mediatek/mtk_hdmi_phy.h | 7 +--- > drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c | 56 +++++++++++++++++++++++--- > drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c | 23 +++++++++++ > 8 files changed, 102 insertions(+), 52 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel