From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAD_ENC_HEADER,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40687C43381 for ; Wed, 6 Mar 2019 13:26:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 100E620661 for ; Wed, 6 Mar 2019 13:26:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UqDxsoIK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="NQ5uSdAy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 100E620661 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ST4ZEytLnd4PeJudZqAALNn5vDKM43Ok43SJ562QMSA=; b=UqDxsoIKhLYNbk xy5Ln/WaIcEOPs1335TaqubTfsLIQPm0ti0PRcRC5MO4/xd7zlrtJpeVIPWMgVy0HPmndH0EMfTmz QOzYBJGl4j/1wlc8RGhWCkgro5Un3MkeSjz/886zSeh5dE9kddk6sX0Igbx0/PevC2skvYBoRFPZR bGyi+xV0r/zpAtmjPx4xnepbgnryhH/Qk3HJry5CphptmhUQMDk4FK/+E5QwHZvLlzEat4u0s2Q5V a8Zokmnv9qtThnrUPWEmzrl33jwvlqC8t7wPFBvBz5x9XNrzF1de4z14MJaFAx1theJN9E/1vQ2Z7 HSnqkiwDnFeYBzhw4BOQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1WYi-0006Gn-WD; Wed, 06 Mar 2019 13:26:09 +0000 Received: from mail-am5eur02on0609.outbound.protection.outlook.com ([2a01:111:f400:fe07::609] helo=EUR02-AM5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1WY5-0004wD-CG for linux-arm-kernel@lists.infradead.org; Wed, 06 Mar 2019 13:25:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y/xuxisU4vv5vRzHAShWyRDcg2nis3Q//bBEKXXRVb8=; b=NQ5uSdAyfI+7Lfyup71zjfiNBIO39uQQYrVJuNkHXApZjeBJaG0D7QENj8/aYVQGNxTY23LgFg4Dikp2JsARZEf6eA/GtQWDqsAR52UZeb22a96g1Ql9cBeOMUXYjejeXwMEGI3uGZEqu6IQcPKr+HPsCNHyj6yQ1IpN+nJp+0E= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.92.158) by AM0PR04MB5345.eurprd04.prod.outlook.com (20.178.112.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Wed, 6 Mar 2019 13:25:22 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79%2]) with mapi id 15.20.1686.016; Wed, 6 Mar 2019 13:25:22 +0000 From: Aisheng Dong To: "linux-pm@vger.kernel.org" Subject: [PATCH 4/6] PM / Domains: Move the Subdomain check into _genpd_power_off Thread-Topic: [PATCH 4/6] PM / Domains: Move the Subdomain check into _genpd_power_off Thread-Index: AQHU1CAMzk547olF3kOGQCSlDNQFUQ== Date: Wed, 6 Mar 2019 13:25:22 +0000 Message-ID: <1551878302-8146-5-git-send-email-aisheng.dong@nxp.com> References: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0P153CA0009.APCP153.PROD.OUTLOOK.COM (2603:1096:203:18::21) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:5b::30) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 519f0d6d-6b6b-43fc-d089-08d6a2372f4c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR04MB5345; x-ms-traffictypediagnostic: AM0PR04MB5345: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; AM0PR04MB5345; 23:eJYEuWzAw+JqpTJUy8mwdNPHY70+Yoo8pbSz0hh?= =?iso-8859-1?Q?8nbTgpwW66Om/YEgdVaQibJEW6NE8HkX8VtApURqFhTbzr+rW/ceXQsU9O?= =?iso-8859-1?Q?ejS6RB2IyIh4EjTGSPufRdBfk8I8sFdxd6NN9ctMzhTT0+9eUic5nC+/qH?= =?iso-8859-1?Q?ZlungL70gQAWVB9V6RiOTRYRV3NDP8pKcTUILZ6W42nO5aZAUK0E6r2efr?= =?iso-8859-1?Q?JFhy7QjXN+kgWOko+1h15Ijp0/iOjJhOf8eh4DnmACksntmG/D7Ah7hXTI?= =?iso-8859-1?Q?TuDJprqs8cHmf3ohjH6QOIMV7lyyh92S65uFs/l+5NJ2guyFhz1/NVXnOn?= =?iso-8859-1?Q?uNi+EsJmYHNSnJnLTJJSXZdoTDTEnTMx7wpJdp64hIIAeCdQCaF6JhwZ4U?= =?iso-8859-1?Q?iC0lxd7oXiv/5wK7De8iszwutFSXZU21zRqNlqL4diPtYtmqhGzzaKAxgG?= =?iso-8859-1?Q?s7EUEWeB8MfRMYspeU76+czkDexb0mtPViNyX1BU61IPd7iGN9G1r7GjVH?= =?iso-8859-1?Q?+Nh9QGlwpFatHDDkztpK5UvLs8pEcU7A4cR3PA2t/X9OJyZIwdi26l7+pV?= =?iso-8859-1?Q?NiFnoJkYuQoDCp5CHd9GOyePR2Mf8nJLf8zdHK1CippdV9NtwyHnQf6a9b?= =?iso-8859-1?Q?K+X/mVWo9m6pIxg6C+2FRav18d8hzYgba2IUyzVwqExJj9obj5hzCLowjq?= =?iso-8859-1?Q?taABcHXWc0w9yx1g7queDfVJ3UZMxuOqZxRb+CDAIAIQ48ARUn9oVM4pRs?= =?iso-8859-1?Q?RoeQuvjKwdchcwBLAMD1zn4wdG5u/75deXm1yFCmY+B/SH/WD10aESD1P/?= =?iso-8859-1?Q?3T/DLT/gkWvv4nREmVR26M9sENOEBLjaTD+CJONGCGWbQT64HZmqkG97N9?= =?iso-8859-1?Q?fIK/Uwzy2vU5XKpZmueTJTtMebPWCaVP4F+J/wQu+esPGMxNAgNUge7UqQ?= =?iso-8859-1?Q?UIWPKeatCq2Ts7cGpaydnwCp8DJWdMOFdS43SsBDDUsy/sRJORbNBfAKTp?= =?iso-8859-1?Q?z85E18fCcRdM0k5ls6XINsVVj8V3I41+MeP4p2n2YveZ+l+6cFjvZHIjzC?= =?iso-8859-1?Q?5cerj/v3omBm4pMt5ixehEHSH8aC0NMeIMp1pdNcZVCtgFxrdEDyXHlDeG?= =?iso-8859-1?Q?efO6QJ14onnSuAGX74xg+NFiXoblKdoNNnmOHrRZ/gXzYV4fbBzpz2lNaY?= =?iso-8859-1?Q?WDtTk9XGfHycfmzsifz1nVBL4B1rtYfFTp619/rvkPRxmNTbgJoXG+8xPA?= =?iso-8859-1?Q?BVOp7BWdf6NXevC0lTUxpuXkZzpFWHlNvKrp/6nwyE+j0S9s5vyJG+ibWM?= =?iso-8859-1?Q?QxUS9BUExjzdLYCryeQCpv/JKQmKXFlXYPiJz+KGBtv/A=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(376002)(346002)(199004)(189003)(316002)(4326008)(44832011)(386003)(446003)(486006)(2906002)(2616005)(54906003)(476003)(11346002)(6506007)(68736007)(36756003)(52116002)(186003)(105586002)(2351001)(14454004)(86362001)(26005)(5660300002)(106356001)(50226002)(71200400001)(71190400001)(25786009)(102836004)(8936002)(305945005)(478600001)(6916009)(6436002)(7736002)(99286004)(8676002)(66066001)(5640700003)(76176011)(256004)(14444005)(6486002)(81156014)(97736004)(3846002)(6116002)(53936002)(2501003)(81166006)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB5345; H:AM0PR04MB4211.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: aO51EvjtVxFXkrDz1AY3lDXVIN2+ICX4lp1yaQQkcpd6fXWgB/NV0Cjy8PaHhqd/5oHeorzIALG7pXCdh6BxdQBiJze0WRCWbKnszuNwWwYHGbX/ERBklWlTKBI/nuHiOLvdvDC/GVdpVvQjA8inzSwzXeRZeFEHae58qmcWrUljPlN5dEs+BwZpQZrVsddeVC1M8FZR5xG4kxy9bKFa73NYvsT+/rnukRzEJTcKgYuAMTGDCDXFGvYpMse8LQHibOG+FtsrepHsUh52TAWhIgWutFBwT7rUXbWaZd9bDslntnvKQVHS5i0mAu3DU32EzmOa6alRA1jgqPW8tlycQ1kc10ON+Kxb1ZPBuJgoGvooAqyEppYnp2dy9MFBhR2vbjfLw6aJFv/l78+jOTMj8Y024ikEXEpDpEfnJlTG7+k= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 519f0d6d-6b6b-43fc-d089-08d6a2372f4c X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2019 13:25:22.2630 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5345 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190306_052529_990676_D77C0CEE X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , "ulf.hansson@linaro.org" , "dongas86@gmail.com" , "khilman@kernel.org" , "rjw@rjwysocki.net" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Move the Subdomain check into _genpd_power_off, then the caller does not have to check it each time. This also ensures a double check of &genpd->sd_count before really power off domain in case it's increased asynchronously by subdomains. This is the same behavior as the original genpd_power_off() does. Signed-off-by: Dong Aisheng --- drivers/base/power/domain.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 591f37f..61cd500 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -452,6 +452,9 @@ static int _genpd_power_off(struct generic_pm_domain *genpd, bool timed) if (!genpd->power_off) return 0; + if (atomic_read(&genpd->sd_count) > 0) + return -EBUSY; + if (!timed) return genpd->power_off(genpd); @@ -547,9 +550,6 @@ static int genpd_power_off(struct generic_pm_domain *genpd, bool one_dev_on, if (!genpd->gov) genpd->state_idx = 0; - if (atomic_read(&genpd->sd_count) > 0) - return -EBUSY; - /* * If sd_count > 0 at this point, one of the subdomains hasn't * managed to call genpd_power_on() for the master yet after @@ -962,8 +962,7 @@ static void genpd_sync_power_off(struct generic_pm_domain *genpd, bool use_lock, if (!genpd_status_on(genpd) || genpd_is_always_on(genpd)) return; - if (genpd->suspended_count != genpd->device_count - || atomic_read(&genpd->sd_count) > 0) + if (genpd->suspended_count != genpd->device_count) return; /* Choose the deepest state when suspending */ -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel