* [PATCH] i2c: i2c-stm32f7: Fix SDADEL minimum formula
@ 2019-03-06 15:12 Bich HEMON
2019-03-07 8:29 ` Pierre Yves MORDRET
2019-03-09 10:13 ` Wolfram Sang
0 siblings, 2 replies; 6+ messages in thread
From: Bich HEMON @ 2019-03-06 15:12 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Maxime Coquelin, Alexandre TORGUE,
Pierre Yves MORDRET, Wolfram Sang, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Bich HEMON
From: Nicolas Le Bayon <nicolas.le.bayon@st.com>
It conforms with Reference Manual I2C timing section.
Signed-off-by: Nicolas Le Bayon <nicolas.le.bayon@st.com>
Signed-off-by: Bich Hemon <bich.hemon@st.com>
---
drivers/i2c/busses/i2c-stm32f7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index 13e1213..4284fc9 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -432,7 +432,7 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev,
STM32F7_I2C_ANALOG_FILTER_DELAY_MAX : 0);
dnf_delay = setup->dnf * i2cclk;
- sdadel_min = setup->fall_time - i2c_specs[setup->speed].hddat_min -
+ sdadel_min = i2c_specs[setup->speed].hddat_min + setup->fall_time -
af_delay_min - (setup->dnf + 3) * i2cclk;
sdadel_max = i2c_specs[setup->speed].vddat_max - setup->rise_time -
--
1.9.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: i2c-stm32f7: Fix SDADEL minimum formula
2019-03-06 15:12 [PATCH] i2c: i2c-stm32f7: Fix SDADEL minimum formula Bich HEMON
@ 2019-03-07 8:29 ` Pierre Yves MORDRET
2019-03-09 10:13 ` Wolfram Sang
1 sibling, 0 replies; 6+ messages in thread
From: Pierre Yves MORDRET @ 2019-03-07 8:29 UTC (permalink / raw)
To: Bich HEMON, Rob Herring, Mark Rutland, Maxime Coquelin,
Alexandre TORGUE, Wolfram Sang, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Hi
Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Thanks
On 3/6/19 4:12 PM, Bich HEMON wrote:
> From: Nicolas Le Bayon <nicolas.le.bayon@st.com>
>
> It conforms with Reference Manual I2C timing section.
>
> Signed-off-by: Nicolas Le Bayon <nicolas.le.bayon@st.com>
> Signed-off-by: Bich Hemon <bich.hemon@st.com>
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index 13e1213..4284fc9 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -432,7 +432,7 @@ static int stm32f7_i2c_compute_timing(struct stm32f7_i2c_dev *i2c_dev,
> STM32F7_I2C_ANALOG_FILTER_DELAY_MAX : 0);
> dnf_delay = setup->dnf * i2cclk;
>
> - sdadel_min = setup->fall_time - i2c_specs[setup->speed].hddat_min -
> + sdadel_min = i2c_specs[setup->speed].hddat_min + setup->fall_time -
> af_delay_min - (setup->dnf + 3) * i2cclk;
>
> sdadel_max = i2c_specs[setup->speed].vddat_max - setup->rise_time -
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: i2c-stm32f7: Fix SDADEL minimum formula
2019-03-06 15:12 [PATCH] i2c: i2c-stm32f7: Fix SDADEL minimum formula Bich HEMON
2019-03-07 8:29 ` Pierre Yves MORDRET
@ 2019-03-09 10:13 ` Wolfram Sang
2019-03-09 10:50 ` Wolfram Sang
1 sibling, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2019-03-09 10:13 UTC (permalink / raw)
To: Bich HEMON
Cc: Mark Rutland, devicetree@vger.kernel.org, Alexandre TORGUE,
linux-kernel@vger.kernel.org, Pierre Yves MORDRET, Rob Herring,
linux-i2c@vger.kernel.org, Maxime Coquelin,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
[-- Attachment #1.1: Type: text/plain, Size: 325 bytes --]
On Wed, Mar 06, 2019 at 03:12:16PM +0000, Bich HEMON wrote:
> From: Nicolas Le Bayon <nicolas.le.bayon@st.com>
>
> It conforms with Reference Manual I2C timing section.
>
> Signed-off-by: Nicolas Le Bayon <nicolas.le.bayon@st.com>
> Signed-off-by: Bich Hemon <bich.hemon@st.com>
Applied to for-current, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: i2c-stm32f7: Fix SDADEL minimum formula
2019-03-09 10:13 ` Wolfram Sang
@ 2019-03-09 10:50 ` Wolfram Sang
2019-03-11 9:34 ` Bich HEMON
0 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2019-03-09 10:50 UTC (permalink / raw)
To: Bich HEMON
Cc: Mark Rutland, devicetree@vger.kernel.org, Alexandre TORGUE,
linux-kernel@vger.kernel.org, Pierre Yves MORDRET, Rob Herring,
linux-i2c@vger.kernel.org, Maxime Coquelin,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
[-- Attachment #1.1: Type: text/plain, Size: 443 bytes --]
On Sat, Mar 09, 2019 at 11:13:40AM +0100, Wolfram Sang wrote:
> On Wed, Mar 06, 2019 at 03:12:16PM +0000, Bich HEMON wrote:
> > From: Nicolas Le Bayon <nicolas.le.bayon@st.com>
> >
> > It conforms with Reference Manual I2C timing section.
> >
> > Signed-off-by: Nicolas Le Bayon <nicolas.le.bayon@st.com>
> > Signed-off-by: Bich Hemon <bich.hemon@st.com>
>
> Applied to for-current, thanks!
Do you have a Fixes tag for this?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: i2c-stm32f7: Fix SDADEL minimum formula
2019-03-09 10:50 ` Wolfram Sang
@ 2019-03-11 9:34 ` Bich HEMON
2019-03-12 13:00 ` Wolfram Sang
0 siblings, 1 reply; 6+ messages in thread
From: Bich HEMON @ 2019-03-11 9:34 UTC (permalink / raw)
To: Wolfram Sang
Cc: Mark Rutland, devicetree@vger.kernel.org, Alexandre TORGUE,
linux-kernel@vger.kernel.org, Pierre Yves MORDRET, Rob Herring,
linux-i2c@vger.kernel.org, Maxime Coquelin,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
On 3/9/19 11:50 AM, Wolfram Sang wrote:
> On Sat, Mar 09, 2019 at 11:13:40AM +0100, Wolfram Sang wrote:
>> On Wed, Mar 06, 2019 at 03:12:16PM +0000, Bich HEMON wrote:
>>> From: Nicolas Le Bayon <nicolas.le.bayon@st.com>
>>>
>>> It conforms with Reference Manual I2C timing section.
>>>
>>> Signed-off-by: Nicolas Le Bayon <nicolas.le.bayon@st.com>
>>> Signed-off-by: Bich Hemon <bich.hemon@st.com>
>>
>> Applied to for-current, thanks!
>
> Do you have a Fixes tag for this?
>
Hi Wolfram,
Fixes: aeb068c57214858b638d5ee627bb4a831f98771e ("i2c: i2c-stm32f7: add
driver")
Will you change the commit message or do you want me to resend the patch?
BR,
Bich
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] i2c: i2c-stm32f7: Fix SDADEL minimum formula
2019-03-11 9:34 ` Bich HEMON
@ 2019-03-12 13:00 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2019-03-12 13:00 UTC (permalink / raw)
To: Bich HEMON
Cc: Mark Rutland, devicetree@vger.kernel.org, Alexandre TORGUE,
linux-kernel@vger.kernel.org, Pierre Yves MORDRET, Rob Herring,
linux-i2c@vger.kernel.org, Maxime Coquelin,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
[-- Attachment #1.1: Type: text/plain, Size: 260 bytes --]
> > Do you have a Fixes tag for this?
> >
>
> Fixes: aeb068c57214858b638d5ee627bb4a831f98771e ("i2c: i2c-stm32f7: add
> driver")
>
> Will you change the commit message or do you want me to resend the patch?
I'll fix it. Thanks for this info!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-12 13:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-06 15:12 [PATCH] i2c: i2c-stm32f7: Fix SDADEL minimum formula Bich HEMON
2019-03-07 8:29 ` Pierre Yves MORDRET
2019-03-09 10:13 ` Wolfram Sang
2019-03-09 10:50 ` Wolfram Sang
2019-03-11 9:34 ` Bich HEMON
2019-03-12 13:00 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).