From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53F02C43381 for ; Thu, 7 Mar 2019 01:40:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2102820663 for ; Thu, 7 Mar 2019 01:40:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QtEaZqK5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2102820663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ySQzdkeT40tbyarHKxbw03GJFreG4ia/+8jnu++oy40=; b=QtEaZqK5hn5/QA vDGdUMpUUS2VTBJ3f807WfVQpaiz1MAXgZOj1vqS1bVS1+XU7dilVXkw4CYGgcEHoIyYdk6PmPSyg 4ipVOmye2WPdonB9Yx7bpYLmxARvM7d/MydFZwq0FbUbK2Qxu1/qBVATZjCgSg9Jp9ShwCXp+2j0j vgtN9VEOjg4+camarz7R4hQddEPKqRThkITrvK4OZQdBhUF4d5bLzwNobQsy2hAUkLKrQhmI61IqL QSoCNU3/hd+41UkmDmDUgWxQBIBaYpNT2LqwSfPtMBP12GINWMvTJZCczWy3+P69YQeTunvv3tCP/ w78Q51b4aCs9Y7z0d7Xg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1i13-0003Qn-0V; Thu, 07 Mar 2019 01:40:09 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1i0y-0002ir-V9; Thu, 07 Mar 2019 01:40:06 +0000 X-UUID: bad0b1b42bcf4c37a2fffc465c97624e-20190306 X-UUID: bad0b1b42bcf4c37a2fffc465c97624e-20190306 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1727845066; Wed, 06 Mar 2019 17:39:59 -0800 Received: from mtkmbs03n1.mediatek.inc (172.21.101.181) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 6 Mar 2019 17:39:58 -0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs03n1.mediatek.inc (172.21.101.181) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 7 Mar 2019 09:39:56 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 7 Mar 2019 09:39:56 +0800 Message-ID: <1551922796.20144.7.camel@mtksdaap41> Subject: Re: [PATCH v2 03/10] dt-binding: gce: add binding for gce subsys property From: CK Hu To: Bibby Hsieh Date: Thu, 7 Mar 2019 09:39:56 +0800 In-Reply-To: <1551865835-50974-4-git-send-email-bibby.hsieh@mediatek.com> References: <1551865835-50974-1-git-send-email-bibby.hsieh@mediatek.com> <1551865835-50974-4-git-send-email-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190306_174005_035602_15A1321C X-CRM114-Status: GOOD ( 15.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , Philipp Zabel , srv_heupstream@mediatek.com, kendrick.hsu@mediatek.com, Daoyuan Huang , Sascha Hauer , Jassi Brar , linux-kernel@vger.kernel.org, Daniel Kurtz , Dennis-YC Hsieh , YT Shen , Rob Herring , linux-mediatek@lists.infradead.org, Houlong Wei , Sascha Hauer , Matthias Brugger , Jiaguang Zhang , Frederic Chen , linux-arm-kernel@lists.infradead.org, ginny.chen@mediatek.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Wed, 2019-03-06 at 17:50 +0800, Bibby Hsieh wrote: > cmdq driver provide a function that get the relationship > of sub system number from device node for client. > add specification for #subsys-cells, mediatek,gce-subsys. > > Signed-off-by: Bibby Hsieh > --- > Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > index 812698f..07b2adf 100644 > --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > @@ -26,6 +26,13 @@ Required properties: > phandle: Label name of a gce node. > event_number: the event number defined in 'dt-bindings/gce/mt8173-gce.h' > or 'dt-binding/gce/mt8183-gce.h'. > +#subsys-cells: Should be 2. > + <&phandle register_base_address subsys_number> > + phandle: Label name of a gce node. > + register_base_address: the register base address that client > + want to write or read. This look like the same as 'reg' property. I would prefer use already-defined property, for example: mmsys: clock-controller@14000000 { compatible = "mediatek,mt8173-mmsys", "syscon"; reg = <0 0x14000000 0 0x1000>; mediatek,gce-subsys = <&gce SUBSYS_1400XXXX>; }; Regards, CK > + subsys_number: specify the sub-system id which is corresponding > + to the register address. > > Required properties for a client device: > - mboxes: Client use mailbox to communicate with GCE, it should have this > @@ -50,6 +57,7 @@ Example: > thread-num = CMDQ_THR_MAX_COUNT; > #mbox-cells = <3>; > #event-cells = <1>; > + #subsys-cells = <2>; > }; > > Example for a client device: > @@ -58,7 +66,8 @@ Example for a client device: > compatible = "mediatek,mt8173-mmsys"; > mboxes = <&gce 0 CMDQ_THR_PRIO_LOWEST 1>, > <&gce 1 CMDQ_THR_PRIO_LOWEST 1>; > - mediatek,gce-subsys = ; > + mediatek,gce-subsys = <&gce 0x14000000 SUBSYS_1400XXXX>, > + <&gce 0x14010000 SUBSYS_1401XXXX>; > mediatek,gce-event-names = "rdma0_sof", > "rsz0_sof"; > mediatek,gce-events = <&gce CMDQ_EVENT_MDP_RDMA0_SOF>, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel