From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A57FCC4360F for ; Thu, 7 Mar 2019 01:47:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7337520675 for ; Thu, 7 Mar 2019 01:47:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Psw+zqU+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7337520675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HdPf/5S2i/ZgyK7E/TXEgbJ2X/TtJ4QBXSJIB/GZhis=; b=Psw+zqU+n9q4g7 ZlTPlhgzkaHAr+FT7Znzt4zrdw/v2DLllG493uQdoiFdsC3tHi72P/gZc1w0xzkuX8QfMD05zkiOe kE0Mb8ZZV8ZWl+N2zeLTBMXgsDapD3NYTSI58OOh5VDlqeN65A+ptF70zFerW4leTX9klyi5DNviU QSArvr+RfDxuQwWEvDSf+AS22NJ2v9sqQ+6NMfwtXa75vlAk+WNPy4r1bWWoxnjB9+c4nGv7desoF QcCdRzgGY1bvKtaRzcGJt7azSmlRRwfvH53nu2wV7CVT9XVbBZeuW3t3LkmUT4mIwUlcfqwIiZKAo znC83q2pk73aCvMLSbSA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1i8V-0006yK-EC; Thu, 07 Mar 2019 01:47:51 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1i8R-0006x3-4a; Thu, 07 Mar 2019 01:47:48 +0000 X-UUID: 4882f47f78114c74adca52c2fb8b1b4a-20190306 X-UUID: 4882f47f78114c74adca52c2fb8b1b4a-20190306 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 273551397; Wed, 06 Mar 2019 17:47:44 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 6 Mar 2019 17:47:42 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 7 Mar 2019 09:47:40 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 7 Mar 2019 09:47:39 +0800 Message-ID: <1551923259.32207.10.camel@mhfsdcap03> Subject: Re: [PATCH] arm64: dts: add gce node for mt8183 From: houlong wei To: CK Hu , Date: Thu, 7 Mar 2019 09:47:39 +0800 In-Reply-To: <1551921866.20144.1.camel@mtksdaap41> References: <1551867024-52951-1-git-send-email-bibby.hsieh@mediatek.com> <1551921866.20144.1.camel@mtksdaap41> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190306_174747_179725_CD59B302 X-CRM114-Status: GOOD ( 17.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Kurtz , Jiaguang Zhang =?UTF-8?Q?=28=E5=BC=A0=E5=8A=A0=E5=B9=BF=29?= , Nicolas Boichat , Jassi Brar , Bibby Hsieh =?UTF-8?Q?=28=E8=AC=9D=E6=BF=9F=E9=81=A0=29?= , YT Shen =?UTF-8?Q?=28=E6=B2=88=E5=B2=B3=E9=9C=86=29?= , Frederic Chen =?UTF-8?Q?=28=E9=99=B3=E4=BF=8A=E5=85=83=29?= , "devicetree@vger.kernel.org" , Kendrick Hsu =?UTF-8?Q?=28=E5=BE=90=E5=AD=90=E5=87=A1=29?= , Philipp Zabel , Daoyuan Huang =?UTF-8?Q?=28=E9=BB=83=E9=81=93=E5=8E=9F=29?= , Sascha Hauer , houlong.wei@mediatek.com, Rob Herring , "linux-mediatek@lists.infradead.org" , Matthias Brugger , "linux-arm-kernel@lists.infradead.org" , srv_heupstream , "linux-kernel@vger.kernel.org" , Dennis-YC Hsieh =?UTF-8?Q?=28=E8=AC=9D=E5=AE=87=E5=93=B2=29?= , Ginny Chen =?UTF-8?Q?=28=E9=99=B3=E6=B2=BB=E5=82=91=29?= , Sascha Hauer Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2019-03-07 at 09:24 +0800, CK Hu wrote: > Hi, Bibby: > > On Wed, 2019-03-06 at 18:10 +0800, Bibby Hsieh wrote: > > This patch need based on v5.0-rc1 and these series > > http://lists.infradead.org/pipermail/linux-mediatek/2019-February/017570.html > > http://lists.infradead.org/pipermail/linux-mediatek/2019-February/017320.html > > http://lists.infradead.org/pipermail/linux-mediatek/2019-January/017196.html > > http://lists.infradead.org/pipermail/linux-mediatek/2019-March/018005.html > > > > add gce device node for mt8183 > > > > Signed-off-by: Bibby Hsieh > > --- > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > index 165b859..5006368 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > @@ -8,6 +8,7 @@ > > #include > > #include > > #include > > +#include > > #include "mt8183-pinfunc.h" > > > > / { > > @@ -238,6 +239,18 @@ > > clock-names = "spi", "wrap"; > > }; > > > > + gce: gce@10238000 { > > + compatible = "mediatek,mt8183-gce"; > > + reg = <0 0x10238000 0 0x4000>; > > + interrupts = ; > > + thread-num = ; > > I does not find 'thread-num' in binding document [1]. > > [1] > https://www.kernel.org/doc/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > > Regards, > CK The property "thread-num" is not used and and it was removed from the properties description, but I forgot to remove it from the example. That is misleading and I'm sorry for that. @Bibby, could you please help remove it from the example in mtk-gce.txt if you would upload a new version? > > > + #mbox-cells = <3>; > > + #gce-event-cells = <1>; > > + #gce-subsys-cells = <2>; > > + clocks = <&infracfg CLK_INFRA_GCE>; > > + clock-names = "gce"; > > + }; > > + > > uart0: serial@11002000 { > > compatible = "mediatek,mt8183-uart", > > "mediatek,mt6577-uart"; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel