From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDCA8C43381 for ; Thu, 7 Mar 2019 02:22:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F31420663 for ; Thu, 7 Mar 2019 02:22:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gqltULqQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F31420663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fN1e6ol3ez5siASsmZJnDtBMTlu/+mInmax729YTJ/s=; b=gqltULqQMJYXyH o285+rmqiQZD1d5fy/8B6/YlyxoptIvrm7XnfLAqQAlbUBbEjkc/VFUWPDHT6hltGhATrHBjPFqb9 pHv8Kae6d66wwnAAOgcvmNAKG7WB2xTsHUNw52N1NkCvez6YvNKDvLmcgszK4MrSwrVzB21aBl6Pu tml2zpcSpU7ZeW4TipshHr5zRd3vTJ9wH90Jcr+WgnJoeYJuiVOaVMKg7tzgj/uYx54+Ds/kw+gJP tblnf7GYQGb4DcW0SIgXZZvtwG21dBVtuFCFw76kcKVa+VXKaOTWqhx9J3xwNsSlVHjRtnJo2uW5U p5ltddJEqkQ4bK0ERm6w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1ifX-00016I-E0; Thu, 07 Mar 2019 02:21:59 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1ifU-00015O-3K; Thu, 07 Mar 2019 02:21:57 +0000 X-UUID: 58980b0912364ad087a7b430610cc73b-20190306 X-UUID: 58980b0912364ad087a7b430610cc73b-20190306 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 47769848; Wed, 06 Mar 2019 18:20:58 -0800 Received: from mtkmbs03n1.mediatek.inc (172.21.101.181) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 6 Mar 2019 18:20:56 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs03n1.mediatek.inc (172.21.101.181) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 7 Mar 2019 10:20:55 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 7 Mar 2019 10:20:55 +0800 Message-ID: <1551925255.20144.13.camel@mtksdaap41> Subject: Re: [PATCH v2 03/10] dt-binding: gce: add binding for gce subsys property From: CK Hu To: Bibby Hsieh Date: Thu, 7 Mar 2019 10:20:55 +0800 In-Reply-To: <1551922796.20144.7.camel@mtksdaap41> References: <1551865835-50974-1-git-send-email-bibby.hsieh@mediatek.com> <1551865835-50974-4-git-send-email-bibby.hsieh@mediatek.com> <1551922796.20144.7.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190306_182156_153031_4EA2905E X-CRM114-Status: GOOD ( 19.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , Philipp Zabel , srv_heupstream@mediatek.com, kendrick.hsu@mediatek.com, Daoyuan Huang , Sascha Hauer , Jassi Brar , linux-kernel@vger.kernel.org, Daniel Kurtz , Dennis-YC Hsieh , YT Shen , Rob Herring , linux-mediatek@lists.infradead.org, Houlong Wei , Sascha Hauer , Matthias Brugger , Jiaguang Zhang , Frederic Chen , linux-arm-kernel@lists.infradead.org, ginny.chen@mediatek.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Thu, 2019-03-07 at 09:39 +0800, CK Hu wrote: > Hi, Bibby: > > On Wed, 2019-03-06 at 17:50 +0800, Bibby Hsieh wrote: > > cmdq driver provide a function that get the relationship > > of sub system number from device node for client. > > add specification for #subsys-cells, mediatek,gce-subsys. > > > > Signed-off-by: Bibby Hsieh > > --- > > Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > > index 812698f..07b2adf 100644 > > --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > > +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > > @@ -26,6 +26,13 @@ Required properties: > > phandle: Label name of a gce node. > > event_number: the event number defined in 'dt-bindings/gce/mt8173-gce.h' > > or 'dt-binding/gce/mt8183-gce.h'. > > +#subsys-cells: Should be 2. > > + <&phandle register_base_address subsys_number> > > + phandle: Label name of a gce node. > > + register_base_address: the register base address that client > > + want to write or read. > > This look like the same as 'reg' property. I would prefer use > already-defined property, for example: > > mmsys: clock-controller@14000000 { > compatible = "mediatek,mt8173-mmsys", "syscon"; > reg = <0 0x14000000 0 0x1000>; > mediatek,gce-subsys = <&gce SUBSYS_1400XXXX>; > }; My previous thinking may not be proper, GCE could write register but its behavior may be not the same as CPU, so it's better not to mix these two register_base_address. Regards, CK > > Regards, > CK > > > + subsys_number: specify the sub-system id which is corresponding > > + to the register address. > > > > Required properties for a client device: > > - mboxes: Client use mailbox to communicate with GCE, it should have this > > @@ -50,6 +57,7 @@ Example: > > thread-num = CMDQ_THR_MAX_COUNT; > > #mbox-cells = <3>; > > #event-cells = <1>; > > + #subsys-cells = <2>; > > }; > > > > Example for a client device: > > @@ -58,7 +66,8 @@ Example for a client device: > > compatible = "mediatek,mt8173-mmsys"; > > mboxes = <&gce 0 CMDQ_THR_PRIO_LOWEST 1>, > > <&gce 1 CMDQ_THR_PRIO_LOWEST 1>; > > - mediatek,gce-subsys = ; > > + mediatek,gce-subsys = <&gce 0x14000000 SUBSYS_1400XXXX>, > > + <&gce 0x14010000 SUBSYS_1401XXXX>; > > mediatek,gce-event-names = "rdma0_sof", > > "rsz0_sof"; > > mediatek,gce-events = <&gce CMDQ_EVENT_MDP_RDMA0_SOF>, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel