From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 980C0C43381 for ; Mon, 11 Mar 2019 05:33:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 681102075C for ; Mon, 11 Mar 2019 05:33:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="I/iTLehD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 681102075C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IJgDn/kGZn26OrufTC8VWxZmXJf/Qj9difdlU2L4hAo=; b=I/iTLehDLVXrT9 QfGAeusY2XTujamI9jjg7aarm8ex/B0hLdP8zCnD0IzXezNvSonbEgbY96uWkjACTW+VS8CQA71Gi Agz3BXGy3w0U7DcVj+796NMOpcA13MayMLrAMRVX30FXAlLNZco6WpG/IHF1ko6arTY9dKzw99yHm pv9CCXdFrdLTU9OsD5gRLBPd6yoaN91X+hSfH43okR3Bbb4Nhu3k1tnS8ib/zzdOoUGwr4s4aZYmU 4ltg49NJmU4pViaLWOkL5QYdxgicXmb1lnQT9kqcxDCBn1s1oD8XxLJ1FgmF7XUW++IPPtpJNoYOv +88yxYkL6C+oRt1kzu8Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3DYt-0008Aj-R3; Mon, 11 Mar 2019 05:33:19 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3DYq-00089Z-2P; Mon, 11 Mar 2019 05:33:17 +0000 X-UUID: c55c149308364835be396d6bdf17abed-20190310 X-UUID: c55c149308364835be396d6bdf17abed-20190310 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1004344281; Sun, 10 Mar 2019 21:33:09 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 10 Mar 2019 22:33:07 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 11 Mar 2019 13:33:04 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 11 Mar 2019 13:33:03 +0800 Message-ID: <1552282383.10179.21.camel@mhfsdcap03> Subject: Re: [PATCH 1/5] dt-bindings: connector: add optional properties for Type-B From: Chunfeng Yun To: Hans de Goede Date: Mon, 11 Mar 2019 13:33:03 +0800 In-Reply-To: <693b11e7-fa9e-ab1f-561a-beb758b1872f@redhat.com> References: <1552025622-15582-1-git-send-email-chunfeng.yun@mediatek.com> <1552025622-15582-2-git-send-email-chunfeng.yun@mediatek.com> <693b11e7-fa9e-ab1f-561a-beb758b1872f@redhat.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190310_223316_117990_CB67E150 X-CRM114-Status: GOOD ( 22.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heikki Krogerus , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Badhri Jagan Sridharan , Andy Shevchenko , Rob Herring , linux-mediatek@lists.infradead.org, Min Guo , Matthias Brugger , Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Fri, 2019-03-08 at 13:07 +0100, Hans de Goede wrote: > Hi, > > On 08-03-19 07:13, Chunfeng Yun wrote: > > Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for > > usb-b-connector > > > > Signed-off-by: Chunfeng Yun > > --- > > .../devicetree/bindings/connector/usb-connector.txt | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt > > index a9a2f2fc44f2..7a07b0f4f973 100644 > > --- a/Documentation/devicetree/bindings/connector/usb-connector.txt > > +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt > > @@ -17,6 +17,16 @@ Optional properties: > > - self-powered: Set this property if the usb device that has its own power > > source. > > > > +Optional properties for usb-b-connector: > > +- id-gpios: gpio for USB ID pin. > > What about boards where the ID pin is *not* connected to a GPIO, > but e.g. to a special pin on the PMIC which can also detect > an ACA adapter ? Currently this case is handled by extcon > drivers, but we have no way to set e.g. vbus-supply for the > connector. Maybe in this case the usb-connector node should > be a child of the PMIC node ? Yes, it would be, PMIC is in charger of detecting the status of ID pin > > And in many cases there also is a mux to switch the datalines > between the host and device(gadget) controllers, how should > that be described in this model? See the new usb-role-switch > code under drivers/usb/roles > > In some cases the mux is controlled through a gpio, so we > may want to add a "mux-gpios" here in which case we also > need to define what 0/1 means. I'm not sure, the mux seems not belong to this connector, and may need another driver to register usb-role-switch, similar to: [v2,2/2] usb: typec: add typec switch via GPIO control https://patchwork.kernel.org/patch/10834327/ > > > +- vbus-gpios: gpio for USB VBUS pin. > > + see gpio/gpio.txt. > > +- vbus-supply: reference to the VBUS regulator, needed when supports > > + dual-role mode. > > I think this needs some text that there can be either a vbus-gpio or > a vbus-supply. Oh wait reading: > > https://patchwork.kernel.org/patch/10819377/ > > I see that this GPIO is for detecting vbus presence, not for driving/enabling > 5v to Vbus from the board, that needs to be described more clearly. Ok Thanks a lot > > > +- pinctrl-names : a pinctrl state named "default" is optional > > +- pinctrl-0 : pin control group > > + see pinctrl/pinctrl-bindings.txt > > + > > Optional properties for usb-c-connector: > > - power-role: should be one of "source", "sink" or "dual"(DRP) if typec > > connector has power support. > > > > > Regards, > > Hans _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel