From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 115C7C43381 for ; Mon, 11 Mar 2019 05:37:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D41EE2075C for ; Mon, 11 Mar 2019 05:37:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="R5wwHxKb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D41EE2075C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ISqhMXtasS+egWQD/+UFTybO4rlZjqPMgdjHwO/a7VI=; b=R5wwHxKbX5pMfs 23w4nj9GSobUAVLIzXEHmiIT2zZbMDfCDraF4b9WigejqsDqs4hehdzJfm89Tt9eVgLfATHKB1EiE Kj2VASyLA8D94OlSuYA4m97E5doxvb0ZpW3EenuWM7NckIauOjhz50D0foeGMsLEWpqj6O9hAw9jf 68aejnO1LD9ibA7IPMqk89zhcH7eXcEqkj/0M1lnlR85GKU032ANUWTmzovZvosj0CM2YQDftX1xF 0Ja8YP8IYVubdOrMdx6tsESZvT3mIu6Pp2yyqWyE+Tei+35wsaiKmwaELpqnFMoCRWntqXH8eaK6u N/Lpt6YWFLTrFdSrIybg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3DcY-0001dU-IK; Mon, 11 Mar 2019 05:37:06 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3DcU-0001cB-D5; Mon, 11 Mar 2019 05:37:03 +0000 X-UUID: f628e80d9b3649108429a52f79b13d0d-20190310 X-UUID: f628e80d9b3649108429a52f79b13d0d-20190310 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 429348382; Sun, 10 Mar 2019 21:37:00 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 10 Mar 2019 22:36:58 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 11 Mar 2019 13:36:56 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 11 Mar 2019 13:36:56 +0800 Message-ID: <1552282615.10179.25.camel@mhfsdcap03> Subject: Re: [PATCH 3/5] usb: roles: add API to get usb_role_switch by node From: Chunfeng Yun To: Andy Shevchenko Date: Mon, 11 Mar 2019 13:36:55 +0800 In-Reply-To: References: <1552025622-15582-1-git-send-email-chunfeng.yun@mediatek.com> <1552025622-15582-4-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190310_223702_448741_2643E41E X-CRM114-Status: GOOD ( 11.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Heikki Krogerus , Hans de Goede , Greg Kroah-Hartman , USB , Linux Kernel Mailing List , Badhri Jagan Sridharan , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Min Guo , Matthias Brugger , Adam Thomson , linux-arm Mailing List , Li Jun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Fri, 2019-03-08 at 08:52 +0200, Andy Shevchenko wrote: > On Fri, Mar 8, 2019 at 8:14 AM Chunfeng Yun wrote: > > > > Add usb_role_switch_get_by_node() to make easier to get > > usb_role_switch by node which register it. > > It's useful when there is not device_connection registered > > between two drivers and only knows the node which register > > usb_role_switch. > > > +static int __switch_match_node(struct device *dev, const void *node) > > +{ > > + return dev->parent->of_node == (const struct device_node *)node; > > +} > > Hmm... Shouldn't be slightly better to compare fwnode instead? > Using fwnode is indeed suitable for more cases, I find that there are many functions named xx_by_node using node, but not fwnode, is there any rules about choice between device_node and fwnode_handle? Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel