From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B552AC43381 for ; Tue, 12 Mar 2019 03:18:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8359120842 for ; Tue, 12 Mar 2019 03:18:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qcOvqdBm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8359120842 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CEe8h5yngGdM1gORyvkFhDIjS6jdT1AqcseO0nVNud8=; b=qcOvqdBmK3APjY KZEkv6mezFVo8cUEemWwYMHTL4vNQaFXlI1qt/w/sD+3iUnmVhkiwwTsn+RUIyogd3P3FzrwCTqGY R7HpdfNkznNQPvmI43fgH/HuKWTeJY66P93n9W8ROoZQB8gABdPi7GsfRGtFetyP4fAbyStm3mxX7 77yqZnhVpOHpyLyqZo+LtEXlJ2R06j18mSUpcEaFRu72q/QEKPd2m1BP9yH05/srAIyGN5Hx75Vbh UZ84D9sPWsSrE6onO+fYIx5Kgqs7XnCk9vJtqb2t+j3+H/2pbeVnnXbJEcwmOLL5NcConG/bc7o6i dpbJFeb/Z3f5gsXSvfCw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3Xvq-0002Wl-Sk; Tue, 12 Mar 2019 03:18:22 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3Xvl-0002OG-3e; Tue, 12 Mar 2019 03:18:19 +0000 X-UUID: 57ab723a3d5c494ead5bda6264ee3ba9-20190311 X-UUID: 57ab723a3d5c494ead5bda6264ee3ba9-20190311 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 922406350; Mon, 11 Mar 2019 19:18:13 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 11 Mar 2019 20:18:11 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 12 Mar 2019 11:18:09 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 12 Mar 2019 11:18:08 +0800 Message-ID: <1552360688.10179.55.camel@mhfsdcap03> Subject: Re: [PATCH 1/5] dt-bindings: connector: add optional properties for Type-B From: Chunfeng Yun To: Hans de Goede Date: Tue, 12 Mar 2019 11:18:08 +0800 In-Reply-To: References: <1552025622-15582-1-git-send-email-chunfeng.yun@mediatek.com> <1552025622-15582-2-git-send-email-chunfeng.yun@mediatek.com> <693b11e7-fa9e-ab1f-561a-beb758b1872f@redhat.com> <1552282383.10179.21.camel@mhfsdcap03> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190311_201817_281931_2575DB30 X-CRM114-Status: GOOD ( 24.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heikki Krogerus , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Badhri Jagan Sridharan , Andy Shevchenko , Rob Herring , linux-mediatek@lists.infradead.org, Min Guo , Matthias Brugger , Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, 2019-03-11 at 09:06 +0100, Hans de Goede wrote: > Hi, > > On 11-03-19 06:33, Chunfeng Yun wrote: > > Hi, > > > > On Fri, 2019-03-08 at 13:07 +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 08-03-19 07:13, Chunfeng Yun wrote: > >>> Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for > >>> usb-b-connector > >>> > >>> Signed-off-by: Chunfeng Yun > >>> --- > >>> .../devicetree/bindings/connector/usb-connector.txt | 10 ++++++++++ > >>> 1 file changed, 10 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt > >>> index a9a2f2fc44f2..7a07b0f4f973 100644 > >>> --- a/Documentation/devicetree/bindings/connector/usb-connector.txt > >>> +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt > >>> @@ -17,6 +17,16 @@ Optional properties: > >>> - self-powered: Set this property if the usb device that has its own power > >>> source. > >>> > >>> +Optional properties for usb-b-connector: > >>> +- id-gpios: gpio for USB ID pin. > >> > >> What about boards where the ID pin is *not* connected to a GPIO, > >> but e.g. to a special pin on the PMIC which can also detect > >> an ACA adapter ? Currently this case is handled by extcon > >> drivers, but we have no way to set e.g. vbus-supply for the > >> connector. Maybe in this case the usb-connector node should > >> be a child of the PMIC node ? > > Yes, it would be, PMIC is in charger of detecting the status of ID pin > > Ok, then I think this should be documented too. > > >> And in many cases there also is a mux to switch the datalines > >> between the host and device(gadget) controllers, how should > >> that be described in this model? See the new usb-role-switch > >> code under drivers/usb/roles > >> > >> In some cases the mux is controlled through a gpio, so we > >> may want to add a "mux-gpios" here in which case we also > >> need to define what 0/1 means. > > I'm not sure, the mux seems not belong to this connector, > > and may need another driver to register usb-role-switch, > > similar to: > > > > [v2,2/2] usb: typec: add typec switch via GPIO control > > https://patchwork.kernel.org/patch/10834327/ > > Right the mux/role-switch will need a driver, but the "owner" > of the usb_connector, e.g. the PMIC or the owner of the > id GPIO pin needs to know which device is the role-switch so > that it can set the role correctly based on the id-pin. > > Your binding already contains Vbus info, allowing the owner > of the usb_connector to enable/disable Vbus based on the id-pin, > but the owner will also be responsible for setting the role-switch. In this patch series, I make usb_connector driver enable/disable Vbus, but not the parent(USB controller) of usb_connector which registers a usb-role-switch, which way do you think it is better? Thanks > > Note we cannot simply assume there will be only one role-switch, > we really need some link from the usb_connector to the role-switch > (or if it is a GPIO driven role-switch simply a role-switch-gpios > member in the usb_connector). > > Regards, > > Hans > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel