From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38DFEC43381 for ; Wed, 13 Mar 2019 10:24:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06A1C2087C for ; Wed, 13 Mar 2019 10:24:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EABOHEWz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06A1C2087C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Tgz+cL3Pw5VrM4i8QnHBOvjQn2g2PNhsabBIjNfBE8k=; b=EABOHEWznBhT2B T/+sAA0BTNmhtl3F6wp2ikdwB1k+NXVoUjFSDFDh5Ln1+AUgheH/SSNXxhtYXoiOhcxl6tvkYbfsn kpYp+DE6rKfn0pZaxMPgk1H5vdr257UE3Gq7JVUBIubNjwu88vOudffBqF77TTYCo056bCNIO4vvq rMWvUECD/p4OXvZReRqlaDaIU1tb1xn5A6kJMAa8RAGaTzVagewR3b2iQofu4qFdoiSRpBNUSK7uB K3BPPBIKffjr3fM8tkTnxZT/3aSHoifl90YEvqCFPWd5RnhneKq9dz2SkEzVe1eiHmjug5OWZkYOS NEMt8Am+MF2U3vS2LXuA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h413R-0002mT-Rh; Wed, 13 Mar 2019 10:24:10 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h40uu-0001I6-KC; Wed, 13 Mar 2019 10:15:22 +0000 X-UUID: ad8f4b9a2bcf4d2ca18aa6b4e19d3bc2-20190313 X-UUID: ad8f4b9a2bcf4d2ca18aa6b4e19d3bc2-20190313 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 110376784; Wed, 13 Mar 2019 02:15:13 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 13 Mar 2019 03:15:11 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 13 Mar 2019 18:15:09 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 13 Mar 2019 18:15:09 +0800 Message-ID: <1552472109.10179.103.camel@mhfsdcap03> Subject: Re: [PATCH 1/5] dt-bindings: connector: add optional properties for Type-B From: Chunfeng Yun To: Hans de Goede Date: Wed, 13 Mar 2019 18:15:09 +0800 In-Reply-To: <464f1021-4c5e-9137-489d-65fd578575d3@redhat.com> References: <1552025622-15582-1-git-send-email-chunfeng.yun@mediatek.com> <1552025622-15582-2-git-send-email-chunfeng.yun@mediatek.com> <693b11e7-fa9e-ab1f-561a-beb758b1872f@redhat.com> <1552282383.10179.21.camel@mhfsdcap03> <1552360688.10179.55.camel@mhfsdcap03> <464f1021-4c5e-9137-489d-65fd578575d3@redhat.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190313_031520_881174_6E2EAD37 X-CRM114-Status: GOOD ( 25.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heikki Krogerus , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Badhri Jagan Sridharan , Andy Shevchenko , Rob Herring , linux-mediatek@lists.infradead.org, Min Guo , Matthias Brugger , Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Tue, 2019-03-12 at 13:45 +0100, Hans de Goede wrote: > Hi, > On 12-03-19 04:18, Chunfeng Yun wrote: > > Hi, > > On Mon, 2019-03-11 at 09:06 +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 11-03-19 06:33, Chunfeng Yun wrote: > >>> Hi, > >>> > >>> On Fri, 2019-03-08 at 13:07 +0100, Hans de Goede wrote: > >>>> Hi, > >>>> > >>>> On 08-03-19 07:13, Chunfeng Yun wrote: > >>>>> Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for > >>>>> usb-b-connector > >>>>> > >>>>> Signed-off-by: Chunfeng Yun > >>>>> --- > >>>>> .../devicetree/bindings/connector/usb-connector.txt | 10 ++++++++++ > >>>>> 1 file changed, 10 insertions(+) > >>>>> > >>>>> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt > >>>>> index a9a2f2fc44f2..7a07b0f4f973 100644 > >>>>> --- a/Documentation/devicetree/bindings/connector/usb-connector.txt > >>>>> +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt > >>>>> @@ -17,6 +17,16 @@ Optional properties: > >>>>> - self-powered: Set this property if the usb device that has its own power > >>>>> source. > >>>>> > >>>>> +Optional properties for usb-b-connector: > >>>>> +- id-gpios: gpio for USB ID pin. > >>>> > >>>> What about boards where the ID pin is *not* connected to a GPIO, > >>>> but e.g. to a special pin on the PMIC which can also detect > >>>> an ACA adapter ? Currently this case is handled by extcon > >>>> drivers, but we have no way to set e.g. vbus-supply for the > >>>> connector. Maybe in this case the usb-connector node should > >>>> be a child of the PMIC node ? > >>> Yes, it would be, PMIC is in charger of detecting the status of ID pin > >> > >> Ok, then I think this should be documented too. > >> > >>>> And in many cases there also is a mux to switch the datalines > >>>> between the host and device(gadget) controllers, how should > >>>> that be described in this model? See the new usb-role-switch > >>>> code under drivers/usb/roles > >>>> > >>>> In some cases the mux is controlled through a gpio, so we > >>>> may want to add a "mux-gpios" here in which case we also > >>>> need to define what 0/1 means. > >>> I'm not sure, the mux seems not belong to this connector, > >>> and may need another driver to register usb-role-switch, > >>> similar to: > >>> > >>> [v2,2/2] usb: typec: add typec switch via GPIO control > >>> https://patchwork.kernel.org/patch/10834327/ > >> > >> Right the mux/role-switch will need a driver, but the "owner" > >> of the usb_connector, e.g. the PMIC or the owner of the > >> id GPIO pin needs to know which device is the role-switch so > >> that it can set the role correctly based on the id-pin. > >> > >> Your binding already contains Vbus info, allowing the owner > >> of the usb_connector to enable/disable Vbus based on the id-pin, > >> but the owner will also be responsible for setting the role-switch. > > In this patch series, I make usb_connector driver enable/disable Vbus, > > but not the parent(USB controller) of usb_connector which registers a > > usb-role-switch, which way do you think it is better? > > IMHO there should not be a driver for the usb_connector child-node, > only for the parent-device of that child-node. If so, each USB controller driver should process this special case by itself when use a gpio to detect the status of ID pin, it's not a friendly way. And it's easy by using extcon-usb-gpio driver before, so we also want to provide a simple way when support usb_connector, no matter what method we choose. Ideally, the only one thing that USB controller driver need to do, just register a usb-role-switch, and leave decision when switch the role to other drivers, such as type-C, PMIC/charger, also include gpio > > There are going to be too many specific setups surrounding PMICs to > be able to do a single generic driver for the connector. > Fortunately, these patches only focus on the simplest gpio driven role switch :) Thanks > Regards, > > Hans > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel