Re: [PATCH 3/5] usb: roles: add API to get usb_role_switch by node

Chunfeng Yun
2019-03-11T05:37:13Z

Hi,

On Fri, 2019-03-08 at 08:52 +0200, Andy Shevchenko wrote:
> On Fri, Mar 8, 2019 at 8:14 AM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
> >
> > Add usb_role_switch_get_by_node() to make easier to get
> > usb_role_switch by node which register it.
> > It's useful when there is not device_connection registered
> > between two drivers and only knows the node which register
> > usb_role_switch.
>
> > +static int __switch_match_node(struct device *dev, const void *node)
> > +{
> > + return dev->parent->of_node == (const struct device_node *)node;
> > +}
>
> Hmm... Shouldn't be slightly better to compare fwnode instead?
>
Using fwnode is indeed suitable for more cases,
I find that there are many functions named xx_by_node using node, but
not fwnode, is there any rules about choice between device_node and
fwnode_handle?

Thanks