From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C08BC43381 for ; Fri, 15 Mar 2019 02:06:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C610C2186A for ; Fri, 15 Mar 2019 02:06:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RCHRPxjM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C610C2186A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:References: In-Reply-To:Date:To:From:Subject:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dVAp27XU7w2HoR3P+NQd9QHjHrNMbWdoMDYFTU2VCsU=; b=RCHRPxjMa4NO5K 1DZ1vHTOk+sd30G6P8KxHTEqgGPUO1nMeiUCWXFaIDe405atHKgNrKrijovymrj4s+Iqfzgc4oJNb 25Y+6dPb3UBdgjTJm47BwCr2/lSeTbYWCqssoxlsgjog2YjWquand/FZuKPUdr0rGaf2C0PY4Yc9v VMIRRQhxKN8ttyjtQQI4CG9M61qV471dHhRAC+m4g1tA3D0cgi6AfY7IqeCUojLo41IspP0/ob5zq F2stSs9e9voOn1MVoau5i3RxkKEJwpA4FEx+W5wWu40V8UfeJ0vkRtz3KurrYOqeGCc2X391rQ4Qu GW3UzLKxGkecmUz1b5JQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4cF1-0004IR-1w; Fri, 15 Mar 2019 02:06:35 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4cEy-0004Ht-Bl; Fri, 15 Mar 2019 02:06:33 +0000 X-UUID: ed4659d2d7634dcba073fc17e29b153f-20190314 X-UUID: ed4659d2d7634dcba073fc17e29b153f-20190314 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1056254438; Thu, 14 Mar 2019 18:06:21 -0800 Received: from MTKMBS01DR.mediatek.inc (172.21.101.111) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 14 Mar 2019 19:06:20 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs01dr.mediatek.inc (172.21.101.111) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 15 Mar 2019 10:06:18 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 15 Mar 2019 10:06:16 +0800 Message-ID: <1552615576.31200.19.camel@mhfsdcap03> Subject: Re: [PATCH 03/18] drm/mediatek: redefine mtk_ddp_sout_sel From: Yongqiang Niu To: Nicolas Boichat Date: Fri, 15 Mar 2019 10:06:16 +0800 In-Reply-To: References: <1545638931-24938-1-git-send-email-yongqiang.niu@mediatek.com> <1545638931-24938-4-git-send-email-yongqiang.niu@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190314_190632_408982_8517D72C X-CRM114-Status: GOOD ( 23.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: yongqiang.niu@mediatek.com Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , lkml , dri-devel@lists.freedesktop.org, Matthias Brugger , Rob Herring , linux-mediatek@lists.infradead.org, Philipp Zabel , CK Hu , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2018-12-25 at 11:57 +0800, Nicolas Boichat wrote: > On Mon, Dec 24, 2018 at 6:52 PM Yongqiang Niu > wrote: > > > > This patch redefine mtk_ddp_sout_sel > > Can you describe a bit more why you are making this change? the format of "mtk_ddp_sout_sel"was not flexible, after we add more mediatek SOC support, that will be redundant set this function format like mtk_ddp_mout_en and mtk_ddp_sel_in > > > Signed-off-by: Yongqiang Niu > > --- > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 32 ++++++++++++++++++++------------ > > 1 file changed, 20 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > index adb37e4..592f852 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > @@ -405,21 +405,27 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur, > > return value; > > } > > > > -static void mtk_ddp_sout_sel(void __iomem *config_regs, > > - enum mtk_ddp_comp_id cur, > > - enum mtk_ddp_comp_id next) > > +static unsigned int mtk_ddp_sout_sel(void __iomem *config_regs, > > You don't use config_regs anymore, drop it. ok, will drop it in next version > > > + enum mtk_ddp_comp_id cur, > > + enum mtk_ddp_comp_id next, > > + unsigned int *addr) > > { > > + unsigned int value; > > + > > if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DSI0) { > > - writel_relaxed(BLS_TO_DSI_RDMA1_TO_DPI1, > > - config_regs + DISP_REG_CONFIG_OUT_SEL); > > + *addr = DISP_REG_CONFIG_OUT_SEL; > > + value = BLS_TO_DSI_RDMA1_TO_DPI1; > > You can directly return BLS_TO_DSI_RDMA1_TO_DPI1. just format this like mtk_ddp_mout_en and mtk_ddp_sel_in > > > } else if (cur == DDP_COMPONENT_BLS && next == DDP_COMPONENT_DPI0) { > > - writel_relaxed(BLS_TO_DPI_RDMA1_TO_DSI, > > - config_regs + DISP_REG_CONFIG_OUT_SEL); > > - writel_relaxed(DSI_SEL_IN_RDMA, > > - config_regs + DISP_REG_CONFIG_DSI_SEL); > > - writel_relaxed(DPI_SEL_IN_BLS, > > - config_regs + DISP_REG_CONFIG_DPI_SEL); > > + *addr = DISP_REG_CONFIG_OUT_SEL; > > + value = BLS_TO_DPI_RDMA1_TO_DSI; > > I (kind of) understand the change above, as you still end up writing > BLS_TO_DSI_RDMA1_TO_DPI1 in DISP_REG_CONFIG_OUT_SEL. > > This changes the behaviour, as now you only write > BLS_TO_DPI_RDMA1_TO_DSI to DISP_REG_CONFIG_OUT_SEL, but the previous > revision of the code would also write to DISP_REG_CONFIG_DSI_SEL and > DISP_REG_CONFIG_DPI_SEL. Why? > DISP_REG_CONFIG_DSI_SEL set in the next lines. DPI_SEL_IN_BLS is 0 for DISP_REG_CONFIG_DPI_SEL set, and hardware default setting is also 0, so this one is no need anymore > > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DSI0) { > > + *addr = DISP_REG_CONFIG_DSI_SEL; > > + value = DSI_SEL_IN_RDMA; > > + } else { > > + value = 0; > > } > > + > > + return value; > > } > > > > void mtk_ddp_add_comp_to_path(void __iomem *config_regs, > > @@ -434,7 +440,9 @@ void mtk_ddp_add_comp_to_path(void __iomem *config_regs, > > writel_relaxed(reg, config_regs + addr); > > } > > > > - mtk_ddp_sout_sel(config_regs, cur, next); > > + value = mtk_ddp_sout_sel(cur, next, &addr); > > + if (value) > > + writel_relaxed(value, config_regs + addr); > > Why this change? I don't see mtk_ddp_sout_sel being used later in the > series, so I'm not sure why we don't directly write the value into the > register. > in the patch "[PATCH 04/18] drm/mediatek: move rdma sout from mtk_ddp_mout_en into mtk_ddp_sout_sel", i moved all rdma out to here, rdma only have single out, no multi out. if keep this format, there will many writel_relaxed in mtk_ddp_sout_sel. and modify this format like mtk_ddp_mout_en and mtk_ddp_sel_in looks better. > > > > value = mtk_ddp_sel_in(cur, next, &addr); > > if (value) { > > -- > > 1.8.1.1.dirty > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel