From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DB73C43381 for ; Fri, 15 Mar 2019 02:34:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B0E821873 for ; Fri, 15 Mar 2019 02:34:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oRIWSnWc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B0E821873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:References: In-Reply-To:Date:To:From:Subject:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rzAwTHc3xHk+PW//v9V+/UHRoASxQdUr2ETbMUlVpuQ=; b=oRIWSnWceD7OiL XKjBi5NJ20qDy4fF70RiZJzHYy073Ny8ujNgxiIs5ULsXx1U0Drns0DE398PU9f+oEKXEVvFEhHr/ 8Tcd63D+C1Ixco1sGfbcVSFaLaraVBPfMBnW73M7txBSG0zXt+8ZQ+/l+yA4bhz/Kxu6vqP4bTOKA lCqHsUyKyDwLUIIKdmQKjNDsPfBNk9G6X23zuFslYotlFGnX64HB2EPS8leQAyAaaCGw8WnaW8fLS USWj99QtXF/j9+eIJoCe/zFfDPcKPe1CRaZQyPEuADvH9v3KF+jK3bhuFLzQR79rW42FJ1URCsxY7 Ey6hdnNH3B0NtPUnfPhg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4cg0-00077R-QS; Fri, 15 Mar 2019 02:34:28 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4cfx-000770-Vg; Fri, 15 Mar 2019 02:34:26 +0000 X-UUID: ff0e438671bf47a78edcb565eab86ca1-20190314 X-UUID: ff0e438671bf47a78edcb565eab86ca1-20190314 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 230319551; Thu, 14 Mar 2019 18:34:18 -0800 Received: from MTKMBS01DR.mediatek.inc (172.21.101.111) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 14 Mar 2019 19:34:16 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs01dr.mediatek.inc (172.21.101.111) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 15 Mar 2019 10:34:14 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 15 Mar 2019 10:34:12 +0800 Message-ID: <1552617252.31200.24.camel@mhfsdcap03> Subject: Re: [PATCH 10/18] drm/mediatek: add gmc_bits for ovl private data From: Yongqiang Niu To: Nicolas Boichat Date: Fri, 15 Mar 2019 10:34:12 +0800 In-Reply-To: References: <1545638931-24938-1-git-send-email-yongqiang.niu@mediatek.com> <1545638931-24938-11-git-send-email-yongqiang.niu@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190314_193426_023313_9C5B51EB X-CRM114-Status: GOOD ( 20.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: yongqiang.niu@mediatek.com Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , lkml , dri-devel@lists.freedesktop.org, Matthias Brugger , Rob Herring , linux-mediatek@lists.infradead.org, Philipp Zabel , CK Hu , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2018-12-25 at 12:15 +0800, Nicolas Boichat wrote: > On Mon, Dec 24, 2018 at 6:53 PM Yongqiang Niu > wrote: > > > > This patch add gmc_bits for ovl private data > > > > Signed-off-by: Yongqiang Niu > > --- > > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 23 +++++++++++++++++++++-- > > 1 file changed, 21 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > > index 28d1911..afb313c 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > > @@ -39,7 +39,9 @@ > > #define DISP_REG_OVL_ADDR_MT8173 0x0f40 > > #define DISP_REG_OVL_ADDR(ovl, n) ((ovl)->data->addr + 0x20 * (n)) > > > > -#define OVL_RDMA_MEM_GMC 0x40402020 > > +#define GMC_THRESHOLD_BITS 16 > > +#define GMC_THRESHOLD_HIGH ((1 << GMC_THRESHOLD_BITS) / 4) > > +#define GMC_THRESHOLD_LOW ((1 << GMC_THRESHOLD_BITS) / 8) > > > > #define OVL_CON_BYTE_SWAP BIT(24) > > #define OVL_CON_MTX_YUV_TO_RGB (6 << 16) > > @@ -57,6 +59,7 @@ > > > > struct mtk_disp_ovl_data { > > unsigned int addr; > > + unsigned int gmc_bits; > > bool fmt_rgb565_is_0; > > }; > > > > @@ -140,9 +143,23 @@ static unsigned int mtk_ovl_layer_nr(struct mtk_ddp_comp *comp) > > static void mtk_ovl_layer_on(struct mtk_ddp_comp *comp, unsigned int idx) > > { > > unsigned int reg; > > + unsigned int gmc_thrshd_l; > > + unsigned int gmc_thrshd_h; > > + unsigned int gmc_value; > > + struct mtk_disp_ovl *ovl = comp_to_ovl(comp); > > > > writel(0x1, comp->regs + DISP_REG_OVL_RDMA_CTRL(idx)); > > - writel(OVL_RDMA_MEM_GMC, comp->regs + DISP_REG_OVL_RDMA_GMC(idx)); > > + > > + gmc_thrshd_l = GMC_THRESHOLD_LOW >> > > + (GMC_THRESHOLD_BITS - ovl->data->gmc_bits); > > + gmc_thrshd_h = GMC_THRESHOLD_HIGH >> > > + (GMC_THRESHOLD_BITS - ovl->data->gmc_bits); > > + if (ovl->data->gmc_bits == 10) > > + gmc_value = gmc_thrshd_h | gmc_thrshd_h << 16; > > I don't really get what this does, but is it intentional that you > don't use gmc_thrshd_l here? > GMC register was set RDMA ultra and pre-ultra threshold. MT8183 GMC register define is different with other SOC, gmc_thrshd_l not used here. > Also, if you only ever use 8 or 10 bits gmc, maybe it's easier to > hard-code the 2 values? > if (ovl->data->gmc_bits == 10) > gmc_value = OVL_RDMA_MEM_GMC_10BIT; > else > gmc_value = OVL_RDMA_MEM_GMC_8BIT; //0x40402020 > our internal maintainer prefer calculate GMC setting with private data gmc bit instead of hard-core. and with calculation function that will be more flexible > > + else > > + gmc_value = gmc_thrshd_l | gmc_thrshd_l << 8 | > > + gmc_thrshd_h << 16 | gmc_thrshd_h << 24; > > + writel(gmc_value, comp->regs + DISP_REG_OVL_RDMA_GMC(idx)); > > > > reg = readl(comp->regs + DISP_REG_OVL_SRC_CON); > > reg = reg | BIT(idx); > > @@ -324,11 +341,13 @@ static int mtk_disp_ovl_remove(struct platform_device *pdev) > > > > static const struct mtk_disp_ovl_data mt2701_ovl_driver_data = { > > .addr = DISP_REG_OVL_ADDR_MT2701, > > + .gmc_bits = 8, > > .fmt_rgb565_is_0 = false, > > }; > > > > static const struct mtk_disp_ovl_data mt8173_ovl_driver_data = { > > .addr = DISP_REG_OVL_ADDR_MT8173, > > + .gmc_bits = 8, > > .fmt_rgb565_is_0 = true, > > }; > > > > -- > > 1.8.1.1.dirty > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel