public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Stanley Chu <stanley.chu@mediatek.com>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
	jejb@linux.ibm.com, linux-kernel@vger.kernel.org,
	linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
	matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drivers: ufs: Add missing MODULE_* information
Date: Thu, 21 Mar 2019 21:18:21 +0800	[thread overview]
Message-ID: <1553174301.30977.85.camel@mtkswgap22> (raw)
In-Reply-To: <20190321125034.22697-1-anders.roxell@linaro.org>

Hi Anders,

On Thu, 2019-03-21 at 13:50 +0100, Anders Roxell wrote:
> When building the ufs-mediatek module the following warning shows up:
> 
> WARNING: modpost: missing MODULE_LICENSE() in
>   drivers/scsi/ufs/ufs-mediatek.o
> 
> Rework to add MODULE_LICENSE,MODULE_AUTHOR and MODULE_DESCRIPTION.
> 
> Fixes: ddd90623ce26 ("scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
>  drivers/scsi/ufs/ufs-mediatek.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index c3b78fc83d3f..ce4767784937 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -364,4 +364,9 @@ static struct platform_driver ufs_mtk_pltform = {
>  	},
>  };
>  
> +MODULE_AUTHOR("Stanley Chu <stanley.chu@mediatek.com>");
> +MODULE_AUTHOR("Peter Wang <peter.wang@mediatek.com>");
> +MODULE_DESCRIPTION("Mediatek UFS Driver");

Thanks for sending this.

Could you fix it as "MediaTek UFS Host Driver" ?

> +MODULE_LICENSE("GPL v2");
> +
>  module_platform_driver(ufs_mtk_pltform);

Thanks,
Stanley


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-03-21 13:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21 12:50 [PATCH] drivers: ufs: Add missing MODULE_* information Anders Roxell
2019-03-21 13:18 ` Stanley Chu [this message]
2019-03-21 13:21   ` Anders Roxell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1553174301.30977.85.camel@mtkswgap22 \
    --to=stanley.chu@mediatek.com \
    --cc=anders.roxell@linaro.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=matthias.bgg@gmail.com \
    --cc=peter.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox