From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8DA6C4360F for ; Thu, 21 Mar 2019 13:18:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75AEB21901 for ; Thu, 21 Mar 2019 13:18:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XXNSaXJW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75AEB21901 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3ggsZBY1Dfjr0dNpQsAbJ12b0j8i7u++CT4OMlJaZVs=; b=XXNSaXJWq6+ZOf SACksJUsz7z9C3fBbUZ6+cw9X00qd85lZGoD7HQdspJw4v4rzJUq4RIsi8joq/WQhs5X4cYAXNIT7 hyZrPoi73A4RVyhVwbe4hD8dpjlZLWCndk8mlKB7XnCWEGJ1JBzelq+phkLXqvwOj9Vr42b3iUwaY ZF0WHNNEcnCDO+emuE7ARP8+fgFIFBUvUWK49bFLs33E4mtTT1+6FGTqJeU3GFZe6OIPQ+H8VtZEP C+8o5s05cwf0WvRbP38gA+VpkRFu1z3N/yIo0EfugUJyVW+aZgjH2UXq7OGJDrEawiiUWpjGWCVyl CWrAatMR33SR2l58PXig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6xah-0007H1-QU; Thu, 21 Mar 2019 13:18:39 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6xac-0007Fc-Vv; Thu, 21 Mar 2019 13:18:37 +0000 X-UUID: 291655762bc14f859fd74cc7f46d5db8-20190321 X-UUID: 291655762bc14f859fd74cc7f46d5db8-20190321 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1656517765; Thu, 21 Mar 2019 05:18:31 -0800 Received: from mtkmbs08n2.mediatek.inc (172.21.101.56) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 21 Mar 2019 06:18:29 -0700 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 21 Mar 2019 21:18:27 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 21 Mar 2019 21:18:21 +0800 Message-ID: <1553174301.30977.85.camel@mtkswgap22> Subject: Re: [PATCH] drivers: ufs: Add missing MODULE_* information From: Stanley Chu To: Anders Roxell Date: Thu, 21 Mar 2019 21:18:21 +0800 In-Reply-To: <20190321125034.22697-1-anders.roxell@linaro.org> References: <20190321125034.22697-1-anders.roxell@linaro.org> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: 9FCBE2183300D0FFBBE0099CC5D466A4B14118D7099CE23D3360245637163CC12000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190321_061835_036631_103BE105 X-CRM114-Status: GOOD ( 13.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, jejb@linux.ibm.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, peter.wang@mediatek.com, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Anders, On Thu, 2019-03-21 at 13:50 +0100, Anders Roxell wrote: > When building the ufs-mediatek module the following warning shows up: > > WARNING: modpost: missing MODULE_LICENSE() in > drivers/scsi/ufs/ufs-mediatek.o > > Rework to add MODULE_LICENSE,MODULE_AUTHOR and MODULE_DESCRIPTION. > > Fixes: ddd90623ce26 ("scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips") > Signed-off-by: Anders Roxell > --- > drivers/scsi/ufs/ufs-mediatek.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c > index c3b78fc83d3f..ce4767784937 100644 > --- a/drivers/scsi/ufs/ufs-mediatek.c > +++ b/drivers/scsi/ufs/ufs-mediatek.c > @@ -364,4 +364,9 @@ static struct platform_driver ufs_mtk_pltform = { > }, > }; > > +MODULE_AUTHOR("Stanley Chu "); > +MODULE_AUTHOR("Peter Wang "); > +MODULE_DESCRIPTION("Mediatek UFS Driver"); Thanks for sending this. Could you fix it as "MediaTek UFS Host Driver" ? > +MODULE_LICENSE("GPL v2"); > + > module_platform_driver(ufs_mtk_pltform); Thanks, Stanley _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel