From: Stanley Chu <stanley.chu@mediatek.com>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
jejb@linux.ibm.com, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] scsi: ufs-mediatek: fix uninitialized variable
Date: Thu, 21 Mar 2019 21:34:14 +0800 [thread overview]
Message-ID: <1553175254.30977.88.camel@mtkswgap22> (raw)
In-Reply-To: <20190321131925.27421-1-anders.roxell@linaro.org>
Hi Anders,
On Thu, 2019-03-21 at 14:19 +0100, Anders Roxell wrote:
> When building the ufs-mediatek driver variable 'ret' may be used
> uninitialized.
>
> ../drivers/scsi/ufs/ufs-mediatek.c: In function ‘ufs_mtk_setup_clocks’:
> ../drivers/scsi/ufs/ufs-mediatek.c:96:6: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> int ret;
> ^~~
>
> Rework to return directly instead of using a local variable 'ret'.
>
> Fixes: ddd90623ce26 ("scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> drivers/scsi/ufs/ufs-mediatek.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index ce4767784937..330d68871b06 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -93,7 +93,6 @@ static int ufs_mtk_setup_clocks(struct ufs_hba *hba, bool on,
> enum ufs_notify_change_status status)
> {
> struct ufs_mtk_host *host = ufshcd_get_variant(hba);
> - int ret;
>
> /*
> * In case ufs_mtk_init() is not yet done, simply ignore.
> @@ -106,18 +105,18 @@ static int ufs_mtk_setup_clocks(struct ufs_hba *hba, bool on,
> switch (status) {
> case PRE_CHANGE:
> if (!on)
> - ret = phy_power_off(host->mphy);
> + return phy_power_off(host->mphy);
> break;
> case POST_CHANGE:
> if (on)
> - ret = phy_power_on(host->mphy);
> + return phy_power_on(host->mphy);
> break;
> default:
> - ret = -EINVAL;
> + return -EINVAL;
> break;
> }
>
> - return ret;
> + return 0;
> }
>
> /**
This was already fixed by Nathan Chancellor in below patch,
https://lkml.org/lkml/2019/3/20/784
Anyway thanks for sending this fix.
Stanley.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-03-21 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 13:19 [PATCH] scsi: ufs-mediatek: fix uninitialized variable Anders Roxell
2019-03-21 13:34 ` Stanley Chu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553175254.30977.88.camel@mtkswgap22 \
--to=stanley.chu@mediatek.com \
--cc=anders.roxell@linaro.org \
--cc=jejb@linux.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox