From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 002D6C43381 for ; Wed, 27 Mar 2019 06:56:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C11372075D for ; Wed, 27 Mar 2019 06:56:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZcbCMNIZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C11372075D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uq3tcs5Uf2Q90EVfCNIxR1z5vhHxvi0n8SDdRenvnjA=; b=ZcbCMNIZNCa+Co AryTuy76c3V/QzCItd+hH02mj+hv4I7SMHq3TbVySut9mhAPeB0Spa1HAaHSSKD5Y2CZ6NmymA5ub qN8B3sGN8etqjiutE2SVQk5qzIcGQvKLHbtISjUSyUrvyR+7544IfumSEqQGfaIE2HoMRtUsrhhVo j+cuodQmeaFOFF0XtV3kT/em7suX2om2jmpsD1vYkhR+YlU2N09GZPnsPLTsBAGXGjQI3bPJoM/pg xQH8cc30t3Hn3OCdywUlyVxksfXw0PVBGc325iO3WYIzsoj4V9es3X1h8vunOqKuJ6tih6rn6KuTj nbk3WRETaAVTQmSY5PjA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h92UD-0006rK-8Y; Wed, 27 Mar 2019 06:56:33 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h92U9-0006qJ-MY; Wed, 27 Mar 2019 06:56:31 +0000 X-UUID: 9ec1fe4c4ddf463fbbf65e71b5bc52f6-20190326 X-UUID: 9ec1fe4c4ddf463fbbf65e71b5bc52f6-20190326 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 811650090; Tue, 26 Mar 2019 22:56:24 -0800 Received: from MTKMBS32N2.mediatek.inc (172.27.4.72) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 26 Mar 2019 23:56:23 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS32N2.mediatek.inc (172.27.4.72) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 27 Mar 2019 14:56:19 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 27 Mar 2019 14:56:19 +0800 Message-ID: <1553669779.10179.172.camel@mhfsdcap03> Subject: Re: [PATCH] usb: mtu3: fix EXTCON dependency From: Chunfeng Yun To: Arnd Bergmann Date: Wed, 27 Mar 2019 14:56:19 +0800 In-Reply-To: <20190325135440.2166315-1-arnd@arndb.de> References: <20190325135440.2166315-1-arnd@arndb.de> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: 651F7988FCF2C72B0EB449E36F2D4F2E03D516550D08353FFCD6E2834597AC0C2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_235629_752325_A368D85C X-CRM114-Status: GOOD ( 15.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd, On Mon, 2019-03-25 at 14:54 +0100, Arnd Bergmann wrote: > When EXTCON is a loadable module, mtu3 fails to link as built-in: > > drivers/usb/mtu3/mtu3_plat.o: In function `mtu3_probe': > mtu3_plat.c:(.text+0x690): undefined reference to `extcon_get_edev_by_phandle' > > Add a Kconfig dependency to force mtu3 also to be a loadable module > if extconn is, but still allow it to be built without extcon. ^^ extcon > > Fixes: d0ed062a8b75 ("usb: mtu3: dual-role mode support") > Signed-off-by: Arnd Bergmann > --- > drivers/usb/mtu3/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/mtu3/Kconfig b/drivers/usb/mtu3/Kconfig > index bcc23486c4ed..928c2cd6fc00 100644 > --- a/drivers/usb/mtu3/Kconfig > +++ b/drivers/usb/mtu3/Kconfig > @@ -6,6 +6,7 @@ config USB_MTU3 > tristate "MediaTek USB3 Dual Role controller" > depends on USB || USB_GADGET > depends on ARCH_MEDIATEK || COMPILE_TEST > + depends on EXTCON || !EXTCON > select USB_XHCI_MTK if USB_SUPPORT && USB_XHCI_HCD > help > Say Y or M here if your system runs on MediaTek SoCs with Tested-by: Chunfeng Yun Thank you! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel