From: Chang-An Chen <chang-an.chen@mediatek.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Corey Minyard" <cminyard@mvista.com>,
"Kees Cook" <keescook@chromium.org>,
"wsd_upstream@mediatek.com" <wsd_upstream@mediatek.com>,
"Frederic Weisbecker" <fweisbec@gmail.com>,
"Kuohong Wang (王國鴻)" <kuohong.wang@mediatek.com>,
"Pavel Tatashin" <pasha.tatashin@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"John Stultz" <john.stultz@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Stanley Chu (朱原陞)" <stanley.chu@mediatek.com>,
"Ingo Molnar" <mingo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/1] sched/clock: Prevent generic sched_clock wrap caused by tick_freeze()
Date: Fri, 29 Mar 2019 10:30:09 +0800 [thread overview]
Message-ID: <1553826609.8188.0.camel@mtkswgap22> (raw)
In-Reply-To: <alpine.DEB.2.21.1903251449580.1656@nanos.tec.linutronix.de>
On Mon, 2019-03-25 at 21:54 +0800, Thomas Gleixner wrote:
> On Mon, 25 Mar 2019, Chang-An Chen wrote:
> > --- a/include/linux/sched_clock.h
> > +++ b/include/linux/sched_clock.h
> > @@ -13,6 +13,10 @@
> >
> > extern void sched_clock_register(u64 (*read)(void), int bits,
> > unsigned long rate);
> > +
> > +extern int sched_clock_suspend(void);
> > +
> > +extern void sched_clock_resume(void);
> > #else
> > static inline void generic_sched_clock_init(void) { }
> >
> > @@ -20,6 +24,10 @@ static inline void sched_clock_register(u64 (*read)(void), int bits,
> > unsigned long rate)
> > {
> > }
> > +
> > +static int sched_clock_suspend(void) { }
>
> static inline ...
>
> > +
> > +static void sched_clock_resume(void) { }
>
> Ditto
>
> > #endif
>
> Please do not expose this in the global header. All of this is local to
> kernel/time/. So adding this to kernel/time/timekeeping.h is sufficient.
Thanks so much for review and the suggestion, I'll fix it in next
version.
Thanks,
Chang-An
>
> Thanks,
>
> tglx
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-03-29 2:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1553497460-24166-1-git-send-email-chang-an.chen@mediatek.com>
2019-03-25 13:54 ` [PATCH 1/1] sched/clock: Prevent generic sched_clock wrap caused by tick_freeze() Thomas Gleixner
2019-03-29 2:30 ` Chang-An Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553826609.8188.0.camel@mtkswgap22 \
--to=chang-an.chen@mediatek.com \
--cc=cminyard@mvista.com \
--cc=fweisbec@gmail.com \
--cc=john.stultz@linaro.org \
--cc=keescook@chromium.org \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mingo@kernel.org \
--cc=pasha.tatashin@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=tglx@linutronix.de \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).