From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93CEEC43381 for ; Fri, 29 Mar 2019 02:30:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6048A21855 for ; Fri, 29 Mar 2019 02:30:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uw4C2QSK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6048A21855 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C6NT+jBdt+DcUI6s5cNZse8f5tj8lFjaIL8xbjgGx2A=; b=uw4C2QSKmappg5 uvT/ilJ22NBvaoLSBp8rFd2FEKNuKNUi9cgNtbuMYRnRbE1uLs9XIuxolHI2fQWpv6UEW3RH63oW9 bfK9sXIgLw0O64w8xrXS0EZi6vKrYHgqmqn5GuvapqUpbjoNsU/OGwLYzyC8rPvzY5QnFivNKEX1A q5V9ZO8Yxj2GuCyCGpTHiXoqrl1NJBQYgg2RM+dMES+KM282sMtZtMBlWQ8v+6N7GWjb006B2tZyg SdHpYkg9wTNF6pDSwDZje+Nj1rmn6SHqovBm6aRuqjnKuK0c5jY+FyA50Mo73EpZJLRGVAkQSZdRr EcNLyDRn1AyKKPMqcRUA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9hHh-00052C-Q6; Fri, 29 Mar 2019 02:30:21 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9hHd-0004il-8M; Fri, 29 Mar 2019 02:30:19 +0000 X-UUID: 6a239eccab434d7fb91b700ce63571e9-20190328 X-UUID: 6a239eccab434d7fb91b700ce63571e9-20190328 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1890766827; Thu, 28 Mar 2019 18:30:12 -0800 Received: from MTKMBS01DR.mediatek.inc (172.21.101.111) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 28 Mar 2019 19:30:11 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs01dr.mediatek.inc (172.21.101.111) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 29 Mar 2019 10:30:09 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 29 Mar 2019 10:30:08 +0800 Message-ID: <1553826609.8188.0.camel@mtkswgap22> Subject: Re: [PATCH 1/1] sched/clock: Prevent generic sched_clock wrap caused by tick_freeze() From: Chang-An Chen To: Thomas Gleixner Date: Fri, 29 Mar 2019 10:30:09 +0800 In-Reply-To: References: <1553497460-24166-1-git-send-email-chang-an.chen@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_193017_351770_08A7771A X-CRM114-Status: GOOD ( 12.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , Kees Cook , "wsd_upstream@mediatek.com" , Frederic Weisbecker , Kuohong Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=8B=E9=B4=BB=29?= , Pavel Tatashin , "linux-kernel@vger.kernel.org" , John Stultz , Matthias Brugger , "linux-mediatek@lists.infradead.org" , Stanley Chu =?UTF-8?Q?=28=E6=9C=B1=E5=8E=9F=E9=99=9E=29?= , Ingo Molnar , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2019-03-25 at 21:54 +0800, Thomas Gleixner wrote: > On Mon, 25 Mar 2019, Chang-An Chen wrote: > > --- a/include/linux/sched_clock.h > > +++ b/include/linux/sched_clock.h > > @@ -13,6 +13,10 @@ > > > > extern void sched_clock_register(u64 (*read)(void), int bits, > > unsigned long rate); > > + > > +extern int sched_clock_suspend(void); > > + > > +extern void sched_clock_resume(void); > > #else > > static inline void generic_sched_clock_init(void) { } > > > > @@ -20,6 +24,10 @@ static inline void sched_clock_register(u64 (*read)(void), int bits, > > unsigned long rate) > > { > > } > > + > > +static int sched_clock_suspend(void) { } > > static inline ... > > > + > > +static void sched_clock_resume(void) { } > > Ditto > > > #endif > > Please do not expose this in the global header. All of this is local to > kernel/time/. So adding this to kernel/time/timekeeping.h is sufficient. Thanks so much for review and the suggestion, I'll fix it in next version. Thanks, Chang-An > > Thanks, > > tglx > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel