public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: alexander.stein@systec-electronic.com (Alexander Stein)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/1] ARM: at91/dt: sam9x5: Add CAN device nodes
Date: Mon, 06 Oct 2014 17:57:04 +0200	[thread overview]
Message-ID: <1553953.Bxvx42RTxh@ws-stein> (raw)
In-Reply-To: <5432B637.1060200@atmel.com>

Hi Jean,

On Monday 06 October 2014 17:33:11, Nicolas Ferre wrote:
> On 06/10/2014 16:27, Alexander Stein :
> > Add the missing CAN devices node including their pin muxing and clocks.
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> > Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > ---
> > Changes in v3:
> > * Match the pin name to the ones in the datasheet.
> > 
> >  arch/arm/boot/dts/at91sam9x5.dtsi | 48 +++++++++++++++++++++++++++++++++++++++
> 
> Alexander,
> 
> In fact, we already have a placeholder for these nodes:
> arch/arm/boot/dts/at91sam9x5_can.dtsi
> 
> The file is only included in SoC device trees which actually contain
> this peripheral: at91sam9x25 and at91sam9x35 (and not the other variants
> of this family).

Actually, I can't find anyone including this :-/ If they would I guess I should have hit an error for duplicated labels.
Is this a mistake no-one includes at91sam9x5_can.dtsi?

> So, can you please move this addition above into the
> arch/arm/boot/dts/at91sam9x5_can.dtsi file?

Can you confirm that both (at91sam9x25 and at91sam9x35) have identical peripheral addresses, irq and pinmuxing?

Best regards,
Alexander
-- 
Dipl.-Inf. Alexander Stein

SYS TEC electronic GmbH
Am Windrad 2
08468 Heinsdorfergrund
Tel.: 03765 38600-1156
Fax: 03765 38600-4100
Email: alexander.stein at systec-electronic.com
Website: www.systec-electronic.com
 
Managing Director: Dipl.-Phys. Siegmar Schmidt
Commercial registry: Amtsgericht Chemnitz, HRB 28082

  reply	other threads:[~2014-10-06 15:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-06 14:27 [PATCH v3 1/1] ARM: at91/dt: sam9x5: Add CAN device nodes Alexander Stein
2014-10-06 15:33 ` Nicolas Ferre
2014-10-06 15:57   ` Alexander Stein [this message]
2014-10-07  7:54     ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1553953.Bxvx42RTxh@ws-stein \
    --to=alexander.stein@systec-electronic.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox