From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83D35C43381 for ; Sun, 31 Mar 2019 12:40:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5334220830 for ; Sun, 31 Mar 2019 12:40:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AcaxKBux" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5334220830 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gievAzVd5Ev6WdOwdeWktH7rvL/HM1I/qsdFgHaxlkw=; b=AcaxKBuxTw1TzJ f/U1fIQiVbYYbci2vCH+1Vp0lkH7Tb/g9QhMmgm925ukimthIwklWERs6JA6YyLX/Mi+YjE/IYi7k Y1ybF9LKz3G0VjQhPM0fwkRnLk8LJi+vw+7K6K9JU1Coss3+C8dBpissn7Jk2DxDQsjDFdkJKgq1U AIkRp4sZMbBeeD01kK5eGOmfVrvjWVnD5eAn/iJxocSeHSA+Oy75WMc/CkFq9BN0NgKYiUR37wvSj 7ReFbf+JCqlUXOISdMNv594Q/Ym5S/+nqTr1mIl+QPVFvytSIjFAfSggSq6EDH17llJOJNPFho64b 1335d/tT6MBDMA4b7Jhg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAZlA-0001KE-GF; Sun, 31 Mar 2019 12:40:24 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAZl7-0001Ji-1l; Sun, 31 Mar 2019 12:40:22 +0000 X-UUID: 2358c7eb493542d38dd7e2dafb6dc986-20190331 X-UUID: 2358c7eb493542d38dd7e2dafb6dc986-20190331 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 632245690; Sun, 31 Mar 2019 04:40:12 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 31 Mar 2019 05:40:11 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 31 Mar 2019 20:40:08 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sun, 31 Mar 2019 20:40:08 +0800 Message-ID: <1554036008.10179.174.camel@mhfsdcap03> Subject: Re: [PATCH] PCI: mediatek: get optional clock by devm_clk_get_optional() From: Chunfeng Yun To: Ryder Lee Date: Sun, 31 Mar 2019 20:40:08 +0800 In-Reply-To: <1554027049.21644.0.camel@mtkswgap22> References: <1553940051-10367-1-git-send-email-chunfeng.yun@mediatek.com> <1554027049.21644.0.camel@mtkswgap22> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190331_054021_097633_FAAFFB9C X-CRM114-Status: GOOD ( 13.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Brugger , linux-mediatek@lists.infradead.org, Honghui Zhang , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ryder, On Sun, 2019-03-31 at 18:10 +0800, Ryder Lee wrote: > On Sat, 2019-03-30 at 18:00 +0800, Chunfeng Yun wrote: > > Use devm_clk_get_optional() to get optional clock > > > > Signed-off-by: Chunfeng Yun > > --- > > drivers/pci/controller/pcie-mediatek.c | 46 ++++++-------------------- > > 1 file changed, 11 insertions(+), 35 deletions(-) > > > > diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c > > index 0b6c72804e03..9a66a018489b 100644 > > --- a/drivers/pci/controller/pcie-mediatek.c > > +++ b/drivers/pci/controller/pcie-mediatek.c > > @@ -915,49 +915,25 @@ static int mtk_pcie_parse_port(struct mtk_pcie *pcie, > > > > /* sys_ck might be divided into the following parts in some chips */ > > snprintf(name, sizeof(name), "ahb_ck%d", slot); > > - port->ahb_ck = devm_clk_get(dev, name); > > - if (IS_ERR(port->ahb_ck)) { > > - if (PTR_ERR(port->ahb_ck) == -EPROBE_DEFER) > > - return -EPROBE_DEFER; > > - > > - port->ahb_ck = NULL; > > - } > > + port->ahb_ck = devm_clk_get_optional(dev, name); > > + if (IS_ERR(port->ahb_ck)) > > + return PTR_ERR(port->ahb_ck); > > > > snprintf(name, sizeof(name), "axi_ck%d", slot); > > - port->axi_ck = devm_clk_get(dev, name); > > - if (IS_ERR(port->axi_ck)) { > > - if (PTR_ERR(port->axi_ck) == -EPROBE_DEFER) > > - return -EPROBE_DEFER; > > - > > - port->axi_ck = NULL; > > - } > > + port->axi_ck = devm_clk_get_optional(dev, name); > > + return PTR_ERR(port->axi_ck); > > > > snprintf(name, sizeof(name), "aux_ck%d", slot); > > - port->aux_ck = devm_clk_get(dev, name); > > - if (IS_ERR(port->aux_ck)) { > > - if (PTR_ERR(port->aux_ck) == -EPROBE_DEFER) > > - return -EPROBE_DEFER; > > - > > - port->aux_ck = NULL; > > - } > > + port->aux_ck = devm_clk_get_optional(dev, name); > > + return PTR_ERR(port->aux_ck); > > > > snprintf(name, sizeof(name), "obff_ck%d", slot); > > - port->obff_ck = devm_clk_get(dev, name); > > - if (IS_ERR(port->obff_ck)) { > > - if (PTR_ERR(port->obff_ck) == -EPROBE_DEFER) > > - return -EPROBE_DEFER; > > - > > - port->obff_ck = NULL; > > - } > > + port->obff_ck = devm_clk_get_optional(dev, name); > > + return PTR_ERR(port->obff_ck); > > > > snprintf(name, sizeof(name), "pipe_ck%d", slot); > > - port->pipe_ck = devm_clk_get(dev, name); > > - if (IS_ERR(port->pipe_ck)) { > > - if (PTR_ERR(port->pipe_ck) == -EPROBE_DEFER) > > - return -EPROBE_DEFER; > > - > > - port->pipe_ck = NULL; > > - } > > + port->pipe_ck = devm_clk_get_optional(dev, name); > > + return PTR_ERR(port->pipe_ck); > > > > snprintf(name, sizeof(name), "pcie-rst%d", slot); > > port->reset = devm_reset_control_get_optional_exclusive(dev, name); > > if (IS_ERR(...)) ? Very sorry for my stupid mistake:( will send new version > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel