From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2A9DC43381 for ; Mon, 1 Apr 2019 18:39:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1CBF206C0 for ; Mon, 1 Apr 2019 18:39:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kesPt3By" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1CBF206C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=i2se.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=jGA/I0XOpCPeEzpmovd6JGKLGYYJd8PpOBD34Ok/0Z0=; b=kes Pt3BycTtpf5YSexawOAJAGebzNyuzRQI0lNAjvnLcgaatWhJwzFbwSxGirL5ArbAY1BXxIUsqm+Ei FsF7DmdXhEZEvxWpdf2X9wy4DKwUuZuuvPSYTVySl+3rOOXU8HExKBqkbdpObAqmUc5d+JlMFOeZu uQm/T3fMhhon9cV7rW5mqs2ufluFudVfULSmXdeonIMmitmXekHWhYJYGJPHYGPuEAqIQ9s91YMYS /TRtGGL9F6uf1ALQzgUhkkMSDV4ai60GBDap8XXIwrSnqShFCbp5Wu/PZHBHx4m2jhKImFy8CVLOz zcsh45p1INGBHe5EpoLjBsK3yURWe6g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB1qX-0006xQ-Rw; Mon, 01 Apr 2019 18:39:49 +0000 Received: from mout.kundenserver.de ([212.227.126.135]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB1qT-0006wK-Tr; Mon, 01 Apr 2019 18:39:47 +0000 Received: from localhost.localdomain ([37.4.249.100]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MowT0-1gaKRn3DRO-00qSeG; Mon, 01 Apr 2019 20:39:17 +0200 From: Stefan Wahren To: Dan Williams , Vinod Koul , Florian Fainelli , Ray Jui , Scott Branden , Eric Anholt Subject: [PATCH RFC] dmaengine: bcm2835: Avoid GFP_KERNEL in device_prep_slave_sg Date: Mon, 1 Apr 2019 20:38:19 +0200 Message-Id: <1554143899-4124-1-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 2.7.4 X-Provags-ID: V03:K1:mPuCPaOFlRK9emN6HYhMhq/RXZiWSniPzHtXMLTwXmTOCAp9fX/ 5sNqVZ4TWNArj7g/VUv8qbqWmsbgySEa1rkAinniLkHZyorWO3aDLJAcagkJMiM88KTAai/ ONlu2vc999fNNKlttb1BRxVvJ10o15kLHvFB5OHTjbC6VXeMniM+S1vbT0/sClaYZRcofHm QUah5vXeCXNPU0mtJQ1wA== X-UI-Out-Filterresults: notjunk:1;V03:K0:zJtCSSXmp20=:Y+dRedSRaE8NRxxN+1t33D mmgMhEgw31CL8E7iLZPzhXuEprVhTEf8DgNL+huh5gHuz5guiTwRv2CJOC1MauU2rxSPxxRmt ldEhNKez/P2cNxtLbiFC9+kkQLgUOrtdcM/Q3mk9t2L8zhs9Uf2lBaShynCUoXswm7qKAXNJw 10ee4AE3N6CDyEOjolr5jeeoFktT8uoAal0kP1l8+X3Guq6brT7Ws6OZwAgQG9PJCZr+Bw9YK GIEa0O27wXQAYlicx78fY/y3YoG3Ao5xj/BgA2NxNuXoOxneU7u8p445fW+DXRxMu/KDkkxcz fUZuu0E6434EAkih+gnzBJ6x53Nhnb7Q7OMdJubCT4oZCp6BQAn7xCNxK6sndNeEx+OxVT0Ou k+C/P73oGn5t7bx08JZMcmeGHv5trHivybIHS34F4fFgsVpz8RxirenOHUI/F9r9VkPRuyJW0 AONCDdTF1GtXMwIKZPinbg7ILwlMeAmMgeXBJMOWatChuWYaO5rnm03ghgUf7YNBxl4CrgvXK mKfcDT9PWLI84g7WVEK1cIx+27dBETuZcKkq1gvSG4Lszs/l0CMgfEHQ6P3RZTRJjp/bfkMh5 lV+tZ3j7tmEUKtjzhDUjYkgul7V8KZ/Zft5O94R9fkC9qQ6g21BOo4vrI5c27GJZH5zJrKFP9 XU3C4HDQemF9picIuWeyXzLwMwnFsxJCvkzw8L3N8DeO+DSFCDcwjzaAT4U0dor1zQhsrcjUn 8MhW7A6bKHlXnh0Bxqn4lL93cHUXQVQ8Gzao+L8lF/ch8smk15whLQN9SWw= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_113946_257741_6EF67858 X-CRM114-Status: GOOD ( 14.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , Aaro Koskinen , Lukas Wunner , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, Martin Sperl , Florian Kauer , linux-rpi-kernel@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org The commit af19b7ce76ba ("mmc: bcm2835: Avoid possible races on data requests") introduces a possible circular locking dependency, which is triggered by swapping to the sdhost interface. So instead of reintroduce the race condition again, we could also avoid this situation by using GFP_NOWAIT for the allocation of the DMA buffer descriptors. Reported-by: Aaro Koskinen Signed-off-by: Stefan Wahren Fixes: af19b7ce76ba ("mmc: bcm2835: Avoid possible races on data requests") Link: http://lists.infradead.org/pipermail/linux-rpi-kernel/2019-March/008615.html --- drivers/dma/bcm2835-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c index ec8a291..54093ff 100644 --- a/drivers/dma/bcm2835-dma.c +++ b/drivers/dma/bcm2835-dma.c @@ -671,7 +671,7 @@ static struct dma_async_tx_descriptor *bcm2835_dma_prep_slave_sg( d = bcm2835_dma_create_cb_chain(chan, direction, false, info, extra, frames, src, dst, 0, 0, - GFP_KERNEL); + GFP_NOWAIT); if (!d) return NULL; -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel