From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06109C4360F for ; Tue, 2 Apr 2019 22:48:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C37712084B for ; Tue, 2 Apr 2019 22:48:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LQa0ax6k"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qy+CByoa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C37712084B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:To: Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H+RFMRRO5qyad1eljHmOScmZXtaCGsYseSb9K3jxZE8=; b=LQa0ax6kQ8VIAVqYjdAqfHLOC tLOZKoQaX+ckvcr1XL4JPP7s24DH8LOmZLVG5thCzahCj1Y9S9a66cmaIXh4rfJMiQJG6Mj3B0iZP r30Gd2iFm3u+c4O88wc3q1Nq3kxMQB2B9W8kyJXy4nColH6tZleEtTB9W3JNB+aAxnxs+tETllTIv uR7y0R3KADnY+xyyYr0UCdAjv5nCNK+/muSxjsGStf8szrwISBeurF+vncwmf7he5NTclphtdfod+ u0geOJjOByam2pSIce+4M9sj0HMHQ3Sy+mht23GA+QInOnWHZheCWts8Ua7scijZmqbpmhDw6UHDF TWJ/GBSdg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBSCg-0004I7-G9; Tue, 02 Apr 2019 22:48:26 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBSCe-0004Ho-B3 for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2019 22:48:25 +0000 Received: by mail-wr1-x42c.google.com with SMTP id q1so18706797wrp.0 for ; Tue, 02 Apr 2019 15:48:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=kjT+zU11EJ4z6Higb2Gj5XdIkww2cYf4jwrlt2RS3u0=; b=qy+CByoa4/M+HHrBfrWvgzY+mvoT+z0bROyLGaOkLEBL/ZBV0kJAlEMwggp6UHR+NP dAHJyvQs15SE8omCVgjQzW1t7TI746j3gxBochEHIen6BU3DRnE7iAoQWYpmYj/9yBYH dchNopf2RbRKqDsxlsYfUFkLyjQtDTaET339p22Tb8bMWJ6vbEZpfdIIxi5KZbNBRNbX BmdC0r0IYKwGr6eIqtj9pbqmJayp/wfZ86LrCltXfOzUDo/5942yAm34x13/bYJXLmwS BrNW/34XEoITGXCb6lvRuOIawcEbOtw4pVv71OzLI80m99kslL8T8lb/N511spitrVii cJ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=kjT+zU11EJ4z6Higb2Gj5XdIkww2cYf4jwrlt2RS3u0=; b=jpseNriGAQVcHZKKMMUtlpS33HfVIBIAnb/LtdgKLYX0K4I5aTCZWeb25XnEhsWBzX Upl/jDkUrGZWv6JUnUPNtJzy+vVe4XmCu2L1ACmdyyVfLiWzSU9fPwn7+wfGBVqzAAhd Yl8NWXTojQshPXQAgzkiD3mh72ZuUtObt+vSvvyP0FLe7yYaOAg6WY27J6S5arFunNQN WaGVQzgDsOalXvUFNSM3LLQ+O9eh2tHCAVVWFLl1LZ9oBPWF5zkWKTWhrxRKrKp8OUta Wm/t3Q6ouE0BjkhW88DVPHAqXndZmv97rGpAslce8b8XhZaUJf9LbzkSAjPNpfaIJ86l pO6g== X-Gm-Message-State: APjAAAXUJvCjGpvMQ9rxVUVTruO0td+XQ1OdJ6Q1As1MbBD6MRjnr5cm 8/dg91oLdHlC/E5a3+hSCP8= X-Google-Smtp-Source: APXvYqzCuvIgbjnLuCaJekXBlRBljErgYkgNcxTUfGL/8pKyJqA42SUK6Z/6STPH13WjDHROF52N9w== X-Received: by 2002:a5d:684e:: with SMTP id o14mr49358691wrw.138.1554245302163; Tue, 02 Apr 2019 15:48:22 -0700 (PDT) Received: from X555LD ([2a02:85f:510:b900:f279:59ff:fe0a:7f16]) by smtp.gmail.com with ESMTPSA id e9sm23432964wrp.35.2019.04.02.15.48.18 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 02 Apr 2019 15:48:21 -0700 (PDT) Date: Wed, 03 Apr 2019 01:48:16 +0300 From: "Leonidas P. Papadakos" Subject: Re: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices To: Robin Murphy Message-Id: <1554245296.1271.0@gmail.com> In-Reply-To: References: <20190401181840.31255-1-papadakospan@gmail.com> <9d65a22a-2288-dc53-0059-ec4a31424dd8@arm.com> <2312344.mOsv7YkeBG@diego> <9EC67532-2D43-4AAD-BFA7-8B6797067427@theobroma-systems.com> <78EB27739596EE489E55E81C33FEC33A0B421348@de02wembxa.internal.synopsys.com> <4a9839d6-3d90-4354-7b64-78d5c1126e99@arm.com> <78EB27739596EE489E55E81C33FEC33A0B423811@de02wembxa.internal.synopsys.com> X-Mailer: geary/3.32.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190402_154824_435417_A6804FFD X-CRM114-Status: UNSURE ( 7.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jose Abreu , Alexandre Torgue , netdev@vger.kernel.org, LKML , Christoph =?iso-8859-1?q?M=FCllner?= , Klaus Goger , Maxime Coquelin , Philipp Tomsich , Linux ARM , Heiko =?iso-8859-1?q?St=FCbner?= Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org I can confirm that snps,no-pbl-x8, currently set by uboot for the fdt basically fixes the tx-checksumming issue. I get 700~800 Mbps myself but that might come down to the setup. You could say it affects performance slightly, as I saw in a previous email. Without the setting The rate consistently drops to 0. ethtool reports tx-checksumming is on in both cases Pretty cool! Does that give you guys an idea on how to tackle it "officially"? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel