From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CCEAC4360F for ; Wed, 3 Apr 2019 00:30:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9ED92084A for ; Wed, 3 Apr 2019 00:30:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cN2ZPBfm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9ED92084A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Yh34T4oEtFnn5r/RHPY1CQO10wc12aBsxZg9JLDIcMM=; b=cN2ZPBfmg1rCp/ TilIc5BdKaJ2BrIR719NQZ/mFkokUqTR/IIgHyLUkBqkW3jHOxCyrvigldJvQ0aV+CRfUy4Jdo6mL NX3JQMKKLY+Uxsg4Wbpoq4TJ1HZ8hvJ63TtSjem3bANdO6Ua8RYLSABF9mVARYyz1mFUF2lrwf3bW URaGDy0M4mFiIoCXKRwW2x0m7yQsdH/s65bzb5t/f446sAdZ7D/UjdgnB5ZVclAoEm7Tdh1bhIvzq G3xCMCZ5wuoGkTGuT4J65DtgLhK8I/Z7ojrSgsEB+JEY/SwaTlLWx9oiNai0n52r72p6U1VuKvthx yg9FhQqQZ+ME/qXOky2Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBTnF-0003BW-1B; Wed, 03 Apr 2019 00:30:17 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBTnB-0003B8-6J; Wed, 03 Apr 2019 00:30:14 +0000 X-UUID: d75731400e2247ffb2cb6f5ded8809d3-20190402 X-UUID: d75731400e2247ffb2cb6f5ded8809d3-20190402 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1937986110; Tue, 02 Apr 2019 16:30:07 -0800 Received: from mtkmbs03n1.mediatek.inc (172.21.101.181) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 2 Apr 2019 17:30:06 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs03n1.mediatek.inc (172.21.101.181) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 3 Apr 2019 08:30:04 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 3 Apr 2019 08:30:04 +0800 Message-ID: <1554251404.30711.2.camel@mtksdccf07> Subject: Re: [PATCH v1] media: media_device_enum_links32: fix missing reserved field copy From: Jungo Lin To: Laurent Pinchart Date: Wed, 3 Apr 2019 08:30:04 +0800 In-Reply-To: <20190402113339.GT4805@pendragon.ideasonboard.com> References: <1554199444-16827-1-git-send-email-jungo.lin@mediatek.com> <20190402113339.GT4805@pendragon.ideasonboard.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190402_173013_240003_BC180A59 X-CRM114-Status: GOOD ( 19.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ryan.yu@mediatek.com, Jerry-ch.Chen@mediatek.com, laurent.pinchart+renesas@ideasonboard.com, Rynn.Wu@mediatek.com, frankie.chiu@mediatek.com, hans.verkuil@cisco.com, frederic.chen@mediatek.com, seraph.huang@mediatek.com, linux-media@vger.kernel.org, holmes.chiou@mediatek.com, sj.huang@mediatek.com, Jungo Lin , linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, Sean.Cheng@mediatek.com, srv_heupstream@mediatek.com, tfiga@chromium.org, yuzhao@chromium.org, christie.yu@mediatek.com, zwisler@chromium.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Laurent, On Tue, 2019-04-02 at 14:33 +0300, Laurent Pinchart wrote: > Hi Jungo, > > Thank you for the patch. > > On Tue, Apr 02, 2019 at 06:04:04PM +0800, Jungo Lin wrote: > > From: Jungo Lin > > > > In v4l2-compliance utility, test MEDIA_IOC_ENUM_ENTITIES > > will check whether reserved field of media_links_enum filled > > with zero. Reserved field is filled with zero in media_device_enum_links. > > > > However, for 32 bit program, the reserved field is missing > > copy from kernel space to user space in media_device_enum_links32 > > function. > > > > This patch copies reserved field of media_links_enum from kernel space > > to user space. > > > > Signed-off-by: Jungo Lin > > --- > > drivers/media/media-device.c | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c > > index b8ec886..f420829 100644 > > --- a/drivers/media/media-device.c > > +++ b/drivers/media/media-device.c > > @@ -502,6 +502,7 @@ static long media_device_enum_links32(struct media_device *mdev, > > { > > struct media_links_enum links; > > compat_uptr_t pads_ptr, links_ptr; > > + int ret; > > > > memset(&links, 0, sizeof(links)); > > > > @@ -513,7 +514,15 @@ static long media_device_enum_links32(struct media_device *mdev, > > links.pads = compat_ptr(pads_ptr); > > links.links = compat_ptr(links_ptr); > > > > - return media_device_enum_links(mdev, &links); > > + ret = media_device_enum_links(mdev, &links); > > + if (ret) > > + return ret; > > + > > + if (copy_to_user(ulinks->reserved, &links.reserved, > > + sizeof(links.reserved))) > > + return -EFAULT; > > I think it would be better to zero the reserved field here instead of > copying it, as we know it has to be zero. > Got it. We will revise the implementation and deliver the v2 patch. Thanks, Jungo > > + > > + return 0; > > } > > > > #define MEDIA_IOC_ENUM_LINKS32 _IOWR('|', 0x02, struct media_links_enum32) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel