From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F611C4360F for ; Wed, 3 Apr 2019 02:27:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12E272084C for ; Wed, 3 Apr 2019 02:27:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s5iz1Q+e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12E272084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d82F9F0Js3Y/pSLhszWn3mNS0Uu1jwDkND+KeRRFfTE=; b=s5iz1Q+eUuy7JE 9h7fE1DeuJYr9NEI9s5Uqw+qSlGcf2AAJoZHUEt98dBSKrbt+ivVADLn3AkNEspMejlBx6m9UBHPU V3O0tgEDxj7Us22OcTYtdviDqS+JqkL1qiKDrRfFZLQf6iV1V6qryOFaObNtY1YJdZGtWcqQO7kUd ftrHNszfDl6rSij/lKO4BX/dDH1YzyE2iir0HXqnYMSSN4CDDzfmpexcqZG6IcqSGwG1ZwNyiahcA JgmJXZziG3ookIhGgttUCsF9vtme6m8fXswapay0pXGetql4+M9BJeH+HliG/krJEJj/iiQtR4a4X b4IzsGUY9sjnnpwEj1uQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBVcN-0001cn-3f; Wed, 03 Apr 2019 02:27:11 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBVcI-0001bK-TZ; Wed, 03 Apr 2019 02:27:08 +0000 X-UUID: e6b77300f6134bebb7176b5beff7ad30-20190402 X-UUID: e6b77300f6134bebb7176b5beff7ad30-20190402 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 122745890; Tue, 02 Apr 2019 18:26:58 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 2 Apr 2019 19:26:56 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 3 Apr 2019 10:26:54 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 3 Apr 2019 10:26:54 +0800 Message-ID: <1554258414.11458.27.camel@mtksdccf07> Subject: Re: [RFC PATCH V0 5/7] dts: arm64: mt8183: Add FD nodes From: Jerry-ch Chen To: Rob Herring Date: Wed, 3 Apr 2019 10:26:54 +0800 In-Reply-To: <20190325215728.GA32712@bogus> References: <1550648893-42050-1-git-send-email-Jerry-Ch.chen@mediatek.com> <1550648893-42050-6-git-send-email-Jerry-Ch.chen@mediatek.com> <20190325215728.GA32712@bogus> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190402_192706_965150_1576A3BD X-CRM114-Status: GOOD ( 18.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Sean Cheng =?UTF-8?Q?=28=E9=84=AD=E6=98=87=E5=BC=98=29?= , "laurent.pinchart+renesas@ideasonboard.com" , Rynn Wu =?UTF-8?Q?=28=E5=90=B3=E8=82=B2=E6=81=A9=29?= , Christie Yu =?UTF-8?Q?=28=E6=B8=B8=E9=9B=85=E6=83=A0=29?= , srv_heupstream , Holmes Chiou =?UTF-8?Q?=28=E9=82=B1=E6=8C=BA=29?= , Jerry-ch.chen@mediatek.com, "tfiga@chromium.org" , Jungo Lin =?UTF-8?Q?=28=E6=9E=97=E6=98=8E=E4=BF=8A=29?= , Sj Huang =?UTF-8?Q?=28=E9=BB=83=E4=BF=A1=E7=92=8B=29?= , "yuzhao@chromium.org" , "hans.verkuil@cisco.com" , "zwisler@chromium.org" , Frederic Chen =?UTF-8?Q?=28=E9=99=B3=E4=BF=8A=E5=85=83=29?= , "matthias.bgg@gmail.com" , "linux-mediatek@lists.infradead.org" , "mchehab@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2019-03-26 at 05:57 +0800, Rob Herring wrote: > On Wed, Feb 20, 2019 at 03:48:11PM +0800, Jerry-ch Chen wrote: > > This patch adds nodes for Face Detection (FD) unit. FD is embedded > > in Mediatek SoCs and works with the co-processor to perform face > > detection on the input data and image and output detected face result. > > > > Signed-off-by: Jerry-ch Chen > > --- > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > index b3d8dfd..45c7e2f 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > @@ -440,6 +440,26 @@ > > #clock-cells = <1>; > > }; > > > > + fd_smem: fd_smem { > > + compatible = "mediatek,fd_smem"; > > + mediatek,larb = <&larb5>; > > + iommus = <&iommu M4U_PORT_CAM_IMGI>; > > This doesn't look like an actual h/w device... > Thank you for your comments. fd_smem is not an actual h/w device and it will not be used in the future. We are going to remove the fd smem driver and fd_smem node. > > + }; > > + > > + fd:fd@1502b000 { > > space after the : ^ will be fixed. > > + compatible = "mediatek,fd"; > > Should be SoC specific. > will be fixed as "mediatek, mt8183-fd". Thanks and Best Regards Jerry > > + mediatek,larb = <&larb5>; > > + mediatek,vpu = <&vpu>; > > + iommus = <&iommu M4U_PORT_CAM_FDVT_RP>, > > + <&iommu M4U_PORT_CAM_FDVT_WR>, > > + <&iommu M4U_PORT_CAM_FDVT_RB>; > > + reg = <0 0x1502b000 0 0x1000>; > > + interrupts = ; > > + clocks = <&imgsys CLK_IMG_FDVT>; > > + clock-names = "FD_CLK_IMG_FD"; > > + smem_device = <&fd_smem>; > > + }; > > + > > vdecsys: syscon@16000000 { > > compatible = "mediatek,mt8183-vdecsys", "syscon"; > > reg = <0 0x16000000 0 0x1000>; > > -- > > 1.9.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel