From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48587C4360F for ; Wed, 3 Apr 2019 15:56:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5BB4206DF for ; Wed, 3 Apr 2019 15:56:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SqJEOTPN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BJhEq3a9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5BB4206DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:To: Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Xx379yWX1uvqUJBt/OPGls7lHkaIFe2+2x3xWbOyj6Q=; b=SqJEOTPNddXdJ91OrJn/vHKNu zLA3j4OryVmXkZoaqE/4fHBOA/8m6OUsio/7MreRUotGnPb88b418tKKpVPNqKox/McVUPxpixJAM Rg0rBFKbwulQ4NrXJjHM8sqzYNvEk22Ha9airoXLMyYGDYPgEsb37Skk7W2qgMye+5kqUAFNjICrf CDymK6817QUpUwDIQk0qHJebrJaElw/s2HRycNkGw8lN+HvSrgBSz2CNtCxJQ8fVcZjp8K7H2Sxrx F2NOSQiYjkLw8Oeha2cTA4P56sh3W6Rz+XuqtdFWZCxnUM7ia6aex9317DIpm3KyCx4vnF35tgZ69 0xTh4A1Rg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBiFD-0006mV-2p; Wed, 03 Apr 2019 15:56:07 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBiF9-0006m7-6t for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2019 15:56:05 +0000 Received: by mail-wr1-x42d.google.com with SMTP id h4so22070751wre.7 for ; Wed, 03 Apr 2019 08:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=smtmugjUengH7o/rPhG39S10hJLY2XSkPxiSSe6Erv4=; b=BJhEq3a9s6peDPA8A8b7eAIlTvXiJCzn9b6pXYB54cYnhEiBXjsu3r+yUtD9ENs2qk joYTQqoM+4g4GVEjMvcHsFOLR42LxvjvmqkPY3oyREBWo+KIrqaoTm7uWhhgM6BtumQe 0Sp3hpJmATdfkMogCNy2nO1S8oKizlYltDfZrbwNssbMd1bo3P/Cmr1+ktj+RIb5g6a/ w8EHmc1ddjEEasVZuPrLP0K3D+gZmsyD6co8jw5Fvj97IUfvVJd4H/3OEpSCqK2I2aZe So/DddIfExjSIqQs0ja3/YVVxzKwAlp/aug5ANEXEFptliFgl/Zn4FK5kiJVPAuTDk0B CKow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=smtmugjUengH7o/rPhG39S10hJLY2XSkPxiSSe6Erv4=; b=coUDq7zImNinNA9HROO4JZNPc95QMVucIcMNXMFfG7/wYwUc193m4R5QbKjyv5X15D LcRg5RslyvyAbBj4VC80TbINBx2AIMfL70oiEYT24xBvKN2F3wOSWJBY+7JwIIiREpTL BdMWCtWR/7EHbn9ufD/Jl46CVOKAhAKpPGQsrBJklrguC6BJSnmYwMD7kvZQbZJ6obQg OHXJhdvUJJI1ly+ZeTjIVpXakW8TkchE3l0CEdJzohvEKPfP5r4S0D17mWjv4LKI/twh EJyeE8S5xExXJoY0HGJRwVNGugaUhmEd5l9+cHInNRWtC7HW3qnXwksmc/UOSnjZCzii cKHg== X-Gm-Message-State: APjAAAXlv9DZcdie8bjGK8aGjkfllIeGiY9osiKepv7UJibrx5VwMeie 4Zngk/TENICE9DSKNg/MZwI= X-Google-Smtp-Source: APXvYqyL0ZD/w1CWqRxenO+dr0r40z3Z+/L7bvrGS17cMu9aUCD5gt5LmJpq0LqajlkpNEHUOfpBeA== X-Received: by 2002:adf:e4c2:: with SMTP id v2mr232683wrm.124.1554306961636; Wed, 03 Apr 2019 08:56:01 -0700 (PDT) Received: from X555LD ([2a02:85f:510:b900:d5bf:dcd8:8640:a2fe]) by smtp.gmail.com with ESMTPSA id f128sm19406994wme.28.2019.04.03.08.55.56 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 03 Apr 2019 08:56:00 -0700 (PDT) Date: Wed, 03 Apr 2019 18:55:54 +0300 From: "Leonidas P. Papadakos" Subject: RE: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices To: Jose Abreu Message-Id: <1554306954.1328.1@gmail.com> In-Reply-To: <1554305721.1328.0@gmail.com> References: <20190401181840.31255-1-papadakospan@gmail.com> <9d65a22a-2288-dc53-0059-ec4a31424dd8@arm.com> <2312344.mOsv7YkeBG@diego> <9EC67532-2D43-4AAD-BFA7-8B6797067427@theobroma-systems.com> <78EB27739596EE489E55E81C33FEC33A0B421348@de02wembxa.internal.synopsys.com> <4a9839d6-3d90-4354-7b64-78d5c1126e99@arm.com> <78EB27739596EE489E55E81C33FEC33A0B423811@de02wembxa.internal.synopsys.com> <1554245296.1271.0@gmail.com> <78EB27739596EE489E55E81C33FEC33A0B4254A0@de02wembxa.internal.synopsys.com> <1554305721.1328.0@gmail.com> X-Mailer: geary/3.32.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190403_085603_923801_6C3743A6 X-CRM114-Status: UNSURE ( 7.44 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , netdev@vger.kernel.org, LKML , Christoph =?iso-8859-1?q?M=FCllner?= , Klaus Goger , Maxime Coquelin , Philipp Tomsich , Robin Murphy , Linux ARM , Heiko =?iso-8859-1?q?St=FCbner?= Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > If snps,no-pbl-x8 does indeed have a performace hit, should the > workaround be to > a) turn tx checksumming off or > b) snps,no-pbl-x8 set? > > I'll test to see the difference Update: It really seems like snps,no-pbl-x8 is the better option. So I say, replace snps,force_thresh_dma_mode with it. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel