From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B030EC10F11 for ; Sat, 13 Apr 2019 04:39:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7328C2084E for ; Sat, 13 Apr 2019 04:39:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="R5sX2zBq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7328C2084E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pdTh0DYbJxOoSV4FvaCHVz0eOmpVQTBHpxG84C9dxg8=; b=R5sX2zBq9k7oI4 k6ZIflzXokzeLdUH89LFB+2xPGfc7H/yRFPkGGAg4w1bkBIyLU7gODqLvfieFPqPqtkfIa2McwU8v F3OU6CEZriuafqFID+JchWFWoL9/JKrz94TltN89okLT3CruWHdg0ALvO63kM05An4FehyPK1mUKq iExZArHd5dvjLYyFG4B7VuESh7pIJb7wiS3+QezLviub35bZ/+Wyiez+pAn19m9GqSgiUIeSOq6NZ jlA3bBv+H5qmVY3K8NwTAtsokwltrLxglwIB6NVTzwmXMtl3IPBp++YvtBUNGJ4N7YThgX1fNwUY5 C4PQ1v8KJm9k4EHaM9RQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFAS6-0004uI-4Q; Sat, 13 Apr 2019 04:39:42 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFAS2-0004tw-6e; Sat, 13 Apr 2019 04:39:40 +0000 X-UUID: f35b0a405b66417d972b016cfbc7ea3b-20190412 X-UUID: f35b0a405b66417d972b016cfbc7ea3b-20190412 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 279492896; Fri, 12 Apr 2019 20:39:31 -0800 Received: from mtkmbs03n2.mediatek.inc (172.21.101.182) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 12 Apr 2019 21:39:29 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs03n2.mediatek.inc (172.21.101.182) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 13 Apr 2019 12:39:15 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sat, 13 Apr 2019 12:39:15 +0800 Message-ID: <1555130354.14109.5.camel@mtksdaap41> Subject: Re: [PATCH v2 2/4] opp: add API which get max freq by voltage From: andrew-sh.cheng To: Nicolas Boichat Date: Sat, 13 Apr 2019 12:39:14 +0800 In-Reply-To: References: <1553841972-19737-1-git-send-email-andrew-sh.cheng@mediatek.com> <1553841972-19737-3-git-send-email-andrew-sh.cheng@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: FD329778EF9354F7438D7EFA19E62C652045325D223A403771A78C2E0A2A66D32000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190412_213938_251797_A9DE1EE9 X-CRM114-Status: GOOD ( 22.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, srv_heupstream , linux-pm@vger.kernel.org, Viresh Kumar , "Rafael J. Wysocki" , lkml , Rob Herring , Chanwoo Choi , Kyungmin Park , MyungJoo Ham , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Fan Chen , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2019-04-03 at 12:32 +0800, Nicolas Boichat wrote: > On Fri, Mar 29, 2019 at 2:46 PM Andrew-sh.Cheng > wrote: > > > > This API will get voltage as input parameter. > > Search all opp items for the item which with max frequency, > > and the voltae is smaller than provided voltage. > > > > Signed-off-by: Andrew-sh.Cheng > > --- > > drivers/opp/core.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++ > > include/linux/pm_opp.h | 8 ++++++++ > > 2 files changed, 63 insertions(+) > > > > diff --git a/drivers/opp/core.c b/drivers/opp/core.c > > index 0420f7e..7323cd9 100644 > > --- a/drivers/opp/core.c > > +++ b/drivers/opp/core.c > > @@ -526,6 +526,61 @@ struct dev_pm_opp *dev_pm_opp_find_freq_floor(struct device *dev, > > } > > EXPORT_SYMBOL_GPL(dev_pm_opp_find_freq_floor); > > > > +/** > > + * dev_pm_opp_find_max_freq_by_volt() - Search for a opp with max freq > > + * under provided voltage > > + * @dev: device for which we do this operation > > + * @u_volt: provided voltage > > + * > > + * Search for the matching available OPP which provide voltage can support. > > + * > > + * Return: matching *opp, else returns ERR_PTR in case of error > > + * and should be handled using IS_ERR. > > + * Error return values can be: > > + * EINVAL: for bad pointer > > + * ERANGE: no match found for search > > + * ENODEV: if device not found in list of registered devices > > + * > > + * The callers are required to call dev_pm_opp_put() for the returned OPP after > > + * use. > > + */ > > +struct dev_pm_opp *dev_pm_opp_find_max_freq_by_volt(struct device *dev, > > + unsigned long u_volt) > > +{ > > + struct opp_table *opp_table; > > + struct dev_pm_opp *temp_opp, *opp = ERR_PTR(-ERANGE); > > + > > + if (!dev || !u_volt) { > > + dev_err(dev, "%s: Invalid argument volt=%d\n", __func__, > > + u_volt); > > u_volt is an unsigned long, so you should use %lu. > > drivers/opp/core.c:582:3: error: format '%d' expects argument of type > 'int', but argument 4 has type 'long unsigned int' [-Werror=format=] > chromeos-kernel-4_19-4.19.32-r271: dev_err(dev, "%s: Invalid > argument volt=%d\n", __func__, > chromeos-kernel-4_19-4.19.32-r271: ^ > Got it. I will fix this on next patch > > + return ERR_PTR(-EINVAL); > > + } > > + > > + opp_table = _find_opp_table(dev); > > + if (IS_ERR(opp_table)) > > + return ERR_CAST(opp_table); > > + > > + mutex_lock(&opp_table->lock); > > + > > + list_for_each_entry(temp_opp, &opp_table->opp_list, node) { > > + if (temp_opp->available) { > > + /* go to the next node, before choosing prev */ > > + if (temp_opp->supplies[0].u_volt > u_volt) > > + break; > > + opp = temp_opp; > > + } > > + } > > + > > + /* Increment the reference count of OPP */ > > + if (!IS_ERR(opp)) > > + dev_pm_opp_get(opp); > > + mutex_unlock(&opp_table->lock); > > + dev_pm_opp_put_opp_table(opp_table); > > + > > + return opp; > > +} > > +EXPORT_SYMBOL_GPL(dev_pm_opp_find_max_freq_by_volt); > > + > > static int _set_opp_voltage(struct device *dev, struct regulator *reg, > > struct dev_pm_opp_supply *supply) > > { > > diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h > > index 24c757a..57deef9 100644 > > --- a/include/linux/pm_opp.h > > +++ b/include/linux/pm_opp.h > > @@ -102,6 +102,8 @@ struct dev_pm_opp *dev_pm_opp_find_freq_exact(struct device *dev, > > > > struct dev_pm_opp *dev_pm_opp_find_freq_floor(struct device *dev, > > unsigned long *freq); > > +struct dev_pm_opp *dev_pm_opp_find_max_freq_by_volt(struct device *dev, > > + unsigned long u_volt); > > > > struct dev_pm_opp *dev_pm_opp_find_freq_ceil(struct device *dev, > > unsigned long *freq); > > @@ -207,6 +209,12 @@ static inline struct dev_pm_opp *dev_pm_opp_find_freq_floor(struct device *dev, > > return ERR_PTR(-ENOTSUPP); > > } > > > > +static inline struct dev_pm_opp *dev_pm_opp_find_max_freq_by_volt(struct device *dev, > > + unsigned long u_volt) > > +{ > > + return ERR_PTR(-ENOTSUPP); > > +} > > + > > static inline struct dev_pm_opp *dev_pm_opp_find_freq_ceil(struct device *dev, > > unsigned long *freq) > > { > > -- > > 1.8.1.1.dirty > > > > > > _______________________________________________ > > Linux-mediatek mailing list > > Linux-mediatek@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel