From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36EA3C10F11 for ; Sat, 13 Apr 2019 06:00:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECBCC2084D for ; Sat, 13 Apr 2019 06:00:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aQLpETWB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECBCC2084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=74XfDcZSBNKRIJosnrIwX1VgyRX8nKAXbtA9HX6Jg+I=; b=aQLpETWBwK/l0d UBOa9+LeIV+a0AcxPACSI2rsd8/lalf0ddXCgSGdx5VRjS5wpTgefNQrdpc/h4+/zu/f37Zh3MF42 vnOdBdrA+qeIzfyWOLWg9zpwnqKmaXpbb34EQBxbImFbSuVBdu/stAc0AZzK+F5lNpBrVYLCOtdWy Hp+t1pocs5YVDVDpY9C7SgS6/daf5KfbXTi1TP/icNM4nsJn7GI+JC9Z/nASvyt8ObzNdplRuoMC8 Arn0rV80SFBJBIIJbhgmXvgJ6vuP5jgTnb24pjzATCiBOfmrm/M3VD28xLWv7fdLiYcMZicpbPBBV w+g/UepHoAluPTrGx5EQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFBiE-0003PI-52; Sat, 13 Apr 2019 06:00:26 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFBi9-0003Oh-0d; Sat, 13 Apr 2019 06:00:23 +0000 X-UUID: f49d9d5e1869400e978d2df68092ed38-20190412 X-UUID: f49d9d5e1869400e978d2df68092ed38-20190412 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 801996694; Fri, 12 Apr 2019 22:00:08 -0800 Received: from mtkmbs03n1.mediatek.inc (172.21.101.181) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 12 Apr 2019 23:00:07 -0700 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs03n1.mediatek.inc (172.21.101.181) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 13 Apr 2019 14:00:05 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sat, 13 Apr 2019 14:00:05 +0800 Message-ID: <1555134868.14109.11.camel@mtksdaap41> Subject: Re: [PATCH v2 4/4] devfreq: add mediatek cci devfreq From: andrew-sh.cheng To: Date: Sat, 13 Apr 2019 13:54:28 +0800 In-Reply-To: <20190401041843epcms1p10a664023cf0556e42afe118a1d84daad@epcms1p1> References: <1553841972-19737-5-git-send-email-andrew-sh.cheng@mediatek.com> <1553841972-19737-1-git-send-email-andrew-sh.cheng@mediatek.com> <20190401041843epcms1p10a664023cf0556e42afe118a1d84daad@epcms1p1> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190412_230021_072538_9BEF3EBB X-CRM114-Status: GOOD ( 15.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , "srv_heupstream@mediatek.com" , "linux-pm@vger.kernel.org" , Viresh Kumar , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Chanwoo Choi , Kyungmin Park , Rob Herring , "linux-mediatek@lists.infradead.org" , Matthias Brugger , "fan.chen@mediatek.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2019-04-01 at 13:18 +0900, MyungJoo Ham wrote: > >This adds a devfreq driver for the Cache Coherent Interconnect (CCI) > >of the Mediatek MT8183. > > > >On the MT8183 the CCI is supplied by the same regulator as the LITTLE > >cores. The driver is notified when the regulator voltage changes > >(driven by cpufreq) and adjusts the CCI frequency to the maximum > >possible value. > > > >Signed-off-by: Andrew-sh.Cheng > >--- > > drivers/devfreq/Kconfig | 10 ++ > > drivers/devfreq/Makefile | 1 + > > drivers/devfreq/mt8183-cci-devfreq.c | 235 +++++++++++++++++++++++++++++++++++ > > 3 files changed, 246 insertions(+) > > create mode 100644 drivers/devfreq/mt8183-cci-devfreq.c > > > > 1. It appears that proc_reg_uV might be used before initialization. > It would be appropriate to initialize it at the probe function. In this governor, cci only change frequency after get notification. So it must set proc_reg_uV first, and then call update_devfreq() which call to mtk_cci_governor_get_target() and use proc_reg_uV. > > 2. Because you are already using OPP, why don't you rely on > OPP fully? (use OPP from CPUFreq drivers as well in order to get > OPP events automatically.) Anyway, this is a minor item that does > not need to be corrected. For some discuss about this in Mediatek before, we decide to put the operation of CCI in CCI related driver and separated from CPUFreq. > > Cheers > MyungJoo > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel