Re: [PATCH 01/14] [media] mtk-mipicsi: add mediatek mipicsi driver for mt2712

From: Stu Hsieh <stu.hsieh@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>
Cc: srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH 01/14] [media] mtk-mipicsi: add mediatek mipicsi driver for mt2712
Date: Tue, 16 Apr 2019 13:44:03 +0800	[thread overview]
Message-ID: <1555393443.9968.3.camel@mtksdccf07> (raw)
In-Reply-To: <1554790363.10331.1.camel@mtksdaap41>

Hi, CK:

On Tue, 2019-04-09 at 14:12 +0800, CK Hu wrote:
> Hi, Stu:
> 
> On Mon, 2019-04-08 at 19:54 +0800, Stu Hsieh wrote:
> > This patch add mediatek mipicsi driver for mt2712,
> > including probe function to get the value from device tree,
> > and register to v4l2 the host device.
> > 
> > Signed-off-by: Stu Hsieh <stu.hsieh@mediatek.com>
> > ---
> >  drivers/media/platform/mtk-mipicsi/Makefile   |   4 +
> >  .../media/platform/mtk-mipicsi/mtk_mipicsi.c  | 768 ++++++++++++++++++
> >  2 files changed, 772 insertions(+)
> >  create mode 100644 drivers/media/platform/mtk-mipicsi/Makefile
> >  create mode 100644 drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c
> > 
> 
> [snip]
> 
> > +
> > +static const struct of_device_id mtk_mipicsi_of_match[] = {
> > +	{ .compatible = "mediatek,mt2712-mipicsi", },
> 
> Where is the binding document of "mediatek,mt2712-mipicsi"?
> 
> Regards,
> CK
> 

I would add this bindind document in next version

Regards,
Stu

> > +	{},
> > +};
> > +
> > +static struct platform_driver mtk_mipicsi_driver = {
> > +	.driver		= {
> > +		.name	= MTK_MIPICSI_DRV_NAME,
> > +		.of_match_table = of_match_ptr(mtk_mipicsi_of_match),
> > +	},
> > +	.probe		= mtk_mipicsi_probe,
> > +	.remove		= mtk_mipicsi_remove,
> > +};
> > +
> > +module_platform_driver(mtk_mipicsi_driver);
> > +MODULE_DESCRIPTION("MediaTek SoC Camera Host driver");
> > +MODULE_LICENSE("GPL v2");
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel