From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDD3DC282DA for ; Fri, 19 Apr 2019 03:52:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9AB2C21736 for ; Fri, 19 Apr 2019 03:52:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HE+Bh4At" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9AB2C21736 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FgC8VLeTXO7tfcJQf5KL5vPE1z++5NRUt2ekSairiTI=; b=HE+Bh4AtmJhdR1 OLv9Ln/dcVBEijAKXfQ2oHkDANIKt5m1tIPKdzvA48RuagSXtD0ymW6vsMJoY8GAafFn1HGspAODv xzt6UopY9tYHHfa8V3Q8BgETfaSpHlqdnVN7WmsQq1xy0Z6KsP1V1KuXNFOwTZiAQh/489TGRr0Vj hlI06l4k2Pq6jL/MtHGmg0n9cheTKm3IOC5aEuIuMLE4jwN7maX9kTqljr25q70xIQvQuQr5i7u3f g7qKWTIswZ6BTeNSBnLoimx/lYzybm/i0uD8XsR3njE7YMVan0+27RljM66Dlnj+I8hAZSMm1TAQI tK5NkSuXJ+CJBIaMgIJw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHKZZ-0002V1-EK; Fri, 19 Apr 2019 03:52:21 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHKZV-0002Tl-4d; Fri, 19 Apr 2019 03:52:19 +0000 X-UUID: 95a8248ae48345e096cb69bcda10bc1d-20190418 X-UUID: 95a8248ae48345e096cb69bcda10bc1d-20190418 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 222771800; Thu, 18 Apr 2019 19:52:10 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 18 Apr 2019 20:52:09 -0700 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 19 Apr 2019 11:52:07 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 19 Apr 2019 11:52:07 +0800 Message-ID: <1555645927.24433.4.camel@mtksdaap41> Subject: Re: [PATCH v2 05/15] [media] mtk-mipicsi: get the w/h/bytepwerline for mtk_mipicsi From: CK Hu To: Stu Hsieh Date: Fri, 19 Apr 2019 11:52:07 +0800 In-Reply-To: <1555407015-18130-6-git-send-email-stu.hsieh@mediatek.com> References: <1555407015-18130-1-git-send-email-stu.hsieh@mediatek.com> <1555407015-18130-6-git-send-email-stu.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190418_205217_188012_A67A8271 X-CRM114-Status: GOOD ( 17.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Stu: On Tue, 2019-04-16 at 17:30 +0800, Stu Hsieh wrote: > This patch get the w/h/bytepwerline to save in mtk_mipicsi. > > Signed-off-by: Stu Hsieh > --- > .../media/platform/mtk-mipicsi/mtk_mipicsi.c | 39 +++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c b/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c > index 16f6bc480f4e..10782fccca79 100644 > --- a/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c > +++ b/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c > @@ -99,6 +99,9 @@ struct mtk_mipicsi_dev { > u32 id; > int clk_num; > struct clk *clk[MIPICSI_CLK]; > + u32 width; > + u32 height; > + u32 bytesperline; > }; > > #define MTK_MIPICSI_BUS_PARAM (V4L2_MBUS_MASTER | \ > @@ -110,13 +113,36 @@ struct mtk_mipicsi_dev { > V4L2_MBUS_PCLK_SAMPLE_FALLING | \ > V4L2_MBUS_DATA_ACTIVE_HIGH) > > +static u32 get_bytesperline(const u32 fmt, const u32 width) > +{ > + u32 bytesperline = 0; > + > + switch (fmt) { > + case MEDIA_BUS_FMT_UYVY8_2X8: > + case MEDIA_BUS_FMT_VYUY8_2X8: > + case MEDIA_BUS_FMT_YUYV8_2X8: > + case MEDIA_BUS_FMT_YVYU8_2X8: > + bytesperline = width * 2U; > + break; > + default: > + break; > + } > + > + return bytesperline; > +} > + > static int mtk_mipicsi_add_device(struct soc_camera_device *icd) > { > + struct soc_camera_host *ici = to_soc_camera_host(icd->parent); > + struct mtk_mipicsi_dev *mipicsi = ici->priv; > struct v4l2_subdev *sd = soc_camera_to_subdev(icd); > struct v4l2_subdev_format format = { > .which = V4L2_SUBDEV_FORMAT_ACTIVE, > }; > int ret; > + u32 width; > + u32 height; > + u32 fmt; > > /* Get width/height info from subdev. Then use them to set register */ > ret = v4l2_subdev_call(sd, pad, get_fmt, NULL, &format); > @@ -125,6 +151,19 @@ static int mtk_mipicsi_add_device(struct soc_camera_device *icd) > return ret; > } > > + width = format.format.width; > + height = format.format.height; > + fmt = format.format.code; > + mipicsi->bytesperline = get_bytesperline(fmt, width); > + if ((width == 0U) || (height == 0U) || (mipicsi->bytesperline == 0U)) { You could check more completely, for example, if the valid range of width is 1 ~ 4095, you could check as: #define WIDTH_MIN 1 #define WIDTH_MAX 4095 if ((width < WIDTH_MIN) || (width > WIDTH_MAX)) { /* invalid value */ } Regards, CK > + dev_err(icd->parent, "invalid sub device width/height/bytesperline %d/%d/%d\n", > + width, height, mipicsi->bytesperline); > + return -EINVAL; > + } > + > + mipicsi->width = width; > + mipicsi->height = height; > + > /* > * If power domain was closed before, it will be open. > * Then clock will be open and register will be set _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel