From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A01C282DA for ; Fri, 19 Apr 2019 08:44:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2677217F9 for ; Fri, 19 Apr 2019 08:44:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Zg36+tF8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2677217F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T9b76TI5QC2BTnbcucIbM7NA2dm2fj4xOah728HgCs8=; b=Zg36+tF8oosBgc FbUuCdKuF4aGqeTboU7tc0xpRoBPEAZzq1sXozjPBUvFHW5YaKVG2O69cAzGJlUF1x+k+29t7fzc4 JNtJY8i0nEZCmpnwvCgJDZUD03+mgCnGVPV1pYoT22pNCtSh8zHqnb7znEVsFpJ5MArLjj79a0wFv XrOCjke6tOsg78sCy7PbZ+C4zniKQ+380D68XOWj0RhxnzIMXJCPQKWNXfnoWa2XPEWEbjaeEHxyS 5WW+TXBkkrtxCxqCapB/KaTdOsrgA/wbnR7UkXvnz1blC6t/a+nGO3UBAx1BZLVaagKHX5mnz/g75 piiTxrvERgLqkXIr2q3w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHP7w-0001RI-I1; Fri, 19 Apr 2019 08:44:08 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHP7t-0001Qv-To; Fri, 19 Apr 2019 08:44:07 +0000 X-UUID: 2c3dc089583b4bc888f8308cb02f7364-20190419 X-UUID: 2c3dc089583b4bc888f8308cb02f7364-20190419 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 144242339; Fri, 19 Apr 2019 00:43:35 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 19 Apr 2019 01:43:33 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 19 Apr 2019 16:43:31 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 19 Apr 2019 16:43:30 +0800 Message-ID: <1555663410.10179.205.camel@mhfsdcap03> Subject: Re: [v3 PATCH 2/6] dt-bindings: usb: add binding for Type-B GPIO connector driver From: Chunfeng Yun To: Rob Herring Date: Fri, 19 Apr 2019 16:43:30 +0800 In-Reply-To: <1554257354-7440-3-git-send-email-chunfeng.yun@mediatek.com> References: <1554257354-7440-1-git-send-email-chunfeng.yun@mediatek.com> <1554257354-7440-3-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190419_014405_965094_164CA68C X-CRM114-Status: GOOD ( 17.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heikki Krogerus , Hans de Goede , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Badhri Jagan Sridharan , Andy Shevchenko , Alan Stern , Min Guo , Matthias Brugger , linux-mediatek@lists.infradead.org, Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, Gentle ping, could you please comment on this patch? Thanks a lot On Wed, 2019-04-03 at 10:09 +0800, Chunfeng Yun wrote: > It's used to support dual role switch via GPIO when use Type-B > receptacle, typically the USB ID pin is connected to an input > GPIO pin > > Signed-off-by: Chunfeng Yun > --- > v3 changes: > 1. treat type-B connector as a virtual device, but not child device of > USB controller's > > v2 changes: > 1. new patch to make binding clear suggested by Hans > --- > .../bindings/usb/typeb-conn-gpio.txt | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/typeb-conn-gpio.txt > > diff --git a/Documentation/devicetree/bindings/usb/typeb-conn-gpio.txt b/Documentation/devicetree/bindings/usb/typeb-conn-gpio.txt > new file mode 100644 > index 000000000000..d2e1c4e01b6d > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/typeb-conn-gpio.txt > @@ -0,0 +1,49 @@ > +USB Type-B GPIO Connector > + > +This is a virtual device used to switch dual role mode from the USB ID pin > +connected to an input GPIO pin. > + > +Required properties: > +- compatible : Should be "linux,typeb-conn-gpio" > + > +Sub-nodes: > +- connector : should be present. > + - compatible : should be "usb-b-connector". > + - id-gpios, vbus-gpios : either one of them must be present, > + and both can be present as well. > + - vbus-supply : can be present if needed when supports dual role mode. > + see connector/usb-connector.txt > + > +- port : should be present. > + see graph.txt > + > +Example: > + > +rsw_iddig: role_sw_iddig { > + compatible = "linux,typeb-conn-gpio"; > + status = "okay"; > + > + connector { > + compatible = "usb-b-connector"; > + label = "micro-USB"; > + type = "micro"; > + id-gpios = <&pio 12 GPIO_ACTIVE_HIGH>; > + vbus-supply = <&usb_p0_vbus>; > + }; > + > + port { > + bconn_ep: endpoint@0 { > + remote-endpoint = <&usb_role_sw>; > + }; > + }; > +}; > + > +&mtu3 { > + status = "okay"; > + > + port { > + usb_role_sw: endpoint@0 { > + remote-endpoint = <&bconn_ep>; > + }; > + }; > +}; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel