From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 340C7C43218 for ; Sun, 28 Apr 2019 12:16:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 053092075D for ; Sun, 28 Apr 2019 12:16:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k0+qgg+m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 053092075D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pCkelv9gmFeYMyWZA4yAqlP4me5ng8hCsP1T7VXxb7A=; b=k0+qgg+mKyvq6e VC5QgK46Ni2dPJ4tFQpslhIlcAeNtVNwRbskpj/YQnqnWZq0O+JX54ffRL4TKmB2YjHSEOuHDl/Bf pMY10ZJEayZ71gTQubZvpNmgw9y5fT/6/O2YoaywkrWp0NPKMyGp6CnqZ+HW4e9jsrRwZHgMS2sP2 LWlDCdZfb1S/fs6pZ9KSKCRXGdqiO3xzmJ/rC11GUm+rf/xipUzcuIvuz0iOEK5/1lmfDN7g6aa7n E+slcTW13VqY0vyRb5GL1MDzV4radsu/zh9HQ3VpZAca/NldI59zFQVaG7cQoUIgXYZ9iIo0kMxY+ Zo8suRuVtJA4bY/HQvAA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hKijc-0007lu-4z; Sun, 28 Apr 2019 12:16:44 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hKijY-0007lK-8p; Sun, 28 Apr 2019 12:16:42 +0000 X-UUID: 1365c26b1f17430cbfdf6a906d9253da-20190428 X-UUID: 1365c26b1f17430cbfdf6a906d9253da-20190428 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 13568862; Sun, 28 Apr 2019 04:16:33 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 28 Apr 2019 05:16:32 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 28 Apr 2019 20:16:29 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sun, 28 Apr 2019 20:16:28 +0800 Message-ID: <1556453788.10179.224.camel@mhfsdcap03> Subject: Re: [PATCH v4 3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch From: Chunfeng Yun To: Rob Herring Date: Sun, 28 Apr 2019 20:16:28 +0800 In-Reply-To: <20190426204906.GB15074@bogus> References: <1556261237-13823-1-git-send-email-chunfeng.yun@mediatek.com> <1556261237-13823-4-git-send-email-chunfeng.yun@mediatek.com> <20190426204906.GB15074@bogus> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190428_051640_321406_015B8067 X-CRM114-Status: GOOD ( 24.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heikki Krogerus , Hans de Goede , Greg Kroah-Hartman , Linus Walleij , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das , Badhri Jagan Sridharan , Andy Shevchenko , linux-mediatek@lists.infradead.org, Min Guo , Matthias Brugger , Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2019-04-26 at 15:49 -0500, Rob Herring wrote: > On Fri, Apr 26, 2019 at 02:47:14PM +0800, Chunfeng Yun wrote: > > Now the USB Role Switch is supported, so add properties about it > > > > Signed-off-by: Chunfeng Yun > > --- > > v4: no changes > > v3: no changes > > > > v2 changes: > > 1. fix typo > > 2. refer new binding about connector property > > --- > > .../devicetree/bindings/usb/mediatek,mtu3.txt | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > > index 3382b5cb471d..6e004c4a89af 100644 > > --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > > @@ -27,7 +27,9 @@ Optional properties: > > - ranges : allows valid 1:1 translation between child's address space and > > parent's address space > > - extcon : external connector for vbus and idpin changes detection, needed > > - when supports dual-role mode. > > + when supports dual-role mode; it's consiedered valid for compatibility > > + reasons, and not allowed for new bindings, use the property > > + usb-role-switch instead. > > - vbus-supply : reference to the VBUS regulator, needed when supports > > dual-role mode. > > - pinctrl-names : a pinctrl state named "default" is optional, and need be > > @@ -36,7 +38,8 @@ Optional properties: > > is not set. > > - pinctrl-0 : pin control group > > See: Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > > - > > + - usb-role-switch : use USB Role Switch to support dual-role switch, but > > + not extcon > > Coordinate with the Renesas and HiSilicon folks implementing the same > thing and put this in a common spot. I'll prepare a patch for it, and CC Biju and Yu > However, I think this should not > even be needed as knowing the controller capabilities (based on the > compatible) and knowing the type of connector should be enough > information to tell you if dual role is supported or not. Some Dual-Role controller drivers already used extcon framework to handle role switch, if try to support the new USB Role Switch framework, the driver may want to know which way will be used. Sometimes users also want to use dual-role even use the type-A, such as use sys interface to handle role switch, so only knowing the connector type can't tell driver which way to use > > > - maximum-speed : valid arguments are "super-speed", "high-speed" and > > "full-speed"; refer to usb/generic.txt > > - enable-manual-drd : supports manual dual-role switch via debugfs; usually > > @@ -61,6 +64,9 @@ The xhci should be added as subnode to mtu3 as shown in the following example > > if host mode is enabled. The DT binding details of xhci can be found in: > > Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > > > > +The port would be added as subnode if use usb-role-switch property > > + see graph.txt > > + > > Example: > > ssusb: usb@11271000 { > > compatible = "mediatek,mt8173-mtu3"; > > -- > > 2.21.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel