From: biao huang <biao.huang@mediatek.com>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: "jianguo.zhang@mediatek.com" <jianguo.zhang@mediatek.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"yt.shen@mediatek.com" <yt.shen@mediatek.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 1/2] net-next: stmmac: add support for hash table size 128/256 in dwmac4
Date: Tue, 30 Apr 2019 16:59:23 +0800 [thread overview]
Message-ID: <1556614763.24897.34.camel@mhfsdcap03> (raw)
In-Reply-To: <78EB27739596EE489E55E81C33FEC33A0B46DE20@DE02WEMBXB.internal.synopsys.com>
On Mon, 2019-04-29 at 09:00 +0000, Jose Abreu wrote:
> From: Biao Huang <biao.huang@mediatek.com>
> Date: Mon, Apr 29, 2019 at 07:35:23
>
> > +#define GMAC_HASH_TAB(x) (0x10 + x * 4)
>
> You need to guard x here with parenthesis.
>
> > void __iomem *ioaddr = (void __iomem *)dev->base_addr;
> > - unsigned int value = 0;
> > + unsigned int value;
> > + int i;
> > + int numhashregs = (hw->multicast_filter_bins >> 5);
> > + int mcbitslog2 = hw->mcast_bits_log2;
>
> Reverse Christmas tree order here please.
OK.
>
> Thanks,
> Jose Miguel Abreu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-30 8:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 6:35 [PATCH 0/2] net-next: stmmac: add some features in stmmac driver Biao Huang
2019-04-29 6:35 ` [PATCH 1/2] net-next: stmmac: add support for hash table size 128/256 in dwmac4 Biao Huang
2019-04-29 9:00 ` Jose Abreu
2019-04-30 8:59 ` biao huang [this message]
2019-04-29 6:35 ` [PATCH 2/2] net-next: stmmac: add mdio clause 45 access from mac device for dwmac4 Biao Huang
2019-04-29 15:03 ` Jose Abreu
2019-04-29 15:15 ` Ong, Boon Leong
2019-04-29 15:19 ` Jose Abreu
2019-04-29 15:23 ` Ong, Boon Leong
2019-04-30 8:58 ` biao huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556614763.24897.34.camel@mhfsdcap03 \
--to=biao.huang@mediatek.com \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=jianguo.zhang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=yt.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox