From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4B9BC46460 for ; Tue, 7 May 2019 13:53:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7A5120825 for ; Tue, 7 May 2019 13:53:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Aay3fmu8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7A5120825 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TZoT4O35DfIqPX45jMoDd1v+g+W8algDK3FpFlaZT0g=; b=Aay3fmu8NSMJYi 2p8F1fSosHou7HCh6bpMBJLQa20KhXcnY2vy/Mpp23rNi4L28PrcBouhjOpXeCNtqmpVebXPzHztv mM38FhNldsQWR03EhKlbbcKIPRSJk5eA5MXGR6I97KNM5QmtmJJsrD8Kf7QRkOGSZ/j2I4Tkvzw+5 rxf6P0NkBoqjMHrkm9gxmsOF9LtnCQt9+B7fNuIycXS/gYpiMXY3fLjH2J//Lxi+Jo/BSxQGY6Z1X 2VnLKxhqgdUQoI4LO2DQi7k6cqorn17jnUZFQouG7NPpRgikf/JeagIbmB7fIno+kX1l+K/BM4XKK uedEbkURnbAgz5uYO0yg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hO0X6-0003gJ-Ma; Tue, 07 May 2019 13:53:24 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hO0WT-0002s0-D8; Tue, 07 May 2019 13:52:50 +0000 X-UUID: 77d3e3e491b24779b1a7513bffe9917d-20190507 X-UUID: 77d3e3e491b24779b1a7513bffe9917d-20190507 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1932755384; Tue, 07 May 2019 05:52:34 -0800 Received: from mtkmbs03n2.mediatek.inc (172.21.101.182) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 7 May 2019 06:52:33 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs03n2.mediatek.inc (172.21.101.182) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 7 May 2019 21:52:30 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 7 May 2019 21:52:30 +0800 Message-ID: <1557237150.11458.45.camel@mtksdccf07> Subject: Re: [RFC PATCH V1 3/6] dt-bindings: mt8183: Added FD dt-bindings From: Jerry-ch Chen To: Rob Herring Date: Tue, 7 May 2019 21:52:30 +0800 In-Reply-To: <20190501224647.GA12044@bogus> References: <20190423104505.38778-1-Jerry-Ch.chen@mediatek.com> <20190423104505.38778-4-Jerry-Ch.chen@mediatek.com> <20190501224647.GA12044@bogus> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: 208F602F23B4135D007ECC86C99CD3A7F4CB67645D09D8B5C4AFEE51EBC031A52000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190507_065245_915788_D9EAE426 X-CRM114-Status: GOOD ( 19.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent.pinchart+renesas@ideasonboard.com, Rynn.Wu@mediatek.com, suleiman@chromium.org, jerry-ch.chen@mediatek.com, jungo.lin@mediatek.com, hans.verkuil@cisco.com, frederic.chen@mediatek.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, holmes.chiou@mediatek.com, shik@chromium.org, yuzhao@chromium.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, Sean.Cheng@mediatek.com, srv_heupstream@mediatek.com, sj.huang@mediatek.com, tfiga@chromium.org, christie.yu@mediatek.com, zwisler@chromium.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, Thank you for your comments. On Wed, 2019-05-01 at 17:46 -0500, Rob Herring wrote: > On Tue, Apr 23, 2019 at 06:45:02PM +0800, Jerry-ch Chen wrote: > > From: Jerry-ch Chen > > > > This patch adds DT binding documentation for the Face Detection (FD) > > unit of the camera system on Mediatek's SoCs. > > > > Signed-off-by: Jerry-ch Chen > > --- > > .../bindings/media/mediatek,mt8183-fd.txt | 34 +++++++++++++++++++ > > 1 file changed, 34 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8183-fd.txt > > > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8183-fd.txt b/Documentation/devicetree/bindings/media/mediatek,mt8183-fd.txt > > new file mode 100644 > > index 000000000000..97c12fd93e7e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/mediatek,mt8183-fd.txt > > @@ -0,0 +1,34 @@ > > +* Mediatek Face Detection Unit (FD) > > + > > +Face Detection (FD) unit is a typical memory-to-memory HW device. > > +It provides hardware accelerated face detection function, and it > > +is able to detect different poses of faces. FD will writre result > > +of detected face into memory as output. > > + > > +Required properties: > > +- compatible: "mediatek,mt8183-fd" > > +- reg: Physical base address and length of the function block register space > > +- interrupts: interrupt number to the cpu. > > +- iommus: should point to the respective IOMMU block with master port as > > + argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > > + for details. > > How many entries? Looks like 3 from the example. > Yes, we have 3 entries. I would like to update this part as following: iommus: should point to the 3 entries: M4U_PORT_CAM_FDVT_RP, M4U_PORT_CAM_FDVT_WR and M4U_PORT_CAM_FDVT_RB. (Please see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt for details.) > > +- mediatek,larb: must contain the local arbiters in the current Socs, see > > + Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt > > + for details. > > +- clocks : must contain the FDVT clock > > +- clock-names: must contain FD_CLK_IMG_FD > > + > > +Example: > > + fd:fd@1502b000 { > ^ space needed > We will fix it in next version of the patch. > > + compatible = "mediatek,mt8183-fd"; > > + mediatek,larb = <&larb5>; > > + mediatek,scp = <&scp>; > > + iommus = <&iommu M4U_PORT_CAM_FDVT_RP>, > > + <&iommu M4U_PORT_CAM_FDVT_WR>, > > + <&iommu M4U_PORT_CAM_FDVT_RB>; > > + reg = <0 0x1502b000 0 0x1000>; > > + interrupts = ; > > + clocks = <&imgsys CLK_IMG_FDVT>; > > + clock-names = "FD_CLK_IMG_FD"; > > + }; > > + > > -- > > 2.18.0 > > Sincerely, Jerry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel