From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, T_DKIMWL_WL_HIGH,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EA95C04A6B for ; Wed, 8 May 2019 06:27:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E415621019 for ; Wed, 8 May 2019 06:27:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="W7eLupNH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E415621019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O2jm29g8KSkNUJX+OalEh3ADcHPylusM64OkLYk8srI=; b=W7eLupNHI2gFfa Vtpu2In9cpGb2Z2MK3fZagJXlU02QavrFuffAqUxEIr7Z6vVjdjPtci3MGbwDS4HlWA9NpteOELr7 DSJVI8IruUeGSfOasM3MbcW+RxNlohdN2gtbexMJL2LyrJutwwxWGt7ZRkCCisfD/PCsig0du/lQK iXW5nXtF3ydgU0KpwbqsrkU3aG1ofg6sSmtRLSqJORePPQdKTfbBwapm8BYHwQBLpYCwzf9VEpuR7 xOmhjXeZhpAmY2vVGL9Unz0QcTI2+ZdZrOmDCY+XVdJTjQ/Z3fdZGxMDCeTIQw2mRoXOCUVy8KM9g Vjb2aEHhZHkfFRVz1dHw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hOG2h-00068V-9F; Wed, 08 May 2019 06:27:03 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hOG2d-00066z-Vy; Wed, 08 May 2019 06:27:01 +0000 X-UUID: 89e8c9e1f30f4ac0aa992c8bfd10e845-20190507 X-UUID: 89e8c9e1f30f4ac0aa992c8bfd10e845-20190507 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 222943960; Tue, 07 May 2019 22:26:47 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 7 May 2019 23:26:46 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 8 May 2019 14:26:43 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 8 May 2019 14:26:42 +0800 Message-ID: <1557296802.10179.272.camel@mhfsdcap03> Subject: Re: [v2 PATCH] dt-binding: usb: add usb-role-switch property From: Chunfeng Yun To: Heikki Krogerus Date: Wed, 8 May 2019 14:26:42 +0800 In-Reply-To: <20190507141305.GA19816@kuha.fi.intel.com> References: <38ff51264e971d5c58940c8435b9d8d274662d50.1557195204.git.chunfeng.yun@mediatek.com> <20190507141305.GA19816@kuha.fi.intel.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190507_232700_027013_CC3ED2A8 X-CRM114-Status: GOOD ( 17.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Yu Chen , linux-kernel@vger.kernel.org, Biju Das , Rob Herring , linux-mediatek@lists.infradead.org, Min Guo , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2019-05-07 at 17:13 +0300, Heikki Krogerus wrote: > On Tue, May 07, 2019 at 10:22:58AM +0800, Chunfeng Yun wrote: > > diff --git a/Documentation/devicetree/bindings/usb/generic.txt b/Documentation/devicetree/bindings/usb/generic.txt > > index 0a74ab8dfdc2..f5a6ad053ecc 100644 > > --- a/Documentation/devicetree/bindings/usb/generic.txt > > +++ b/Documentation/devicetree/bindings/usb/generic.txt > > @@ -30,6 +30,11 @@ Optional properties: > > optional for OTG device. > > - adp-disable: tells OTG controllers we want to disable OTG ADP, ADP is > > optional for OTG device. > > + - usb-role-switch: tells Dual-Role USB controllers we want to handle the role > > + switch between host and device according to the state > > + detected by the USB connector, typically for Type-C, > > + Type-B(micro). > > + see connector/usb-connector.txt. > > That does not look correct to me. Firstly, USB role switches are not > always dual-role USB controllers. Thanks for review, I look through some drivers, you are right, some phys also switch the roles. > Secondly, stating what determines > the role irrelevant IMO. > > Since this is a boolean property, the description for it should simply > explain what does it tell about the capabilities of the device that > has it. The description should not make any assumptions about the > users of the property, and since the property is a "generic" USB > property, I'm not sure it should make any assumptions about the type > of the device that has the property either. Also, I would really like > the description to show the type of the property. Ok I'll add it. > > Why not just say something like this: > > "Boolean property informing that the device is capable of assigning > the USB data role (USB host or USB device) for a given USB connector." will modify it. > > > thanks, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel