From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 039E6C04A6B for ; Fri, 10 May 2019 03:28:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEAF82084A for ; Fri, 10 May 2019 03:28:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FY7c3CPV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEAF82084A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FnAnkfYUDKnsfdNl9IcgWuS7uLV57u3MWpjMgKOHP30=; b=FY7c3CPVJx+go2 K/jpYlleZJJ4WKyzYVprnXWo34foEs9rfOLWzr0C+E79rnhIovVhf4u2hM79+FPC7uC9a7ishn3Pd SawVV3D717DRLAu6fM7QR48DZDv293KlBm006wo8N9HSc8Zyb5nzQLZracX6bSZy5l5tPfqN0nwNX aqlhrzVWhSt1/1EhJt9Y8Zcx3+rSjOkS4/MRkhK3STY+ifSyOzTBFxUr7EhkCHBLEDlanBkrGRyJb 9DAsOM4dPREzPh4XcneG0Z2WJWrS8as+LKMx5805cTbAO292Wru+GwIMiu2aNsRqnz9Tqtp8+Gq0w LHbEuZy16D/9PObXddvA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hOwCR-0002rj-Fp; Fri, 10 May 2019 03:27:55 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hOwCO-0002rD-Mk; Fri, 10 May 2019 03:27:54 +0000 X-UUID: 6dc56d056f5a4a86b838564006c5656b-20190509 X-UUID: 6dc56d056f5a4a86b838564006c5656b-20190509 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1445554380; Thu, 09 May 2019 19:27:40 -0800 Received: from mtkmbs03n2.mediatek.inc (172.21.101.182) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 9 May 2019 20:27:39 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs03n2.mediatek.inc (172.21.101.182) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 10 May 2019 11:27:37 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 10 May 2019 11:27:37 +0800 Message-ID: <1557458857.29102.1.camel@mtksdaap41> Subject: Re: [PATCH v5 04/12] dt-binding: gce: add binding for gce event property From: Bibby Hsieh To: CK Hu Date: Fri, 10 May 2019 11:27:37 +0800 In-Reply-To: <1557292247.3936.5.camel@mtksdaap41> References: <20190507081355.52630-1-bibby.hsieh@mediatek.com> <20190507081355.52630-5-bibby.hsieh@mediatek.com> <1557292247.3936.5.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 98BB702262903B75266ED8544CC84F00670BF243D4343F61910C1BCF47204AAE2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190509_202752_749862_25853371 X-CRM114-Status: GOOD ( 18.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , Philipp Zabel , srv_heupstream@mediatek.com, kendrick.hsu@mediatek.com, Daoyuan Huang , Sascha Hauer , Jassi Brar , linux-kernel@vger.kernel.org, Daniel Kurtz , Dennis-YC Hsieh , YT Shen , Rob Herring , linux-mediatek@lists.infradead.org, Houlong Wei , Sascha Hauer , Matthias Brugger , Jiaguang Zhang , Frederic Chen , linux-arm-kernel@lists.infradead.org, ginny.chen@mediatek.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, CK, On Wed, 2019-05-08 at 13:10 +0800, CK Hu wrote: > Hi, Bibby: > > On Tue, 2019-05-07 at 16:13 +0800, Bibby Hsieh wrote: > > Client hardware would send event to GCE hardware, > > mediatek,gce-event-names and mediatek,gce-events > > can be used to present the event. > > > > Signed-off-by: Bibby Hsieh > > --- > > Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > > index 8fd9479bc9f6..76491f194c56 100644 > > --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > > +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > > @@ -35,6 +35,9 @@ Required properties for a client device: > > Optional propertier for a client device: > > - mediatek,gce-client-reg: u32, specify the sub-system id which is corresponding > > to the register address. > > +- mediatek,gce-event-names: the event name can be defined by user. > > gce-event is like an interrupt from client hardware to GCE hardware, we > do not give a name to an interrupt, so do we need to give a name for > gce-event? > Yes, we need to know the name of gce-ecent. The name can help users to figure out the problems when GCE meet the event time out errors. > Regards, > CK > > > +- mediatek,gce-events: u32, the event number defined in > > + 'dt-bindings/gce/mt8173-gce.h' or 'dt-binding/gce/mt8183-gce.h'. > > > > Some vaules of properties are defined in 'dt-bindings/gce/mt8173-gce.h' > > or 'dt-binding/gce/mt8183-gce.h'. Such as sub-system ids, thread priority, event ids. > > @@ -57,8 +60,10 @@ Example for a client device: > > compatible = "mediatek,mt8173-mmsys"; > > mboxes = <&gce 0 CMDQ_THR_PRIO_LOWEST 1>, > > <&gce 1 CMDQ_THR_PRIO_LOWEST 1>; > > - mutex-event-eof = > - CMDQ_EVENT_MUTEX1_STREAM_EOF>; > > + mediatek,gce-event-names = "rdma0_sof", > > + "rsz0_sof"; > > + mediatek,gce-events = , > > + ; > > mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x3000 0x1000>, > > <&gce SUBSYS_1401XXXX 0x2000 0x100>; > > ... > > -- Bibby _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel