From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7A29C04AB4 for ; Sun, 19 May 2019 09:37:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9AF4A21726 for ; Sun, 19 May 2019 09:37:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iVSpyfcu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9AF4A21726 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RdYFAz9NL8Qe/lScj7Pb2w4sn5xg0lpvudlDvo7hSG0=; b=iVSpyfcuvSalza yA/fqrfSrLvM3jJLfZxUhh2oQjvmm86qclThLqwUfg8IWEI/7JoTtRqfwBupOIcYls9+joxq9koJl En0IF734KblrlXbhemvPHv3XJQ6bZVNsLePpM0WWGFImz1/5iPRK3gQU5ZDyX/ppebnaaNrZZdb6e Un8vYQJJnLvgd4t8l+uqACByVhRtLXuhv5fbaMy0J+jRXL/hhNKblA2loeXja69zji5tNjUbnrbIF Sn0TkF5pV17qDm4r3+/+Uqu0AQdmIHGTpoC9WNR4EqooyLgU6EF3zyt9PMrtydij1G40f3+6/pJqL N5cCDMNJfneihP8oUDzw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSIG1-0003Zx-6a; Sun, 19 May 2019 09:37:29 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSIFy-0003ZW-DV; Sun, 19 May 2019 09:37:27 +0000 X-UUID: 6a662886c7fb40c6b9f915f20e415bd6-20190519 X-UUID: 6a662886c7fb40c6b9f915f20e415bd6-20190519 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 583602238; Sun, 19 May 2019 01:37:26 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 19 May 2019 02:37:24 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 19 May 2019 17:37:22 +0800 Received: from [10.16.6.141] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sun, 19 May 2019 17:37:21 +0800 Message-ID: <1558258641.367.6.camel@mszsdaap41> Subject: Re: [v3 3/3] drm/mediatek: add mt8183 dpi support From: Jitao Shi To: CK Hu Date: Sun, 19 May 2019 17:37:21 +0800 In-Reply-To: <1557214887.3498.7.camel@mtksdaap41> References: <20190416055242.75764-1-jitao.shi@mediatek.com> <20190416055242.75764-4-jitao.shi@mediatek.com> <1557214887.3498.7.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190519_023726_455128_6521919C X-CRM114-Status: GOOD ( 16.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , stonea168@163.com, dri-devel@lists.freedesktop.org, yingjoe.chen@mediatek.com, Ajay Kumar , Vincent Palatin , cawa.cheng@mediatek.com, bibby.hsieh@mediatek.com, Russell King , Thierry Reding , linux-pwm@vger.kernel.org, Sascha Hauer , Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , linux-mediatek@lists.infradead.org, Andy Yan , Matthias Brugger , eddie.huang@mediatek.com, linux-arm-kernel@lists.infradead.org, Rahul Sharma , srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, Philipp Zabel , Kumar Gala , Sean Paul Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2019-05-07 at 15:41 +0800, CK Hu wrote: > Hi, Jitao: > > On Tue, 2019-04-16 at 13:52 +0800, Jitao Shi wrote: > > I need the commit message. Even though the code is easy to understand, > words for this patch is still necessary. > > Regards, > CK > I'll fine tune the commit message next version. Best Regards Jitao > > Signed-off-by: Jitao Shi > > --- > > drivers/gpu/drm/mediatek/mtk_dpi.c | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c > > index 66405159141a..fbb087218775 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > > @@ -681,6 +681,16 @@ static unsigned int mt2701_calculate_factor(int clock) > > return 2; > > } > > > > +static unsigned int mt8183_calculate_factor(int clock) > > +{ > > + if (clock <= 27000) > > + return 8; > > + else if (clock <= 167000) > > + return 4; > > + else > > + return 2; > > +} > > + > > static const struct mtk_dpi_conf mt8173_conf = { > > .cal_factor = mt8173_calculate_factor, > > .reg_h_fre_con = 0xe0, > > @@ -692,6 +702,12 @@ static const struct mtk_dpi_conf mt2701_conf = { > > .edge_sel_en = true, > > }; > > > > +static const struct mtk_dpi_conf mt8183_conf = { > > + .cal_factor = mt8183_calculate_factor, > > + .reg_h_fre_con = 0xe0, > > + .dual_edge = true, > > +}; > > + > > static int mtk_dpi_probe(struct platform_device *pdev) > > { > > struct device *dev = &pdev->dev; > > @@ -787,6 +803,9 @@ static const struct of_device_id mtk_dpi_of_ids[] = { > > { .compatible = "mediatek,mt8173-dpi", > > .data = &mt8173_conf, > > }, > > + { .compatible = "mediatek,mt8183-dpi", > > + .data = &mt8183_conf, > > + }, > > { }, > > }; > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel